mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-27 06:43:32 +00:00
50c943690c
Lift `aIid` to compile-time, as a template parameter `InterfaceT`. This simplifies the common case for using `Resolve()`, where the desired and supplied interfaces are the same. (For the as-yet-unattested case where they're not, retain the old functionality by means of a small family of `ResolveAs()` functions.) Additionally, to eliminate a swath of custom logic and magic-number choices surrounding `mHResult`, eliminate `mHResult` itself as well. Instead, since its value was derived from the creation of the underlying `IAgileReference`, any callers that might care can acquire it as an additional return value from a named-constructor function. These collectively trim `AgileReference`'s footprint down to a single `RefPtr`, with all its special member functions having only default implementations. Differential Revision: https://phabricator.services.mozilla.com/D196513
144 lines
5.0 KiB
C++
144 lines
5.0 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_mscom_AgileReference_h
|
|
#define mozilla_mscom_AgileReference_h
|
|
|
|
#include "mozilla/Attributes.h"
|
|
#include "mozilla/RefPtr.h"
|
|
#include "mozilla/Result.h"
|
|
#include "mozilla/Unused.h"
|
|
#include "nsDebug.h"
|
|
#include "nsISupportsImpl.h"
|
|
|
|
#include <objidl.h>
|
|
|
|
namespace mozilla::mscom {
|
|
|
|
namespace detail {
|
|
// Detemplatized implementation details of `AgileReference`.
|
|
HRESULT AgileReference_CreateImpl(RefPtr<IAgileReference>&, REFIID, IUnknown*);
|
|
HRESULT AgileReference_ResolveImpl(RefPtr<IAgileReference> const&, REFIID,
|
|
void**);
|
|
} // namespace detail
|
|
|
|
/**
|
|
* This class encapsulates an "agile reference". These are references that allow
|
|
* you to pass COM interfaces between apartments. When you have an interface
|
|
* that you would like to pass between apartments, you wrap that interface in an
|
|
* AgileReference and pass that instead. Then you can "unwrap" the interface by
|
|
* calling Resolve(), which will return a proxy object implementing the same
|
|
* interface.
|
|
*
|
|
* Sample usage:
|
|
*
|
|
* ```
|
|
* // From a non-main thread, where `foo` is an `IFoo*` or `RefPtr<IFoo>`:
|
|
* auto myAgileRef = AgileReference(foo);
|
|
* NS_DispatchToMainThread([mar = std::move(myAgileRef)] {
|
|
* RefPtr<IFoo> foo = mar.Resolve();
|
|
* // Now methods may be invoked on `foo`
|
|
* });
|
|
* ```
|
|
*/
|
|
template <typename InterfaceT>
|
|
class AgileReference final {
|
|
static_assert(
|
|
std::is_base_of_v<IUnknown, InterfaceT>,
|
|
"template parameter of AgileReference must be a COM interface type");
|
|
|
|
public:
|
|
AgileReference() = default;
|
|
~AgileReference() = default;
|
|
|
|
AgileReference(const AgileReference& aOther) = default;
|
|
AgileReference(AgileReference&& aOther) noexcept = default;
|
|
|
|
AgileReference& operator=(const AgileReference& aOther) = default;
|
|
AgileReference& operator=(AgileReference&& aOther) noexcept = default;
|
|
|
|
AgileReference& operator=(std::nullptr_t) {
|
|
mAgileRef = nullptr;
|
|
return *this;
|
|
}
|
|
|
|
// Create a new AgileReference from an existing COM object.
|
|
//
|
|
// These constructors do not provide the HRESULT on failure. If that's
|
|
// desired, use `AgileReference::Create()`, below.
|
|
explicit AgileReference(InterfaceT* aObject) {
|
|
HRESULT const hr = detail::AgileReference_CreateImpl(
|
|
mAgileRef, __uuidof(InterfaceT), aObject);
|
|
Unused << NS_WARN_IF(FAILED(hr));
|
|
}
|
|
explicit AgileReference(RefPtr<InterfaceT> const& aObject)
|
|
: AgileReference(aObject.get()) {}
|
|
|
|
// Create a new AgileReference from an existing COM object, or alternatively,
|
|
// return the HRESULT explaining why one couldn't be created.
|
|
//
|
|
// A convenience wrapper `MakeAgileReference()` which infers `InterfaceT` from
|
|
// the RefPtr's concrete type is provided below.
|
|
static Result<AgileReference<InterfaceT>, HRESULT> Create(
|
|
RefPtr<InterfaceT> const& aObject) {
|
|
AgileReference ret;
|
|
HRESULT const hr = detail::AgileReference_CreateImpl(
|
|
ret.mAgileRef, __uuidof(InterfaceT), aObject.get());
|
|
if (FAILED(hr)) {
|
|
return Err(hr);
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
explicit operator bool() const { return !!mAgileRef; }
|
|
|
|
// Common case: resolve directly to the originally-specified interface-type.
|
|
RefPtr<InterfaceT> Resolve() const {
|
|
auto res = ResolveAs<InterfaceT>();
|
|
if (res.isErr()) return nullptr;
|
|
return res.unwrap();
|
|
}
|
|
|
|
// Uncommon cases: resolve directly to a different interface type, and/or
|
|
// provide IAgileReference::Resolve()'s HRESULT.
|
|
//
|
|
// When used in other COM apartments, `IAgileInterface::Resolve()` returns a
|
|
// proxy object which (at time of writing) is not documented to provide any
|
|
// interface other than the one for which it was instantiated. (Calling
|
|
// `QueryInterface` _might_ work, but isn't explicitly guaranteed.)
|
|
//
|
|
template <typename OtherInterface = InterfaceT>
|
|
Result<RefPtr<OtherInterface>, HRESULT> ResolveAs() const {
|
|
RefPtr<OtherInterface> p;
|
|
auto const hr = ResolveRaw(__uuidof(OtherInterface), getter_AddRefs(p));
|
|
if (FAILED(hr)) {
|
|
return Err(hr);
|
|
}
|
|
return p;
|
|
}
|
|
|
|
// Raw version of Resolve/ResolveAs. Rarely, if ever, preferable to the
|
|
// statically-typed versions.
|
|
HRESULT ResolveRaw(REFIID aIid, void** aOutInterface) const {
|
|
return detail::AgileReference_ResolveImpl(mAgileRef, aIid, aOutInterface);
|
|
}
|
|
|
|
private:
|
|
RefPtr<IAgileReference> mAgileRef;
|
|
};
|
|
|
|
// Attempt to create an AgileReference from a refcounted interface pointer,
|
|
// providing the HRESULT as a secondary return-value.
|
|
template <typename InterfaceT>
|
|
inline Result<AgileReference<InterfaceT>, HRESULT> MakeAgileReference(
|
|
RefPtr<InterfaceT> const& aObj) {
|
|
return AgileReference<InterfaceT>::Create(aObj);
|
|
}
|
|
|
|
} // namespace mozilla::mscom
|
|
|
|
#endif // mozilla_mscom_AgileReference_h
|