mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-27 23:02:20 +00:00
1f4a9dd483
Add the customary bevy of thread-safety annotations to the Mutex types in memory/build. Almost all existing instances of these Mutexes are already marked with MOZ_UNANNOTATED, but this turns out not to matter: MOZ_UNANNOTATED has no equivalent under clang's `-Wthread-safety` attributes. There are no variables declared to be guarded by these mutexes, but they must still be unlocked and relocked in principled ways -- or, alternatively, only have unverifiable actions taken in appropriately-annotated code. The primary offenders here are the `pthread_atfork` hooks; these can't all be annotated precisely (and couldn't be checked even if they were), so we simply mark them all as unanalyzable. The only other warning is from a highly unusual (but already well-commented) bit in PHC.cpp where we manually release an autolocked mutex before crashing. Differential Revision: https://phabricator.services.mozilla.com/D150519 |
||
---|---|---|
.. | ||
build | ||
gtest | ||
mozalloc | ||
mozjemalloc_info | ||
replace | ||
volatile | ||
app.mozbuild | ||
moz.build | ||
moz.configure |