gecko-dev/modules/libjar/MmapFaultHandler.cpp
Michal Novotny 844eb9e10d Bug 1583735 - Find out why accessing mmaped JAR file generates SIGBUS, r=gcp,aklotz
When we have nsZipHandle available (which is the case of crashes from bugs 1550815, 1564444 and 1564921), we send following information in the crash report:
 - file name
 - current file size
 - buffer address
 - buffer length
 - address that generated SIGBUS

Differential Revision: https://phabricator.services.mozilla.com/D48847

--HG--
extra : moz-landing-system : lando
2019-10-23 19:06:55 +00:00

177 lines
5.7 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "MmapFaultHandler.h"
#if defined(XP_UNIX) && !defined(XP_DARWIN)
# include "nsZipArchive.h"
# include "mozilla/Atomics.h"
# include "mozilla/StaticMutex.h"
# include "MainThreadUtils.h"
# include "mozilla/ThreadLocal.h"
# include <signal.h>
static MOZ_THREAD_LOCAL(MmapAccessScope*) sMmapAccessScope;
static struct sigaction sPrevSIGBUSHandler;
static void MmapSIGBUSHandler(int signum, siginfo_t* info, void* context) {
MOZ_RELEASE_ASSERT(signum == SIGBUS);
MmapAccessScope* mas = sMmapAccessScope.get();
if (mas && mas->IsInsideBuffer(info->si_addr)) {
// Temporarily instead of handling the signal, we crash intentionally and
// send some diagnostic information to find out why the signal is received.
mas->CrashWithInfo(info->si_addr);
// The address is inside the buffer, handle the failure.
siglongjmp(mas->mJmpBuf, signum);
return;
}
// This signal is not caused by accessing region protected by MmapAccessScope.
// Forward the signal to the next handler.
if (sPrevSIGBUSHandler.sa_flags & SA_SIGINFO) {
sPrevSIGBUSHandler.sa_sigaction(signum, info, context);
} else if (sPrevSIGBUSHandler.sa_handler == SIG_DFL ||
sPrevSIGBUSHandler.sa_handler == SIG_IGN) {
// There is no next handler. Uninstalling our handler and returning will
// cause a crash.
sigaction(signum, &sPrevSIGBUSHandler, nullptr);
} else {
sPrevSIGBUSHandler.sa_handler(signum);
}
}
mozilla::Atomic<bool> gSIGBUSHandlerInstalled(false);
mozilla::StaticMutex gSIGBUSHandlerMutex;
void InstallMmapFaultHandler() {
// This function is called from MmapAccessScope's constructor because there is
// no single point where we could install the handler during startup. This
// means that it's called quite often, so to minimize using of the mutex we
// first check the atomic variable outside the lock.
if (gSIGBUSHandlerInstalled) {
return;
}
mozilla::StaticMutexAutoLock lock(gSIGBUSHandlerMutex);
// We must check it again, because the handler could be installed on another
// thread when we were waiting for the lock.
if (gSIGBUSHandlerInstalled) {
return;
}
sMmapAccessScope.infallibleInit();
struct sigaction busHandler;
busHandler.sa_flags = SA_SIGINFO | SA_NODEFER | SA_ONSTACK;
busHandler.sa_sigaction = MmapSIGBUSHandler;
sigemptyset(&busHandler.sa_mask);
if (sigaction(SIGBUS, &busHandler, &sPrevSIGBUSHandler)) {
MOZ_CRASH("Unable to install SIGBUS handler");
}
gSIGBUSHandlerInstalled = true;
}
MmapAccessScope::MmapAccessScope(void* aBuf, uint32_t aBufLen) {
// Install signal handler if it wasn't installed yet.
InstallMmapFaultHandler();
// We'll handle the signal only if the crashing address is inside this buffer.
mBuf = aBuf;
mBufLen = aBufLen;
SetThreadLocalScope();
}
MmapAccessScope::MmapAccessScope(nsZipHandle* aZipHandle)
: mBuf(nullptr), mBufLen(0) {
// Install signal handler if it wasn't installed yet.
InstallMmapFaultHandler();
// It's OK if aZipHandle is null (e.g. called from nsJARInputStream::Read
// when mFd was already release), because no access to mmapped memory is made
// in this case.
if (aZipHandle && aZipHandle->mMap) {
// Handle SIGBUS only when it's an mmaped zip file.
mZipHandle = aZipHandle;
}
SetThreadLocalScope();
}
MmapAccessScope::~MmapAccessScope() {
MOZ_RELEASE_ASSERT(sMmapAccessScope.get() == this);
sMmapAccessScope.set(mPreviousScope);
}
void MmapAccessScope::SetThreadLocalScope() {
// mJmpBuf is set outside of this classs for reasons mentioned in the header
// file, but we need to initialize the member here too to make Coverity happy.
memset(mJmpBuf, 0, sizeof(sigjmp_buf));
// If MmapAccessScopes are nested, save the previous one and restore it in
// the destructor.
mPreviousScope = sMmapAccessScope.get();
// MmapAccessScope is now set up (except mJmpBuf for reasons mentioned in the
// header file). Store the pointer in a thread-local variable sMmapAccessScope
// so we can use it in the handler if the signal is triggered.
sMmapAccessScope.set(this);
}
bool MmapAccessScope::IsInsideBuffer(void* aPtr) {
bool isIn;
if (mZipHandle) {
isIn =
aPtr >= mZipHandle->mFileStart &&
aPtr < (void*)((char*)mZipHandle->mFileStart + mZipHandle->mTotalLen);
} else {
isIn = aPtr >= mBuf && aPtr < (void*)((char*)mBuf + mBufLen);
}
return isIn;
}
void MmapAccessScope::CrashWithInfo(void* aPtr) {
if (!mZipHandle) {
// All we have is the buffer and the crashing address.
MOZ_CRASH_UNSAFE_PRINTF(
"SIGBUS received when accessing mmaped zip file [buffer=%p, "
"buflen=%" PRIu32 ", address=%p]",
mBuf, mBufLen, aPtr);
}
nsCOMPtr<nsIFile> file = mZipHandle->mFile.GetBaseFile();
nsCString fileName;
file->GetNativeLeafName(fileName);
// Get current file size
int fileSize = -1;
if (PR_Seek64(mZipHandle->mNSPRFileDesc, 0, PR_SEEK_SET) != -1) {
fileSize = PR_Available64(mZipHandle->mNSPRFileDesc);
}
// MOZ_CRASH_UNSAFE_PRINTF has limited number of arguments, so append fileSize
// to fileName
fileName.Append(", filesize=");
fileName.AppendInt(fileSize);
MOZ_CRASH_UNSAFE_PRINTF(
"SIGBUS received when accessing mmaped zip file [file=%s, buffer=%p, "
"buflen=%" PRIu32 ", address=%p]",
fileName.get(), (char*)mZipHandle->mFileStart, mZipHandle->mTotalLen,
aPtr);
}
#endif