mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-18 15:55:36 +00:00
14784dc42d
mozStorage used to read prefs on service init, because they could only be read on the main-thread. When service init was moved earlier, it started trying to read prefs too early, before the profile was set up, thus it ended up always reading the default value. This patch moves the only relevant pref to mirrored StaticPrefs that can be accessed from different threads, and removes two preferences that apparently are not necessary (they have been broken from a long time) for now. In particular, providing a global synchronous setting is a footgun, each consumer should decide about their synchronous needs, rather than abusing a dangerous "go fast" setting. The page size is something we don't change from quite some time, and it's unlikely to be used to run experiments in the wild before doing local measurements first, for which Try builds are enough. The remaining exclusiveLock pref is a bit controversial, because in general exclusive lock is better for various reasons, and mostly it is necessary to use WAL on network shares. Though developers may find it useful for debugging, and some third parties are doing dangerous things (like copying over databases) to work around it, for which it's safer to provide a less dangerous alternative. Note exclusive lock only works on Unix-derived systems for now (no Windows implementation). Finally, this introduces a fallback to exclusive lock, so that if a third party is using our databases, so that we can't get an exclusive lock, we'll fallback to normal locking. Differential Revision: https://phabricator.services.mozilla.com/D82717 |
||
|---|---|---|
| .. | ||
| build | ||
| rust | ||
| test | ||
| variant | ||
| FileSystemModule.cpp | ||
| FileSystemModule.h | ||
| IStorageBindingParamsInternal.h | ||
| moz.build | ||
| mozIStorageAsyncConnection.idl | ||
| mozIStorageAsyncStatement.idl | ||
| mozIStorageBaseStatement.idl | ||
| mozIStorageBindingParams.idl | ||
| mozIStorageBindingParamsArray.idl | ||
| mozIStorageCompletionCallback.idl | ||
| mozIStorageConnection.idl | ||
| mozIStorageError.idl | ||
| mozIStorageFunction.idl | ||
| mozIStoragePendingStatement.idl | ||
| mozIStorageProgressHandler.idl | ||
| mozIStorageResultSet.idl | ||
| mozIStorageRow.idl | ||
| mozIStorageService.idl | ||
| mozIStorageStatement.idl | ||
| mozIStorageStatementCallback.idl | ||
| mozIStorageVacuumParticipant.idl | ||
| mozIStorageValueArray.idl | ||
| mozStorageArgValueArray.cpp | ||
| mozStorageArgValueArray.h | ||
| mozStorageAsyncStatement.cpp | ||
| mozStorageAsyncStatement.h | ||
| mozStorageAsyncStatementExecution.cpp | ||
| mozStorageAsyncStatementExecution.h | ||
| mozStorageAsyncStatementJSHelper.cpp | ||
| mozStorageAsyncStatementJSHelper.h | ||
| mozStorageAsyncStatementParams.cpp | ||
| mozStorageAsyncStatementParams.h | ||
| mozStorageBindingParams.cpp | ||
| mozStorageBindingParams.h | ||
| mozStorageBindingParamsArray.cpp | ||
| mozStorageBindingParamsArray.h | ||
| mozStorageConnection.cpp | ||
| mozStorageConnection.h | ||
| mozStorageError.cpp | ||
| mozStorageError.h | ||
| mozStorageHelper.h | ||
| mozStoragePrivateHelpers.cpp | ||
| mozStoragePrivateHelpers.h | ||
| mozStorageResultSet.cpp | ||
| mozStorageResultSet.h | ||
| mozStorageRow.cpp | ||
| mozStorageRow.h | ||
| mozStorageService.cpp | ||
| mozStorageService.h | ||
| mozStorageSQLFunctions.cpp | ||
| mozStorageSQLFunctions.h | ||
| mozStorageStatement.cpp | ||
| mozStorageStatement.h | ||
| mozStorageStatementData.h | ||
| mozStorageStatementJSHelper.cpp | ||
| mozStorageStatementJSHelper.h | ||
| mozStorageStatementParams.cpp | ||
| mozStorageStatementParams.h | ||
| mozStorageStatementRow.cpp | ||
| mozStorageStatementRow.h | ||
| SQLCollations.cpp | ||
| SQLCollations.h | ||
| SQLiteMutex.h | ||
| StatementCache.h | ||
| storage.h | ||
| StorageBaseStatementInternal.cpp | ||
| StorageBaseStatementInternal.h | ||
| style.txt | ||
| TelemetryVFS.cpp | ||
| VacuumManager.cpp | ||
| VacuumManager.h | ||
| Variant_inl.h | ||
| Variant.cpp | ||
| Variant.h | ||
| variantToSQLiteT_impl.h | ||