mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-03 18:47:53 +00:00
f7a8b4c054
The published recommendation of L1 for WebAuthn changed the visibility/focus listening behaviors to a SHOULD [1], and Chromium, for reasons like our SoftU2F bug [0], opted to not interrupt on tabswitch/visibility change. Let's do the same thing. This changes the visibility mechanism to set a flag on an ongoing transaction, and then, upon multiple calls to the FIDO/U2F functions, only aborts if visibility had changed. Otherwise, subsequent callers return early. This is harder to explain than it is really to use as a user. I think. At least, my testing feels natural when I'm working within two windows, both potentially prompting WebAuthn. Note: This also affects FIDO U2F API. [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1448408#c0 [1] https://www.w3.org/TR/webauthn-1/#abortoperation Differential Revision: https://phabricator.services.mozilla.com/D25160 --HG-- extra : moz-landing-system : lando
150 lines
4.4 KiB
C++
150 lines
4.4 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "mozilla/dom/WebAuthnManagerBase.h"
|
|
#include "mozilla/dom/WebAuthnTransactionChild.h"
|
|
#include "mozilla/dom/Event.h"
|
|
#include "nsGlobalWindowInner.h"
|
|
#include "nsPIWindowRoot.h"
|
|
|
|
namespace mozilla {
|
|
namespace dom {
|
|
|
|
NS_NAMED_LITERAL_STRING(kDeactivateEvent, "deactivate");
|
|
NS_NAMED_LITERAL_STRING(kVisibilityChange, "visibilitychange");
|
|
|
|
WebAuthnManagerBase::WebAuthnManagerBase(nsPIDOMWindowInner* aParent)
|
|
: mParent(aParent) {
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
MOZ_ASSERT(aParent);
|
|
}
|
|
|
|
WebAuthnManagerBase::~WebAuthnManagerBase() { MOZ_ASSERT(NS_IsMainThread()); }
|
|
|
|
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(WebAuthnManagerBase)
|
|
NS_INTERFACE_MAP_ENTRY(nsISupports)
|
|
NS_INTERFACE_MAP_ENTRY(nsIDOMEventListener)
|
|
NS_INTERFACE_MAP_END
|
|
|
|
NS_IMPL_CYCLE_COLLECTION(WebAuthnManagerBase, mParent)
|
|
|
|
NS_IMPL_CYCLE_COLLECTING_ADDREF(WebAuthnManagerBase)
|
|
NS_IMPL_CYCLE_COLLECTING_RELEASE(WebAuthnManagerBase)
|
|
|
|
/***********************************************************************
|
|
* IPC Protocol Implementation
|
|
**********************************************************************/
|
|
|
|
bool WebAuthnManagerBase::MaybeCreateBackgroundActor() {
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
|
|
if (mChild) {
|
|
return true;
|
|
}
|
|
|
|
PBackgroundChild* actorChild = BackgroundChild::GetOrCreateForCurrentThread();
|
|
if (NS_WARN_IF(!actorChild)) {
|
|
return false;
|
|
}
|
|
|
|
RefPtr<WebAuthnTransactionChild> mgr(new WebAuthnTransactionChild(this));
|
|
PWebAuthnTransactionChild* constructedMgr =
|
|
actorChild->SendPWebAuthnTransactionConstructor(mgr);
|
|
|
|
if (NS_WARN_IF(!constructedMgr)) {
|
|
return false;
|
|
}
|
|
|
|
MOZ_ASSERT(constructedMgr == mgr);
|
|
mChild = mgr.forget();
|
|
|
|
return true;
|
|
}
|
|
|
|
void WebAuthnManagerBase::ActorDestroyed() {
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
mChild = nullptr;
|
|
}
|
|
|
|
/***********************************************************************
|
|
* Event Handling
|
|
**********************************************************************/
|
|
|
|
void WebAuthnManagerBase::ListenForVisibilityEvents() {
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
|
|
nsCOMPtr<nsPIDOMWindowOuter> outer = mParent->GetOuterWindow();
|
|
if (NS_WARN_IF(!outer)) {
|
|
return;
|
|
}
|
|
|
|
nsCOMPtr<EventTarget> windowRoot = outer->GetTopWindowRoot();
|
|
if (NS_WARN_IF(!windowRoot)) {
|
|
return;
|
|
}
|
|
|
|
nsresult rv = windowRoot->AddEventListener(kDeactivateEvent, this,
|
|
/* use capture */ true,
|
|
/* wants untrusted */ false);
|
|
Unused << NS_WARN_IF(NS_FAILED(rv));
|
|
|
|
rv = windowRoot->AddEventListener(kVisibilityChange, this,
|
|
/* use capture */ true,
|
|
/* wants untrusted */ false);
|
|
Unused << NS_WARN_IF(NS_FAILED(rv));
|
|
}
|
|
|
|
void WebAuthnManagerBase::StopListeningForVisibilityEvents() {
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
|
|
nsCOMPtr<nsPIDOMWindowOuter> outer = mParent->GetOuterWindow();
|
|
if (NS_WARN_IF(!outer)) {
|
|
return;
|
|
}
|
|
|
|
nsCOMPtr<EventTarget> windowRoot = outer->GetTopWindowRoot();
|
|
if (NS_WARN_IF(!windowRoot)) {
|
|
return;
|
|
}
|
|
|
|
windowRoot->RemoveEventListener(kDeactivateEvent, this,
|
|
/* use capture */ true);
|
|
windowRoot->RemoveEventListener(kVisibilityChange, this,
|
|
/* use capture */ true);
|
|
}
|
|
|
|
NS_IMETHODIMP
|
|
WebAuthnManagerBase::HandleEvent(Event* aEvent) {
|
|
MOZ_ASSERT(NS_IsMainThread());
|
|
MOZ_ASSERT(aEvent);
|
|
|
|
nsAutoString type;
|
|
aEvent->GetType(type);
|
|
if (!type.Equals(kDeactivateEvent) && !type.Equals(kVisibilityChange)) {
|
|
return NS_ERROR_FAILURE;
|
|
}
|
|
|
|
// The "deactivate" event on the root window has no
|
|
// "current inner window" and thus GetTarget() is always null.
|
|
if (type.Equals(kVisibilityChange)) {
|
|
nsCOMPtr<Document> doc = do_QueryInterface(aEvent->GetTarget());
|
|
if (NS_WARN_IF(!doc) || !doc->Hidden()) {
|
|
return NS_OK;
|
|
}
|
|
|
|
nsGlobalWindowInner* win = nsGlobalWindowInner::Cast(doc->GetInnerWindow());
|
|
if (NS_WARN_IF(!win) || !win->IsTopInnerWindow()) {
|
|
return NS_OK;
|
|
}
|
|
}
|
|
|
|
HandleVisibilityChange();
|
|
return NS_OK;
|
|
}
|
|
|
|
} // namespace dom
|
|
} // namespace mozilla
|