gecko-dev/dom
Patrick McManus 175115e709 bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz
These scriptable interfaces use uint_64 arguments with sentinel values
of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot
be gatewayed to/from javascript - so they cannot be used
correctly. Change them to use signed 64 bit numbers and -1 as the
sentinnel. C++ implementations ought to be enough to audit as the
special value could never be used correctly in JS anyhow - also
audited OnProgressChange() uses for downstream use of this data.
---
 dom/base/nsXMLHttpRequest.cpp                      | 19 +++++++----
 dom/base/nsXMLHttpRequest.h                        | 10 +++---
 dom/plugins/base/nsPluginStreamListenerPeer.cpp    |  4 +--
 .../webbrowserpersist/nsWebBrowserPersist.cpp      | 14 ++++----
 image/src/imgLoader.cpp                            |  4 +--
 modules/libjar/nsJARChannel.cpp                    |  3 +-
 netwerk/base/public/nsIProgressEventSink.idl       |  8 ++---
 netwerk/base/public/nsITransport.idl               |  8 ++---
 netwerk/base/public/nsNetUtil.h                    | 24 ++++++++++++++
 netwerk/base/src/Dashboard.cpp                     |  2 +-
 netwerk/base/src/nsBaseChannel.cpp                 | 12 +++----
 netwerk/base/src/nsIncrementalDownload.cpp         |  4 +--
 netwerk/base/src/nsSocketTransport2.cpp            |  5 +--
 netwerk/base/src/nsStreamTransportService.cpp      | 38 +++++++++++++---------
 netwerk/base/src/nsTransportUtils.cpp              | 12 +++----
 netwerk/protocol/file/nsFileChannel.cpp            |  8 +++--
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  4 +--
 netwerk/protocol/http/Http2Push.cpp                |  2 +-
 netwerk/protocol/http/Http2Session.cpp             |  2 +-
 netwerk/protocol/http/HttpChannelChild.cpp         | 31 +++++++++---------
 netwerk/protocol/http/HttpChannelChild.h           |  6 ++--
 netwerk/protocol/http/HttpChannelParent.cpp        |  4 +--
 netwerk/protocol/http/HttpChannelParent.h          |  4 +--
 netwerk/protocol/http/NullHttpTransaction.cpp      |  2 +-
 netwerk/protocol/http/PHttpChannel.ipdl            |  2 +-
 netwerk/protocol/http/SpdyPush31.cpp               |  2 +-
 netwerk/protocol/http/SpdySession31.cpp            |  2 +-
 netwerk/protocol/http/TunnelUtils.cpp              |  2 +-
 netwerk/protocol/http/nsAHttpTransaction.h         |  4 +--
 netwerk/protocol/http/nsHttpChannel.cpp            | 30 +++++++++++------
 netwerk/protocol/http/nsHttpConnection.cpp         |  4 +--
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  4 +--
 netwerk/protocol/http/nsHttpPipeline.cpp           |  4 +--
 netwerk/protocol/http/nsHttpPipeline.h             |  6 ++--
 netwerk/protocol/http/nsHttpResponseHead.cpp       |  2 +-
 netwerk/protocol/http/nsHttpResponseHead.h         |  2 +-
 netwerk/protocol/http/nsHttpTransaction.cpp        | 32 +++++++++---------
 netwerk/protocol/http/nsHttpTransaction.h          |  2 +-
 netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp   |  2 +-
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  3 +-
 netwerk/test/TestIncrementalDownload.cpp           |  7 ++--
 uriloader/base/nsDocLoader.cpp                     | 14 ++++----
 42 files changed, 203 insertions(+), 151 deletions(-)
2015-01-08 14:48:52 -05:00
..
activities
alarm Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
animation Bug 1119981. Disable test_deferred_start.html on b2g for race condition in test. r=bbirtles 2015-01-16 09:33:49 -08:00
apps Bug 1113779 - UserCustomizations.jsm spams desktop mochitest test logs r=mccr8 2015-01-16 14:16:03 -08:00
archivereader Bug 1113062 - patch 2 - ArchiveReaderZipFile non-CCed, r=smaug 2015-01-11 21:34:57 +00:00
asmjscache Bug 1114999 - Part 2: Apply MOZ_NO_ADDREF_RELEASE_ON_RETURN to all smart pointer arrow operators that can return refcounted objects; r=jrmuizel 2015-01-06 16:30:03 -05:00
audiochannel Bug 1107681 - fix up the dom uses of WrapptedJSToDictionary to use the cx-less interface. r=bholley 2014-12-29 11:56:00 +01:00
base bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz 2015-01-08 14:48:52 -05:00
battery Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
bindings Back out 3 changesets (bug 885982, bug 1118063) for b2g mochitest-6 bustage 2015-01-17 13:26:10 -08:00
bluetooth merge b2g-inbound to mozilla-central a=merge 2015-01-20 12:12:12 +01:00
bluetooth2 merge b2g-inbound to mozilla-central a=merge 2015-01-20 12:12:12 +01:00
broadcastchannel Bug 1122553 - BroadcastChannel should keep FileImpl alive when sent to the PBackground actors, r=bent 2015-01-17 07:29:15 +00:00
browser-element Bug 1111433 - Add mochitest to verify SelectionStateChanged with blur state. r=ehsan 2015-01-07 23:34:00 -05:00
camera merge b2g-inbound to mozilla-central a=merge 2015-01-12 14:59:45 +01:00
canvas Bug 1109945 - Rewrite shader/program handling. - r=kamidphish 2015-01-15 15:40:39 -08:00
cellbroadcast Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
contacts Bug 1114520 - [Flame][Contacts]All contacts will disappear after you delete one contact. r=gwagner 2015-01-15 08:47:49 +01:00
crypto Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
datastore Bug 1117167. Make the generated implementation classes for JS-implemented bindings store an nsIGlobalObject, not an nsPIDOMWindow, so we can use them in sandboxes. r=peterv 2015-01-08 11:57:19 -05:00
devicestorage Bug 914067 - Remove JSVAL_VOID from dom/; r=jst 2015-01-14 08:59:06 +01:00
downloads
encoding Backed out 12 changesets (bug 1096328) for M11 and M5 Test failures on a CLOSED TREE 2015-01-12 14:48:15 +01:00
engineeringmode
events Backed out changeset 142031795f33 (bug 992685) for failing w3 and w4 tests 2015-01-20 11:21:51 +01:00
fetch Backed out changeset 88970726eb6b (bug 1119044) for Werror bustage. 2015-01-13 13:26:52 -05:00
filehandle
filesystem
fmradio Backed out changeset 07b42d1d60aa (bug 1073003) 2014-12-23 13:35:17 +01:00
gamepad Bug 852257 - implement Gamepad.timestamp property; r=ted, r=smaug 2015-01-07 14:17:04 -05:00
geolocation Bug 1119513 - Change histogram from linear to exp. and buckets from 200 to 50. r=hannosch 2015-01-12 14:41:00 -05:00
html Backed out changeset c4d8cf5b47ef (bug 992685) 2015-01-20 11:21:25 +01:00
icc Merge mozilla-central to b2g-inbound 2015-01-08 15:44:18 +01:00
identity
imptests
indexedDB Bug 1120336 - Fix another hang with blobURL+workers+indexedDB+xhr, r=khuey. 2015-01-13 14:15:04 -08:00
inputmethod
interfaces Bug 1115691 patch 2 - Expose counts of frames constructed and reflowed on DOMWindowUtils. r=roc 2015-01-11 15:43:10 -08:00
ipc Bug 1082127 - Implement TabChild::SetDimensions so that window.moveTo/resizeTo work with e10s r=smaug 2015-01-19 15:55:02 -05:00
json
jsurl
locales Bug 1115668 - Fix inappropriate mixed content warning messages. r=tanvi 2014-12-30 23:09:33 +09:00
manifest Bug 1119670 - Implement processing of scope member of web manifest. r=ehsan 2015-01-15 19:46:00 -05:00
mathml
media Backed out changeset 8aeda1b1d2e4 (bug 992685) 2015-01-20 11:21:22 +01:00
messages Backed out 7 changesets (bug 1018320) 2015-01-04 08:40:27 -08:00
mobileconnection Bug 914067 - Remove JSVAL_VOID from dom/; r=jst 2015-01-14 08:59:06 +01:00
mobileid
mobilemessage Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
network Back out 3 changesets (bug 885982, bug 1118063) for b2g mochitest-6 bustage 2015-01-17 13:26:10 -08:00
nfc Bug 1093517 - remove impl for connect and close of MozNFCTag. r=dimi 2015-01-15 15:41:43 +08:00
notification Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
offline
payment Bug 1097928 - Convert MozPaymentProvider to WebIDL. Android. r=wjohnston 2015-01-19 14:50:54 +01:00
permission Back out 3 changesets (bug 885982, bug 1118063) for b2g mochitest-6 bustage 2015-01-17 13:26:10 -08:00
phonenumberutils
plugins bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz 2015-01-08 14:48:52 -05:00
power Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
presentation
promise Bug 914067 - Remove JSVAL_VOID from dom/; r=jst 2015-01-14 08:59:06 +01:00
push
quota Bug 1119462 - Allow unlimited quota for explicit persistent storage; r=bent 2015-01-09 16:56:23 +01:00
requestsync Backed out 7 changesets (bug 1018320) 2015-01-04 08:40:27 -08:00
res
resourcestats
security Bug 1116624 - Move CORS into dom/security (r=sicking) 2014-12-30 15:54:59 -08:00
settings Bug 1117252 - Re-enable settings mochitests that were disabled by bug 1113199; a=test-only 2015-01-03 11:15:51 -08:00
smil Bug 1118076 - Remove MOZ_THIS_IN_INITIALIZER_LIST. r=Waldo 2015-01-06 21:39:46 -08:00
speakermanager
storage Bug 1118609 - Mark virtual overridden functions as MOZ_OVERRIDE in dom/storage; r=baku 2015-01-07 10:22:00 -05:00
svg Bug 1119698 - ensure image elements take pointer-events into account r=jwatt 2015-01-19 15:06:01 +00:00
system Bug 1123072 - Fix build of GonkGPSGeolocationProvider on Flatfish. r=kchen 2015-01-19 03:00:00 +01:00
telephony Bug 1095362 - Part 6: Internal architecture changes (IPC). r=aknow 2015-01-09 01:42:00 -05:00
tests Bug 966439 - BroadcastChannel API - patch 3 - API disabled by pref, r=smaug 2015-01-15 16:58:41 +00:00
tethering
time Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
tv Bug 1118803 - Mark virtual overridden functions as MOZ_OVERRIDE in misc DOM code; r=baku 2015-01-08 08:49:54 -05:00
voicemail
vr Backed out 12 changesets (bug 1096328) for M11 and M5 Test failures on a CLOSED TREE 2015-01-12 14:48:15 +01:00
wappush Bug 1108900 - Part 2: rename MmsService. r=echen 2014-12-10 16:14:19 +08:00
webidl Backed out changeset 142031795f33 (bug 992685) for failing w3 and w4 tests 2015-01-20 11:21:51 +01:00
wifi Bug 1084156 - Turn to power saving mode when wifi connected. r=hchang 2014-12-26 01:52:00 -05:00
workers Bug 1122322 - Fix crash in worker memory reporter. r=bent. 2015-01-15 20:12:20 -08:00
xbl Bug 1118608 - Mark virtual overridden functions as MOZ_OVERRIDE in dom/xbl; r=baku 2015-01-07 10:20:48 -05:00
xml Bug 1118550 - Mark virtual overridden functions as MOZ_OVERRIDE in dom/xml; r=baku 2015-01-07 10:19:13 -05:00
xslt Backed out 12 changesets (bug 1096328) for M11 and M5 Test failures on a CLOSED TREE 2015-01-12 14:48:15 +01:00
xul Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj. 2015-01-19 16:11:34 -08:00
jar.mn
moz.build Bug 966439 - BroadcastChannel API - patch 1 - BroadcastChannel for main-thread, r=smaug, r=bent 2015-01-15 16:58:40 +00:00