gecko-dev/xpcom/string/nsTStringComparator.cpp
Nathan Froyd 17702bc8dd Bug 1305422 - part 3 - don't call size_forward in nsTStringComparator.cpp; r=erahm
Asking for size_forward on an iterator that you haven't started reading
from is just asking for the length of the original string, so use that
instead.
2016-09-29 22:33:58 -04:00

51 lines
1.5 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
int NS_FASTCALL
Compare(const nsTSubstring_CharT::base_string_type& aLhs,
const nsTSubstring_CharT::base_string_type& aRhs,
const nsTStringComparator_CharT& comp)
{
typedef nsTSubstring_CharT::size_type size_type;
if (&aLhs == &aRhs) {
return 0;
}
nsTSubstring_CharT::const_iterator leftIter, rightIter;
aLhs.BeginReading(leftIter);
aRhs.BeginReading(rightIter);
size_type lLength = aLhs.Length();
size_type rLength = aRhs.Length();
size_type lengthToCompare = XPCOM_MIN(lLength, rLength);
int result;
if ((result = comp(leftIter.get(), rightIter.get(),
lengthToCompare, lengthToCompare)) == 0) {
if (lLength < rLength) {
result = -1;
} else if (rLength < lLength) {
result = 1;
} else {
result = 0;
}
}
return result;
}
int
nsTDefaultStringComparator_CharT::operator()(const char_type* aLhs,
const char_type* aRhs,
uint32_t aLLength,
uint32_t aRLength) const
{
return
aLLength == aRLength ? nsCharTraits<CharT>::compare(aLhs, aRhs, aLLength) :
(aLLength > aRLength) ? 1 : -1;
}