mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-23 12:51:06 +00:00
421167ce85
We already cherry-picked this when we vendored 7fff587a09. Upstream commit: https://webrtc.googlesource.com/src/+/e94c7da1df402ab0193fe5bf010646c7eb08b629 Revert "Return audio stats regarless if we have a codec." This reverts commit 7fff587a096c6ef40f5601f47ef50b221b3a4abf. Reason for revert: breaks downstream test Original change's description: > Return audio stats regarless if we have a codec. > > Bug: b/331602608 > Change-Id: I2d12a3ed83645fe1e7cbd8950fd86d5ba2d7c94d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361743 > Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org> > Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#42964} Bug: b/331602608 Change-Id: Ia87ef3b3066e1373654e1f0d96726217e7ed4117 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361761 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Jakob Ivarsson <jakobi@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#42965}
47 lines
1.8 KiB
Diff
47 lines
1.8 KiB
Diff
From: Dan Minor <dminor@mozilla.com>
|
|
Date: Mon, 5 Nov 2018 10:33:00 -0500
|
|
Subject: Bug 1376873 - Reduce thread stack size in platform_thread.cc; r=bwc
|
|
|
|
Summary:
|
|
The current default stack size of 1M results in intermittent OOMs on win32
|
|
builds while running web-platform tests. The value of 256k was chosen for
|
|
consistency with the default value used elsewhere in Gecko, which is defined in
|
|
nsIThreadManager.idl.
|
|
|
|
Reviewers: bwc
|
|
|
|
Tags: #secure-revision
|
|
|
|
Bug #: 1376873
|
|
|
|
Differential Revision: https://phabricator.services.mozilla.com/D11090
|
|
Mercurial Revision: https://hg.mozilla.org/mozilla-central/rev/e83c311e5293902be4db4ecea17cff87c633f7cf
|
|
---
|
|
rtc_base/platform_thread.cc | 6 ++++--
|
|
1 file changed, 4 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/rtc_base/platform_thread.cc b/rtc_base/platform_thread.cc
|
|
index 6af1f3f616..f75ce8c3dc 100644
|
|
--- a/rtc_base/platform_thread.cc
|
|
+++ b/rtc_base/platform_thread.cc
|
|
@@ -191,15 +191,17 @@ PlatformThread PlatformThread::SpawnThread(
|
|
// Set the reserved stack stack size to 1M, which is the default on Windows
|
|
// and Linux.
|
|
DWORD thread_id = 0;
|
|
+ // Mozilla: Set to 256kb for consistency with nsIThreadManager.idl
|
|
PlatformThread::Handle handle = ::CreateThread(
|
|
- nullptr, 1024 * 1024, &RunPlatformThread, start_thread_function_ptr,
|
|
+ nullptr, 256 * 1024, &RunPlatformThread, start_thread_function_ptr,
|
|
STACK_SIZE_PARAM_IS_A_RESERVATION, &thread_id);
|
|
RTC_CHECK(handle) << "CreateThread failed";
|
|
#else
|
|
pthread_attr_t attr;
|
|
pthread_attr_init(&attr);
|
|
// Set the stack stack size to 1M.
|
|
- pthread_attr_setstacksize(&attr, 1024 * 1024);
|
|
+ // Mozilla: Set to 256kb for consistency with nsIThreadManager.idl
|
|
+ pthread_attr_setstacksize(&attr, 256 * 1024);
|
|
pthread_attr_setdetachstate(
|
|
&attr, joinable ? PTHREAD_CREATE_JOINABLE : PTHREAD_CREATE_DETACHED);
|
|
PlatformThread::Handle handle;
|