Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Emilio Cobos Álvarez 1e06c8368f Bug 1826072 - Don't flex permission state label. r=pbz
Err, so the original patch is necessary but not sufficient, and I
clearly goofed my testing (I had removed this attribute in a separate
commit).

The issue is that this button ends up with a markup like:

  <button class="permission-popup-permission-remove-button">
    <label flex="1" class="permission-popup-permission-state-label">Allowed Temporarily</label>
    <hbox class="box-inherit button-box" align="center" pack="center" flex="1" anonid="button-box">
      <image class="button-icon"/>
      <label class="button-text"/>
    </hbox>
  </button>

So the label and hbox divide the available space in half. Removing any
of the flex="1" attributes would cause the desired rendering.

I don't think the hbox needs to be flexible tbh, but ok, that's a
riskier change. I'm pretty sure the label in this case doesn't need to
be flexible at all though, specially since we don't want these buttons
to take any minimum amount of space.

An alternative would be to use `flex: 1 auto` or so for the label (via
CSS). That'd match the pre-regression behavior more exactly, but again I
don't think flexing the label is needed at all.

Depends on D174706

Differential Revision: https://phabricator.services.mozilla.com/D174707
2023-04-05 12:04:03 +00:00
.cargo Bug 1826241 - Update AudioIPC to 0b51291d. r=glandium 2023-04-04 20:27:04 +00:00
.vscode
accessible Bug 1825825 - Simplify NAC setup. r=smaug 2023-04-05 09:19:15 +00:00
browser Bug 1826072 - Don't flex permission state label. r=pbz 2023-04-05 12:04:03 +00:00
build Bug 1718171 - Add the clang runtime directory to LIB during configure. r=firefox-build-system-reviewers,andi 2023-04-05 00:16:52 +00:00
caps Bug 1825360 - Remove the NS_DISPATCH_SYNC flag, r=necko-reviewers,geckoview-reviewers,media-playback-reviewers,karlt,jesup,m_kato,emilio 2023-03-30 16:53:51 +00:00
chrome Bug 1819815 - Make chrome/ buildable outside of a unified build environment r=andi 2023-03-02 07:44:28 +00:00
config Backed out changeset 8725bf468d29 (bug 1808184) for breaking incremental builds (bug 1826114). a=backout 2023-04-04 16:48:15 +03:00
devtools Bug 1825825 - Tweak DevTools walker to preserve behavior after the previous patches. r=devtools-reviewers,nchevobbe 2023-04-05 09:19:16 +00:00
docs Bug 1826335 - Add kcochrane as a module peer for Fx View r=mkaply,zeid 2023-04-04 16:04:24 +00:00
docshell Bug 1576298 - Remove DeviceSizeIsPageSize from nsDocShell and nsPresContext. r=emilio 2023-04-03 17:11:24 +00:00
dom Bug 1826483 - Reinstate the CFRunLoopRunInMode call that was removed in bug 1800213. r=karlt 2023-04-05 11:19:54 +00:00
editor Bug 1825825 - Simplify NAC setup. r=smaug 2023-04-05 09:19:15 +00:00
extensions Bug 1825445: Ensure hunspell spell checker is not invoked with very long strings r=bholley,glandium 2023-04-04 20:59:33 +00:00
gfx Bug 1826499 - Put APZ scroll thumb position/size recalc code behind a pref. r=rzvncj 2023-04-05 08:50:21 +00:00
gradle/wrapper
hal Bug 1607634 - Part 4b: Changes for not-nullable actor types being wrapped in NotNull, r=ipc-reviewers,necko-reviewers,mccr8 2023-03-20 15:40:36 +00:00
image Bug 1825360 - Remove the NS_DISPATCH_SYNC flag, r=necko-reviewers,geckoview-reviewers,media-playback-reviewers,karlt,jesup,m_kato,emilio 2023-03-30 16:53:51 +00:00
intl Bug 1824511 - Make intl/unicharutil/util buildable outside of a unified build environment r=andi 2023-03-30 13:48:32 +00:00
ipc Backed out changeset a817ea947b55 (bug 1822863) for bustages on lower.py . CLOSED TREE 2023-04-05 00:09:21 +03:00
js Bug 1826078 part 4 - Optimize GC barriers for stores to MNewCallObject. r=iain 2023-04-05 11:37:15 +00:00
layout Bug 1825825 - Simplify NAC setup. r=smaug 2023-04-05 09:19:15 +00:00
media Bug 1825328 - Make media/libcubeb/*test buildable outside of a unified build environment r=andi 2023-03-31 13:29:45 +00:00
memory Bug 1826298 - Fix a use of an auto type without a reference r=glandium 2023-04-05 07:51:36 +00:00
mfbt Bug 1826077 - Make mfbt buildable outside of a unified build environment r=andi 2023-04-03 20:39:16 +00:00
mobile Bug 1510662 - Suppress Lint Warning: Using Private APIs. r=m_kato,geckoview-reviewers 2023-04-05 09:55:34 +00:00
modules Bug 1826499 - Put APZ scroll thumb position/size recalc code behind a pref. r=rzvncj 2023-04-05 08:50:21 +00:00
mozglue Bug 1818080 - [remote] Add profile markers for CDP, Marionette and WebDriver BiDi commands and events. r=webdriver-reviewers,canaltinova,jdescottes 2023-03-31 12:42:44 +00:00
netwerk Backed out changeset 8bab888ea4d4 (bug 1691658) for causing xpcshell failures in test_redirect_different-protocol_wrap.js. CLOSED TREE 2023-04-05 04:00:14 +03:00
nsprpub
other-licenses Bug 1815019 - Customize 7z to write provenance data r=nalexander 2023-03-02 16:44:10 +00:00
parser Bug 1826067 - Fix non-unified-build bustage in parser/htmlparser/nsScanner.cpp; r=sergesanspaille 2023-04-03 12:59:14 +00:00
python Bug 1740598 - When linting, process only the given revision when --rev is present r=ahal 2023-04-04 18:25:13 +00:00
remote Bug 1806792 - [bidi] Implement "input.releaseActions" command. r=webdriver-reviewers,whimboo 2023-04-04 12:05:08 +00:00
security Bug 1825682 - Avoid truncating the pids in Linux sandbox broker thread names. r=gcp 2023-04-03 19:47:31 +00:00
services No Bug, mozilla-central repo-update HSTS HPKP remote-settings - r=release-managers,RyanVM 2023-04-03 13:34:12 +00:00
servo Bug 1825825 - Simplify NAC setup. r=smaug 2023-04-05 09:19:15 +00:00
startupcache Bug 1817313 - Make startupcache/ buildable outside of a unified build environment r=andi 2023-02-19 21:40:36 +00:00
storage Bug 1822889 - Fix problems in ObfuscatingVFS with decoding frames read from the WAL file during recovery; r=dom-storage-reviewers,asuth,hsingh 2023-04-04 14:10:39 +00:00
supply-chain Bug 1814050 - [rust-mozbase] Move audits to wildcard audit entries. r=supply-chain-reviewers,bholley 2023-04-02 18:31:05 +00:00
taskcluster Bug 1806664 - Use python toolchain tasks to build firefox r=glandium,taskgraph-reviewers,ahal 2023-04-05 09:18:06 +00:00
testing Backed out changeset 8bab888ea4d4 (bug 1691658) for causing xpcshell failures in test_redirect_different-protocol_wrap.js. CLOSED TREE 2023-04-05 04:00:14 +03:00
third_party Bug 1826241 - Update AudioIPC to 0b51291d. r=glandium 2023-04-04 20:27:04 +00:00
toolkit Bug 1803363 - Applied some more small improvements evaluatRulesCountMax test coverage. r=robwu 2023-04-05 10:36:14 +00:00
tools Bug 1718171 - Add the clang runtime directory to LIB during configure. r=firefox-build-system-reviewers,andi 2023-04-05 00:16:52 +00:00
uriloader Bug 1825325 - Make uriloader/exthandler buildable outside of a unified build environment r=andi 2023-03-31 13:29:44 +00:00
view Bug 1824986 - Use element more in popup manager code. r=mstange 2023-03-28 14:33:19 +00:00
widget Bug 1825825 - Simplify NAC setup. r=smaug 2023-04-05 09:19:15 +00:00
xpcom Bug 1823757 implement PopoverInvokerElement::popoverTargetElement, r=emilio 2023-04-03 13:21:36 +00:00
xpfe/appshell Bug 1824514 - Make xpfe/appshell buildable outside of a unified build environment r=andi 2023-03-30 13:48:33 +00:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore
.cron.yml Bug 1825574 - Create a daily cron to run Chrome release tests against Speedometer 3 for android and desktop. r=perftest-reviewers,sparky 2023-04-01 19:51:29 +00:00
.eslintignore Bug 1825739 - Replace generic ESLint disable statements with specific and prettier ones in devtools. r=devtools-reviewers,nchevobbe 2023-04-03 10:23:52 +00:00
.eslintrc-test-paths.js Bug 1693495 - [devtools] Implement a beginning of "Network" commands, starting with sendHTTPRequest. r=devtools-reviewers,nchevobbe 2023-01-09 13:09:43 +00:00
.eslintrc.js Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu 2023-03-24 19:35:25 +00:00
.git-blame-ignore-revs
.gitattributes
.gitignore Bug 1810885 - Use ChromeMap for rewriting chrome:// URIs in Storybook r=hjones 2023-02-28 05:43:54 +00:00
.hg-annotate-ignore-revs
.hg-format-source
.hgignore Bug 1720941, part 1: build(ci): integrate WebGPU CTS into CI r=webgpu-reviewers,taskgraph-reviewers,jmaher,jimb 2023-03-22 14:03:50 +00:00
.hgtags No bug - tagging f2178beb09db4f3548827808718f1ea1f2892fc5 with FIREFOX_NIGHTLY_112_END a=release DONTBUILD CLOSED TREE 2023-03-13 15:37:10 +00:00
.lando.ini
.lldbinit
.mailmap
.prettierignore Bug 1825739 - Replace generic ESLint disable statements with specific and prettier ones for formautofill. r=credential-management-reviewers,dimi 2023-04-03 10:23:53 +00:00
.prettierrc.js Bug 1811820 - Change prettier config file from json to common js format. r=cmkm,Gijs 2023-01-24 22:53:55 +00:00
.taskcluster.yml
.trackerignore
.yamllint
.ycm_extra_conf.py
aclocal.m4
AUTHORS
build.gradle Bug 1822325 - Vendor Glean 52.4.2 r=janerik,supply-chain-reviewers 2023-03-20 17:52:38 +00:00
Cargo.lock Bug 1826241 - Update AudioIPC to 0b51291d. r=glandium 2023-04-04 20:27:04 +00:00
Cargo.toml Bug 1825480 - Update crossbeam-epoch to 0.9.14 and minidump-writer to current master. r=gsvelto,supply-chain-reviewers 2023-03-30 21:08:39 +00:00
client.mk
client.py
CLOBBER Bug 1824170: Reduce our opportunities for merge conflicts around pipewire build config. r=ng,webrtc-reviewers - moz.build file updates 2023-03-28 13:15:36 +00:00
configure
configure.py
GNUmakefile
gradle.properties
gradlew
gradlew.bat
LICENSE
mach Bug 1820915 - Attempt to re-launch Mach with a compatible python3 version if one is available r=firefox-build-system-reviewers,andi 2023-03-09 10:53:16 +00:00
mach.cmd
mach.ps1
Makefile.in
mots.yaml Bug 1826335 - Add kcochrane as a module peer for Fx View r=mkaply,zeid 2023-04-04 16:04:24 +00:00
moz.build Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre 2023-03-20 13:06:27 +00:00
moz.configure Bug 1823989 - Fix android jsshell builds. r=jandem,firefox-build-system-reviewers,nalexander 2023-03-28 00:44:41 +00:00
mozilla-config.h.in
old-configure.in Bug 1814802 - Move STLPORT_LIBS to moz.configure. r=firefox-build-system-reviewers,glandium 2023-02-14 02:29:22 +00:00
package-lock.json Bug 1801591 - Add eslint-plugin-eslint-plugin for linting our ESLint plugin rules, and upgrade most of node_modules. r=mossop 2023-02-03 13:28:13 +00:00
package.json Bug 1801591 - Add eslint-plugin-eslint-plugin for linting our ESLint plugin rules, and upgrade most of node_modules. r=mossop 2023-02-03 13:28:13 +00:00
pyproject.toml Bug 1823694 - [lint.ruff] Disable some warnings we don't actually want to enforce, r=linter-reviewers,andi 2023-03-21 14:36:26 +00:00
README.txt
settings.gradle
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.