mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-16 23:05:42 +00:00
1e75c0c5e1
The call that's causing the crash seems to be [1], that is, we're trying to recreate frames for the root element, which should always have a frame created at the initialization of the PresShell. So the function I removed in that bug had something like the following: if (!mDidInitialize) { // Nothing to do here. In fact, if we proceed and aContent is the // root we will crash. return NS_OK; } Which PostRecreateFramesFor doesn't guard against (because I thought it was not needed, per tryserver results). Sounds a lot like we do need that check, though I'd like to have a testcase where it happens :( [1]: http://searchfox.org/mozilla-central/rev/3dc6ceb42746ab40f1441e1e659ffb8f62ae78e3/layout/base/nsCSSFrameConstructor.cpp#2420 MozReview-Commit-ID: Lh6SohNmmI6 --HG-- extra : rebase_source : 5b7076f86d41f5489e47ca16ac2f3620812ee9e8 |
||
---|---|---|
.. | ||
base | ||
build | ||
doc | ||
forms | ||
generic | ||
inspector | ||
ipc | ||
mathml | ||
media | ||
painting | ||
printing | ||
reftests | ||
style | ||
svg | ||
tables | ||
tools | ||
xul | ||
moz.build |