gecko-dev/servo/etc/ci
Alan Jeffrey 208cea2587 servo: Merge #13472 - Don't log in the middle of mutating a reentrant lock (from asajeffrey:util-remutex-dont-log-while-mutating-lock); r=jdm
<!-- Please describe your changes on the following line: -->

Moved assertion that we are the lock owner to after the lock release. The problem is that Servo uses a reentrant lock for logging, so logging in the middle of mutating the lock is A Bad Idea.

While I was at it, I tidied up the reentrant lock code.

cc @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13463.
- [X] These changes do not require tests because they fix an existing intermittent.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 318b23ed0047cc39625ca2f33a55d647b5886019
2016-10-04 16:01:40 -05:00
..
fontconfig servo: Merge #3230 - Cargoify servo (from servo:cargoify) 2014-09-09 08:18:18 -06:00
performance servo: Merge #13248 - Added etc/ci/performance downloads to .gitignore (from asajeffrey:etc-ci-performance-gitignore); r=shinglyu 2016-09-26 06:03:55 -05:00
buildbot_steps.yml servo: Merge #12688 - brew package (from paulrouget:brew); r=larsbergstrom 2016-08-14 15:25:25 -05:00
chaos_monkey_test.py servo: Merge #10899 - Added /etc/ci/chaos_monkey_test.py (from asajeffrey:chaos-monkey-ci); r=aneeshusa 2016-04-29 16:01:45 -07:00
check_dynamic_symbols.py servo: Merge #10818 - Put each unexpected dynamic symbols on its own line (from askeing:fix_10797); r=nox 2016-04-26 02:24:02 -07:00
check_intermittents.sh servo: Merge #12629 - Intermittents (from notriddle:intermittents); r=aneeshusa 2016-08-09 23:28:17 -05:00
check_no_unwrap.sh servo: Merge #12295 - Add linting for shell scripts (from jimberlage:12158/shell-linting); r=aneeshusa 2016-08-04 12:31:17 -05:00
former_intermittents_css.txt servo: Merge #13472 - Don't log in the middle of mutating a reentrant lock (from asajeffrey:util-remutex-dont-log-while-mutating-lock); r=jdm 2016-10-04 16:01:40 -05:00
former_intermittents_wpt.txt servo: Merge #12800 - Enable canvas_over_area.html (closes #8311) (from nox:intermittent); r=jdm 2016-08-10 09:49:56 -05:00
lockfile_changed.sh servo: Merge #12736 - Add more shell script lints (from aneeshusa:prohibit-backticks-in-shell-scripts); r=Wafflespeanut 2016-08-06 21:57:31 -05:00
manifest_changed.sh servo: Merge #12736 - Add more shell script lints (from aneeshusa:prohibit-backticks-in-shell-scripts); r=Wafflespeanut 2016-08-06 21:57:31 -05:00
servo-binary-formula.rb.in servo: Merge #12688 - brew package (from paulrouget:brew); r=larsbergstrom 2016-08-14 15:25:25 -05:00
update_brew.sh servo: Merge #13507 - Don't leak GitHub tokens when pushing (from aneeshusa:avoid-leaking-github-tokens); r=SimonSapin 2016-10-04 08:59:11 -05:00
upload_docs.sh servo: Merge #13507 - Don't leak GitHub tokens when pushing (from aneeshusa:avoid-leaking-github-tokens); r=SimonSapin 2016-10-04 08:59:11 -05:00
upload_nightly.sh servo: Merge #12688 - brew package (from paulrouget:brew); r=larsbergstrom 2016-08-14 15:25:25 -05:00
xorg.conf servo: Merge #3230 - Cargoify servo (from servo:cargoify) 2014-09-09 08:18:18 -06:00