mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-25 03:49:42 +00:00
834d608a51
This patch doesn't change behavior; it's just collapsing logic from nsPrintJob's Initialize method (which is now de-facto infallible) into the constructor. I'm also removing the "Methods needed by the DocViewer" header-comment since it's clearly innacurate at this point. It's only surrounding this constructor and GetSeqFrameAndCountSheets, which is silly since nsDocumentViewer uses more of our API than that. (I also placed TODO(dholbert) comments for a few things that looked odd, to follow up on later. In particular, I noticed that nsDocumentViewer holds a dedicated stack-owned RefPtr reference to nsPrintJob after creating it, which superficially looks unnecessary. I don't want to risk changing behvior or introducing a crash by removing that reference in this refactoring patch, so I'm leaving that as-is and simply flagging it as suspicious.) Depends on D150194 Differential Revision: https://phabricator.services.mozilla.com/D150195