Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Drew Willcoxon 21d84a04fc Bug 1926381 - Integrate MLSuggest with UrlbarProviderQuickSuggest and implement Yelp ML suggestions. r=daisuke
This adds a new Suggest backend for ML-based suggestions called
`SuggestBackendMl`. Before, with the JS and Rust backends, only one backend was
enabled at a time, but both the ML and Rust backends can be enabled at the same
time since we will want to serve suggestions from both for the foreseeable
future. Features can support ML suggestions by implementing the new
`BaseFeature.mlIntent` getter and handling ML suggestions in `makeResult()`.
Each feature can decide whether it supports ML suggestions and whether they
should be preferred over Rust suggestions.

I've updated the Yelp feature to hook into this, since Yelp suggestions are
supported by the ML model that Chidam is working on. If ML is enabled, then the
feature will only serve ML suggestions. I'm not sure if that's what we want long
term, but for now that will make it clear to people which backend is being used
while we develop this feature.

The `quickSuggestMlEnabled` variable/pref determines whether the ML backend is
enabled. The `yelpMlEnabled` variable/pref determines whether Yelp ML
suggestions are enabled. We can create similar variable/prefs for each feature
that supports ML suggestions so that they can be toggled independently of each
other.

Other changes:

Move the `is_sponsored` logic out of the Rust backend and into the provider.
Otherwise it would need to be duplicated in the ML backend too.

Depends on D224523

Differential Revision: https://phabricator.services.mozilla.com/D226736
2024-10-24 09:52:00 +00:00
.cargo Bug 1926112 - Vendor application-services a0121f35125bd61ebd10fab969f6cfcc02f94d5a for city-based weather. r=bdk,nanj,supply-chain-reviewers 2024-10-22 03:45:18 +00:00
.github/workflows
.vscode
accessible Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
browser Bug 1926381 - Integrate MLSuggest with UrlbarProviderQuickSuggest and implement Yelp ML suggestions. r=daisuke 2024-10-24 09:52:00 +00:00
build Bug 1926473 - Consider x86_64-apple-ios as a simulator target. r=firefox-build-system-reviewers,sergesanspaille 2024-10-24 07:47:31 +00:00
caps Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
chrome Bug 1910698 - Remove nsIScriptError.sourceLine. r=smaug,devtools-reviewers,webdriver-reviewers,necko-reviewers,nchevobbe,kershaw,jdescottes,credential-management-reviewers,dimi 2024-08-01 17:12:48 +00:00
config Backed out 3 changesets (bug 1594368, bug 483318) for causing multiple failures. CLOSED TREE 2024-10-23 16:51:45 +03:00
devtools Bug 1926504 - [devtools] Update compatibility data for 133 cycle. r=devtools-reviewers,bomsy. 2024-10-24 06:35:32 +00:00
docs Bug 1926284 - Ride along: fix other fenix links r=android-reviewers,geckoview-reviewers,tthibaud,owlish DONTBUILD 2024-10-23 08:38:09 +00:00
docshell Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
dom Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
editor Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
extensions Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
gfx Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
gradle/wrapper Bug 1920624 - Update Gradle to version 8.10.2. r=android-reviewers,mcarare 2024-09-24 11:55:04 +00:00
hal Bug 1904957: Implement GetHeterogeneousCpuInfo on Windows and use for TaskController pool size. r=cmartin,smaug 2024-10-02 17:27:32 +00:00
image Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
intl Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
ipc Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
js Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
layout Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
media Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
memory Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
mfbt Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
mobile Bug 1926572 - Update the add-ons card primary button width r=android-reviewers,amejiamarmol 2024-10-24 09:37:12 +00:00
modules Bug 1113522 - Expose ServiceWorker in Workers. r=dom-worker-reviewers,webidl,edenchuang,emilio 2024-10-24 03:02:37 +00:00
mozglue Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
netwerk Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
nsprpub Bug 1920969 - Set NSPR version to 4.36 RTM. No code change. r=sylvestre UPGRADE_NSPR_RELEASE DONTBUILD 2024-10-23 16:06:56 +00:00
other-licenses Bug 1909747 - Fix liteFirewall mozilla_customizations.diff regarding error representation r=nrishel 2024-08-20 19:52:43 +00:00
parser Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
python Bug 1917685 - Merge minidump-analyzer into the crash reporter client r=gsvelto,fluent-reviewers 2024-10-23 13:58:12 +00:00
remote Bug 1926270 - [puppeteer] Fix setting of shard values for mach commands. r=webdriver-reviewers,Sasha 2024-10-22 16:00:31 +00:00
security Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
services Bug 1889988 - Added remote settings input to defaultUri bypass list r=necko-reviewers,valentin,nika,Standard8 2024-10-23 18:30:26 +00:00
servo Bug 1926269 - Changes to allow publishing selectors. r=supply-chain-reviewers 2024-10-23 19:54:49 +00:00
startupcache Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig 2024-10-22 09:38:16 +00:00
storage Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
supply-chain Bug 1926269 - Changes to allow publishing selectors. r=supply-chain-reviewers 2024-10-23 19:54:49 +00:00
taskcluster Bug 1925288 - Clean up webcodecs prefs in tests (performance and WPT). r=chunmin,aosmond,perftest-reviewers,sparky 2024-10-24 07:37:55 +00:00
testing Bug 1926482 - [wdspec] Remove flaky test for BiDi network events with cached images r=webdriver-reviewers,Sasha 2024-10-24 08:12:54 +00:00
third_party Bug 1926253 - Only enable fmt static assert for double conversion on recent clang. r=glandium 2024-10-24 07:37:51 +00:00
toolkit Bug 1926381 - Integrate MLSuggest with UrlbarProviderQuickSuggest and implement Yelp ML suggestions. r=daisuke 2024-10-24 09:52:00 +00:00
tools Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
uriloader Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
view Bug 1924240 - Devirtualize parent handling. r=mac-reviewers,win-reviewers,geckoview-reviewers,bradwerth,m_kato,rkraesig 2024-10-22 20:25:18 +00:00
widget Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
xpcom Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang 2024-10-24 09:06:01 +00:00
xpfe/appshell Backed out changeset 4b1409597101 (bug 1920718) for causing bp bustages on rapl.cpp. 2024-10-08 23:27:18 +03:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore Bug 1917739 - Move Lz4 and mfbt/Compression* to mozglue/static. r=nika,frontend-codestyle-reviewers 2024-09-10 20:35:56 +00:00
.cron.yml Bug 1919083 - Create 'os-integration' cron tasks to help validate worker image changes, r=jmaher,taskgraph-reviewers 2024-09-24 14:49:29 +00:00
.eslintrc-ignores.js Bug 1907841 - Change ESLint's .eslintignore to be an imported module. r=frontend-codestyle-reviewers,zeid,devtools-reviewers,nchevobbe 2024-07-16 12:53:09 +00:00
.eslintrc-rollouts.js Bug 1919853 - Make InspectorUtils able to return CSSNestedDeclarations too. r=devtools-reviewers,nchevobbe,dshin 2024-09-20 15:59:53 +00:00
.eslintrc-test-paths.js Bug 1924532 - Move tabMediaIndicator tests to browser/components/tabbrowser/. r=tabbrowser-reviewers,frontend-codestyle-reviewers,dwalker,mossop 2024-10-15 16:04:13 +00:00
.eslintrc.js Bug 1881696 - Rework the ESLint environment so that eslint-plugin-mozilla is not enforcing the environment everywhere. r=frontend-codestyle-reviewers,Gijs 2024-10-18 09:21:27 +00:00
.git-blame-ignore-revs
.gitattributes
.gitignore Bug 1743983 pt2 - Rewrite the minidump-analyzer in Rust r=gsvelto 2024-09-24 13:36:22 +00:00
.hg-annotate-ignore-revs
.hgignore Bug 1743983 pt2 - Rewrite the minidump-analyzer in Rust r=gsvelto 2024-09-24 13:36:22 +00:00
.hgtags No bug - tagging eaad836f0a492448489e0ffc73f261abda8b4b85 with FIREFOX_NIGHTLY_132_END a=release DONTBUILD CLOSED TREE 2024-09-30 13:32:45 +00:00
.lando.ini
.lldbinit
.mailmap No bug - Add some old committer emails to mailmap. DONTBUILD 2024-07-21 00:20:52 +00:00
.prettierignore Bug 652493 - Remove testing/mochitest/tests/MochiKit-1.4.2/ r=frontend-codestyle-reviewers,jmaher 2024-10-10 15:06:01 +00:00
.prettierrc.js
.rstcheck.cfg Bug 1917163 - Update rstcheck to 6.2.4, fix resulting errors in documents, r=Standard8 2024-09-06 15:04:10 +00:00
.stylelintignore
.stylelintrc.js Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer 2024-10-15 19:39:46 +00:00
.taskcluster.yml Bug 1923857 - retry decision tasks on try for worker-shutdown/claim-expired errors. r=releng-reviewers,bhearsum DONTBUILD 2024-10-10 13:32:22 +00:00
.trackerignore
.yamllint
.ycm_extra_conf.py
aclocal.m4 Bug 1907067 - Remove AC_PROG_CC, AC_PROG_CXX and MOZ_CROSS_COMPILER from old-configure r=glandium 2024-08-15 09:39:59 +00:00
AUTHORS
build.gradle Bug 1897176 - Allow unit tests to access and use app resources. r=tthibaud 2024-10-01 06:57:53 +00:00
Cargo.lock Bug 1926269 - Changes to allow publishing selectors. r=supply-chain-reviewers 2024-10-23 19:54:49 +00:00
Cargo.toml Bug 1917685 - Merge minidump-analyzer into the crash reporter client r=gsvelto,fluent-reviewers 2024-10-23 13:58:12 +00:00
client.mk
client.py
CLOBBER Bug 1921707 - libwebrtc - moz.build file updates r=ng,webrtc-reviewers 2024-10-10 13:42:45 +00:00
configure
configure.py Bug 1916786 - Modernize python/mozbuild/mozbuild to use exist_ok=True parameter from os.makedirs r=ahochheiden 2024-09-05 05:52:56 +00:00
GNUmakefile
gradle.properties
gradlew Bug 1900345 - Update Gradle to version 8.10. r=android-reviewers,ohall 2024-09-05 14:56:03 +00:00
gradlew.bat Bug 1900345 - Update Gradle to version 8.10. r=android-reviewers,ohall 2024-09-05 14:56:03 +00:00
LICENSE
mach
mach.cmd
mach.ps1
Makefile.in Bug 1821091 - Send Glean crash pings from the crashreporter r=gsvelto,glandium 2024-07-16 14:08:52 +00:00
mots.yaml Bug 1923813 - Make ahal the owner of Mozharness r=ahal,shtrom DONTBUILD 2024-10-18 13:28:27 +00:00
moz.build Bug 1923364 - Add topic guides for app-services, r=nanj,markh DONTBUILD 2024-10-09 23:24:17 +00:00
moz.configure Bug 1717448 - Vendor {fmt} in third_party. r=glandium 2024-10-21 12:54:52 +00:00
mozilla-config.h.in
old-configure.in Bug 1907180 - Remove obsolete AC_CANONICAL_SYSTEM from old-configure r=glandium 2024-08-29 07:42:33 +00:00
package-lock.json Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer 2024-10-15 19:39:46 +00:00
package.json Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer 2024-10-15 19:39:46 +00:00
pyproject.toml
README.txt
settings.gradle Bug 1894704 - Check if the gradle extension mozconfig property is set and only apply mozconfig.gradle when it is not available. r=gl,geckoview-reviewers,android-reviewers,ohall 2024-08-19 15:24:50 +00:00
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.