gecko-dev/layout/reftests/writing-mode
Emilio Cobos Álvarez 2afc706839 Bug 1487407 - Properly support beveling bc borders in WR. r=Gankro
The previous border-collapse beveling implementation assumed that there would
only be one beveled border per side in the whole table, which is... not true at all.

So a bunch of borders ended up clobbering other values in mBevelBorders and
never getting painted.

I'm actually somewhat scarily surprised that only this reftest seems to fail
without this patch...

Here we reuse most of the existing one-off beveling / border rendering support
in nsCSSRendering, and convert the Gecko bevels into a WebRender display list
using rects and borders. This is only remotely possible thanks to Gecko not
supporting dotted / dashed beveled borders :)

This would slightly easier and presumably also more efficient with a triangle
display item in WR instead of (ab)using the border display item to render the
bevel, but this is probably relatively edge-casey so maybe not worth it... In
any case I've left a TODO comment there, that can be a nice followup if we deem
it worth it.

Anyway, I'm _so_ sorry for the border trick, I was this (||) close to go and
rewrite our border collapsing code, but after a few tries I realized it'd take
me a whole lot of time (instead of the day that this has taken me).

Differential Revision: https://phabricator.services.mozilla.com/D4793
2018-09-26 15:27:59 +02:00
..
abspos Bug 1394603 - Replace fails-if(!styloVsGecko) to fails. r=jryans 2017-09-01 20:39:44 -07:00
tables Bug 1487407 - Properly support beveling bc borders in WR. r=Gankro 2018-09-26 15:27:59 +02:00
4colors.png
1079154-1-vertical-rl-columns-ref.html
1079154-1-vertical-rl-columns.html
1082844-ref.html
1082844.html
1083748-ref.html
1083748.html
1083848-1-inline-border-ref.html
1083848-1-inline-border.html
1083848-2-inline-background-ref.html
1083848-2-inline-background.html
1083848-3-inline-background-repeat-ref.html
1083848-3-inline-background-repeat.html
1083892-1-ref.html
1083892-1.html
1086883-1-ref.html
1086883-1a.html
1086883-1b.html
1088025-1-ref.html
1088025-1.html
1089388-1-ref.html Bug 1316770 - Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds. r=gbrown 2017-08-04 15:26:50 +01:00
1089388-1.html Bug 1316770 - Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds. r=gbrown 2017-08-04 15:26:50 +01:00
1089388-2-ref.html Bug 1316770 - Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds. r=gbrown 2017-08-04 15:26:50 +01:00
1089388-2.html Bug 1316770 - Add text-rendering:optimizeLegibility to reftests for bug 1089388, to try and ensure we get proper glyph bounds. r=gbrown 2017-08-04 15:26:50 +01:00
1090159-1-ref.html
1090159-1.html
1090168-1-notref.html
1090168-1-ref.html
1090168-1.html
1090168-2-ref.html
1090168-2.html
1090168-3-ref.html
1090168-3.html
1091058-1-ref.html
1091058-1.html
1094434-1-ref.html
1094434-1.html
1094434-2-ref.html
1094434-2.html
1094914-1-ref.html
1094914-1a.html
1094914-1b.html
1096224-1-ref.html
1096224-1a.html
1096224-1b.html
1102175-1-ref.html
1102175-1a.html
1102175-1b.html
1103613-1-ref.html
1103613-1.html
1105268-1-min-max-dimensions-ref.html
1105268-1-min-max-dimensions.html
1105268-2-min-max-dimensions-ref.html
1105268-2-min-max-dimensions.html
1106669-1-intrinsic-for-container-ref.html
1106669-1-intrinsic-for-container.html
1108923-1-percentage-margins-ref.html
1108923-1-percentage-margins.html
1111944-1-list-marker-ref.html
1111944-1-list-marker.html
1115916-1-vertical-metrics-ref.html
1115916-1-vertical-metrics.html
1117210-1-vertical-baseline-snap-ref.html
1117210-1-vertical-baseline-snap.html
1117227-1-text-overflow-ref.html
1117227-1-text-overflow.html
1122366-1-margin-collapse-ref.html
1122366-1-margin-collapse.html
1124636-1-fieldset-max-height-ref.html
1124636-1-fieldset-max-height.html
1124636-2-fieldset-min-height-ref.html
1124636-2-fieldset-min-height.html
1127488-align-bottom-left-ref.html
1127488-align-bottom-right-ref.html
1127488-align-default-horizontal-tb-ltr.html
1127488-align-default-horizontal-tb-rtl.html
1127488-align-default-vertical-lr-ltr.html
1127488-align-default-vertical-lr-rtl.html
1127488-align-default-vertical-rl-ltr.html
1127488-align-default-vertical-rl-rtl.html
1127488-align-end-horizontal-tb-ltr.html
1127488-align-end-horizontal-tb-rtl.html
1127488-align-end-vertical-lr-ltr.html
1127488-align-end-vertical-lr-rtl.html
1127488-align-end-vertical-rl-ltr.html
1127488-align-end-vertical-rl-rtl.html
1127488-align-left-horizontal-tb-ltr.html
1127488-align-left-horizontal-tb-rtl.html
1127488-align-left-vertical-lr-ltr.html
1127488-align-left-vertical-lr-rtl.html
1127488-align-left-vertical-rl-ltr.html
1127488-align-left-vertical-rl-rtl.html
1127488-align-right-horizontal-tb-ltr.html
1127488-align-right-horizontal-tb-rtl.html
1127488-align-right-vertical-lr-ltr.html
1127488-align-right-vertical-lr-rtl.html
1127488-align-right-vertical-rl-ltr.html
1127488-align-right-vertical-rl-rtl.html
1127488-align-start-horizontal-tb-ltr.html
1127488-align-start-horizontal-tb-rtl.html
1127488-align-start-vertical-lr-ltr.html
1127488-align-start-vertical-lr-rtl.html
1127488-align-start-vertical-rl-ltr.html
1127488-align-start-vertical-rl-rtl.html
1127488-align-top-left-ref.html
1127488-align-top-right-ref.html
1130907-intrinsic-sizing-1-ref.html
1130907-intrinsic-sizing-1.html
1130907-intrinsic-sizing-2-ref.html
1130907-intrinsic-sizing-2.html
1131013-vertical-bidi-ref.html
1131013-vertical-bidi.html
1133945-1-vertical-align-ref.html
1133945-1-vertical-align.html
1134744-radio-checkbox-baseline-1-ref.html
1134744-radio-checkbox-baseline-1.html
1134849-orthogonal-inline-ref.html
1134849-orthogonal-inline.html
1135361-ruby-justify-1-ref.html
1135361-ruby-justify-1.html
1136557-1-nested-spans-ref.html
1136557-1-nested-spans.html
1136557-2-nested-spans-ref.html
1136557-2-nested-spans.html
1136557-3-nested-spans-ref.html
1136557-3-nested-spans.html
1138356-1-button-contents-alignment-ref.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
1138356-1-button-contents-alignment.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
1138356-2-button-contents-alignment-notref.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
1138356-2-button-contents-alignment.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
1144501-1-block-end-margin-orthogonal-size-ref.html
1144501-1a-block-end-margin-orthogonal-size.html
1144501-1b-block-end-margin-orthogonal-size.html
1147834-bottom-left-ref.html
1147834-bottom-right-ref.html
1147834-relative-overconstrained-horizontal-tb-ltr.html
1147834-relative-overconstrained-horizontal-tb-rtl.html
1147834-relative-overconstrained-vertical-lr-ltr.html
1147834-relative-overconstrained-vertical-lr-rtl.html
1147834-relative-overconstrained-vertical-rl-ltr.html
1147834-relative-overconstrained-vertical-rl-rtl.html
1147834-top-left-ref.html
1147834-top-right-ref.html
1151993-1-orthogonal-block-size-ref.html
1151993-1-orthogonal-block-size.html
1152941-1-orthogonal-blocksize-overflow-ref.html
1152941-1-orthogonal-blocksize-overflow.html
1156021-text-indent-percent-ref.html
1156021-text-indent-percent.html
1157752-upright-bidi-ref.html
1157752-upright-bidi.html
1157758-1-vertical-arabic-ref.html
1157758-1-vertical-arabic.html
1158549-1-vertical-block-size-constraints-ref.html
1158549-1-vertical-block-size-constraints.html
1163238-orthogonal-auto-margins-ref.html
1163238-orthogonal-auto-margins.html
1174450-intrinsic-sizing-ref.html Bug 1434478 part 7 - Update tests and enable some previously temporarily disabled Grid reftests from bug 1427608. 2018-04-10 00:16:58 +02:00
1174450-intrinsic-sizing.html
1175789-underline-overline-1-ref.html
1175789-underline-overline-1.html
1188061-1-nsChangeHint_ClearAncestorIntrinsics-ref.html
1188061-1-nsChangeHint_ClearAncestorIntrinsics.html
1188061-2-nsChangeHint_UpdateComputedBSize-ref.html
1188061-2-nsChangeHint_UpdateComputedBSize.html
1193519-sideways-lr-1-ref.html
1193519-sideways-lr-1.html
1193519-sideways-lr-2-ref.html
1193519-sideways-lr-2.html
1193519-sideways-lr-3-ref.html
1193519-sideways-lr-3.html
1193519-sideways-lr-4-ref.html
1193519-sideways-lr-4.html
1193519-sideways-lr-decoration-1-ref.html
1193519-sideways-lr-decoration-1.html
1196887-1-computed-display-inline-block-ref.html
1196887-1-computed-display-inline-block.html
1205787-legacy-svg-values-1-ref.html
1205787-legacy-svg-values-1.html
1216747-1-notref.html
1216747-1-ref.html
1216747-1.html
1243125-1-floats-overflowing-ref.html
1243125-1-floats-overflowing.html
1248248-1-orientation-break-glyphrun-ref.html
1248248-1-orientation-break-glyphrun.html
1302389-scrolled-rect-1-ref.html
1302389-scrolled-rect-1a.html
1302389-scrolled-rect-1b.html
1302389-scrolled-rect-1c.html
1302389-scrolled-rect-1d.html
1302389-scrolled-rect-2-ref.html
1302389-scrolled-rect-2a.html
1302389-scrolled-rect-2b.html
1302389-scrolled-rect-2c.html
1302389-scrolled-rect-2d.html
1302734-bidi-plaintext-1-ref.html
1302734-bidi-plaintext-1a.html
1302734-bidi-plaintext-1b.html
1302734-bidi-plaintext-2-ref.html
1302734-bidi-plaintext-2a.html
1302734-bidi-plaintext-2b.html
1302734-bidi-plaintext-2c.html
1302734-bidi-plaintext-2d.html
1361631-mongolian-upright-1-ref.html Bug 1361631 - Reftest for vertical Mongolian with text-orientation:upright. r=xidorn 2017-10-20 11:20:18 +01:00
1361631-mongolian-upright-1.html Bug 1361631 - Reftest for vertical Mongolian with text-orientation:upright. r=xidorn 2017-10-20 11:20:18 +01:00
1395926-vertical-upright-gpos-1-ref.html Bug 1395926 - Reftest for GPOS glyph positioning adjustments in vertical-upright mode. r=jrmuizel 2017-10-27 18:57:17 +01:00
1395926-vertical-upright-gpos-1.html Bug 1395926 - Reftest for GPOS glyph positioning adjustments in vertical-upright mode. r=jrmuizel 2017-10-27 18:57:17 +01:00
blue-32x32.png
font-inflation-1-ref.html
font-inflation-1a.html
font-inflation-1b.html
font-inflation-1c-ref.html
font-inflation-1c.html
font-inflation-1d-ref.html
font-inflation-1d.html
green-100x100.png
left-bottom-300x300.png
left-top-300x300.png
reftest.list Bug 1392106 - Annotate more failing tests as random on Win7. r=jmaher 2018-09-10 15:30:44 -04:00
right-bottom-300x300.png
right-top-300x300.png
swatch-yellow.png
ua-style-sheet-border-1-ref.html
ua-style-sheet-border-1.html
ua-style-sheet-border-2-ref.html
ua-style-sheet-border-2.html
ua-style-sheet-border-3-ref.html
ua-style-sheet-border-3.html
ua-style-sheet-border-4-ref.html
ua-style-sheet-border-4.html
ua-style-sheet-border-5-ref.html
ua-style-sheet-border-5.html
ua-style-sheet-button-1.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
ua-style-sheet-button-1a-ref.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
ua-style-sheet-button-1b-ref.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
ua-style-sheet-checkbox-radio-1-ref.html
ua-style-sheet-checkbox-radio-1.html
ua-style-sheet-fieldset-1-ref.html Bug 1483527: Change fieldset block-end & inline-axis padding to match other browsers. r=emilio 2018-08-16 18:26:39 +00:00
ua-style-sheet-fieldset-1.html
ua-style-sheet-input-color-1-ref.html Bug 1406631: Remove the color-picker-available system metric. r=xidorn 2017-10-07 14:06:44 +02:00
ua-style-sheet-input-color-1.html Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
ua-style-sheet-input-number-1-ref.html Bug 1333482 part 5 - [css-ui] Enable '-moz-appearance' support for some tests. r=dholbert 2017-03-23 22:11:23 -07:00
ua-style-sheet-input-number-1.html Bug 1333482 part 5 - [css-ui] Enable '-moz-appearance' support for some tests. r=dholbert 2017-03-23 22:11:23 -07:00
ua-style-sheet-margin-1-ref.html
ua-style-sheet-margin-1.html
ua-style-sheet-margin-2-ref.html
ua-style-sheet-margin-2.html
ua-style-sheet-margin-3-ref.html
ua-style-sheet-margin-3.html
ua-style-sheet-margin-4-ref.html
ua-style-sheet-margin-4.html
ua-style-sheet-margin-5-ref.html
ua-style-sheet-margin-5.html
ua-style-sheet-margin-6-ref.html
ua-style-sheet-margin-6.html
ua-style-sheet-margin-7-ref.html
ua-style-sheet-margin-7.html
ua-style-sheet-margin-8-ref.html
ua-style-sheet-margin-8.html
ua-style-sheet-margin-9-ref.html
ua-style-sheet-margin-9.html
ua-style-sheet-margin-10-ref.html
ua-style-sheet-margin-10.html
ua-style-sheet-margin-11-ref.html
ua-style-sheet-margin-11.html
ua-style-sheet-margin-12-ref.html
ua-style-sheet-margin-12.html
ua-style-sheet-margin-13-ref.html
ua-style-sheet-margin-13.html
ua-style-sheet-margin-14-ref.html
ua-style-sheet-margin-14.html
ua-style-sheet-size-1-ref.html
ua-style-sheet-size-1.html
ua-style-sheet-size-2-ref.html
ua-style-sheet-size-2.html
ua-style-sheet-textarea-1.html
ua-style-sheet-textarea-1a-ref.html
ua-style-sheet-textarea-1b-ref.html
ua-style-sheet-textarea-1c-ref.html