Emilio Cobos Álvarez 2a20517cff Bug 1646330 - Downgrade an assertion to a regular MOZ_ASSERT. r=jwatt
My two guesses about how this can happen are:

 * PR_Now() is not guaranteed to be monotonic. We can hit an expired
   entry and in-flight become "unexpired".

 * nsLoadGroup flags being mutated mid-load (by stuff like devtools).

I tried to reproduce this in both ways but I couldn't, but it doesn't
seem far-fetched.

In any case this failing this assert is not a correctness issue (this
branch is intended to catch cases where we do too much work, but the
consequence of it being violated is just we have performed an extra
load), so let's not crash nightly / early-beta users as we don't have
any way to reproduce it.

Differential Revision: https://phabricator.services.mozilla.com/D92443
2020-10-06 08:31:47 +00:00
..