gecko-dev/widget/cocoa
Masayuki Nakano 6ca17cf78c Bug 1309515 part.2 TextInputHandler::InsertText() should consume current key event when it dispatches composition events r=m_kato
The cause of bug 1309515 is, HandleKeyDownEvent() dispatches eKeyPress events even after InsertText() dispatches composition events via InsertTextAsCommittingComposition().

Therefore, this patch consumes the current key event after dispatching composition events.

Note that for consistency with Windows, InsertText() should use eKeyPress events rather than composition events at least in this case.  However, changing the behavior has some risk.  So, we should fix this bug with the safest hack for uplift.

MozReview-Commit-ID: 7FYR5N2lATe

--HG--
extra : rebase_source : 4485bd76a68567e8c20a84c2fbca78c626f592c5
2016-10-13 13:18:58 +09:00
..
crashtests
cursors
resources/MainMenu.nib
ComplexTextInputPanel.h
ComplexTextInputPanel.mm Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
CustomCocoaEvents.h
GfxInfo.h Bug 1263249 - Bubble up unique failureId in GetFeatureStatus. r=mconley,milan 2016-04-13 17:12:47 -04:00
GfxInfo.mm Bug 1284341: Add utility functions to recognize OS X 10.12. r=mstange 2016-07-04 17:25:25 -04:00
moz.build Bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop 2016-10-08 11:14:49 +02:00
mozView.h
NativeKeyBindings.h
NativeKeyBindings.mm
nsAppShell.h
nsAppShell.mm Bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop 2016-10-08 11:14:49 +02:00
nsBidiKeyboard.h
nsBidiKeyboard.mm
nsChangeObserver.h
nsChildView.h Bug 1299860 - Don't use the compositor backend of a popup with ImageBridge and VRManager. r=Bas 2016-10-07 11:08:32 +02:00
nsChildView.mm Bug 1304829 - rename RELEASE_BUILD to RELEASE_OR_BETA: main part. r=ted,Mossop 2016-10-08 11:14:49 +02:00
nsClipboard.h Bug 1261299 - Implement nsIClipboard methods in nsClipboard.mm with methods specific for osx. (EmptyClipboard, SetData) methods modified from nsBaseClipboard to also set the current selection cache. r=jimm 2016-08-11 16:43:32 -04:00
nsClipboard.mm Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 2016-08-24 14:47:04 +08:00
nsCocoaDebugUtils.h
nsCocoaDebugUtils.mm
nsCocoaFeatures.h Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsCocoaFeatures.mm Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsCocoaUtils.h Bug 1279017 - Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange. 2016-06-10 23:30:25 +02:00
nsCocoaUtils.mm Bug 1284837 - Disallow implicit conversions from float to integer when creating IntPoint and IntSize objects. r=botond 2016-07-26 16:48:30 +02:00
nsCocoaWindow.h Bug 1260850: Ensure that FilePicker (and other native app modal dialogs) on OSX remains responsive when a window modal dialog opens in the background. r=mstange 2016-09-08 15:41:55 -04:00
nsCocoaWindow.mm Bug 1299860 - Don't use the compositor backend of a popup with ImageBridge and VRManager. r=Bas 2016-10-07 11:08:32 +02:00
nsColorPicker.h
nsColorPicker.mm Bug 1293593: Fix crash due to an Objective-C exception when calling getRed:green:blue:alpha on an NSColor instance with an incompatible NSColorSpace. r=mstange 2016-08-19 23:17:58 -04:00
nsCursorManager.h
nsCursorManager.mm
nsDeviceContextSpecX.h Bug 1278269 - Make a PrintTarget class and PrintTargetThebes subclass and convert all nsIDeviceContextSpec subclasses to use them. r=Bas 2016-06-03 11:27:31 +01:00
nsDeviceContextSpecX.mm Bug 1284837 - Disallow implicit conversions from float to integer when creating IntPoint and IntSize objects. r=botond 2016-07-26 16:48:30 +02:00
nsDragService.h Bug 860857, support custom datatransfer types using a special type, r=smaug,jmathies,mstange 2016-04-21 14:11:14 -04:00
nsDragService.mm Bug 1271867 - Update our usage of NSWindow::convertBaseToScreen/convertScreenToBase to modern ApplicationKit API. r=mstange 2016-05-05 12:27:13 +01:00
nsFilePicker.h
nsFilePicker.mm Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm 2016-08-24 02:07:21 +03:00
nsIdleServiceX.h
nsIdleServiceX.mm
nsLookAndFeel.h Bug 1280119 - Remove obsolete scrollbar constants in nsLookAndFeel.h. r=mstange. 2016-06-14 23:02:58 +02:00
nsLookAndFeel.mm Bug 1308479, use [NSApp isFullKeyboardAccessEnabled] to get keyboard access state, r=mstange 2016-10-11 14:13:36 -04:00
nsMacCursor.h
nsMacCursor.mm
nsMacDockSupport.h
nsMacDockSupport.mm Bug 1262110 - Null out nsIMacDockSupport.dockMenu on shutdown. r=smaug. 2016-04-05 16:46:43 +02:00
nsMacWebAppUtils.h
nsMacWebAppUtils.mm
nsMenuBarX.h Bug 1265953, part 3 - Convert more widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 23:29:16 +01:00
nsMenuBarX.mm Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuBaseX.h
nsMenuGroupOwnerX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuGroupOwnerX.mm
nsMenuItemIconX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuItemIconX.mm Bug 1256999 - Pass the right context to new channels for image loads. r=bz r=seth 2016-04-11 10:58:03 +02:00
nsMenuItemX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuItemX.mm Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuUtilsX.h
nsMenuUtilsX.mm
nsMenuX.h Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuX.mm Bug 1018486 - Part 3: Changes in widget/cocoa/, r=mstange 2016-09-07 10:50:38 -04:00
nsNativeThemeCocoa.h Bug 1294102 - Use the original height that is not affected by the top to decide the button style on OSX. r=mstange 2016-08-13 15:34:57 +09:00
nsNativeThemeCocoa.mm Bug 1100401 - Keep the default button's background appearance in sync with the text color. r=spohl 2016-09-02 14:02:49 -04:00
nsNativeThemeColors.h Bug 1279017 - Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange. 2016-06-10 23:30:25 +02:00
nsPIWidgetCocoa.idl Bug 1294553 - Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl, r=mstange 2016-08-11 17:56:10 -04:00
nsPrintDialogX.h Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj. 2016-08-08 10:54:47 +10:00
nsPrintDialogX.mm Bug 1271453 - Replace deprecated NSOKButton with correct constant NSFileHandlingPanelOKButton. r=mstange 2016-05-09 23:45:45 +02:00
nsPrintOptionsX.h
nsPrintOptionsX.mm
nsPrintSettingsX.h
nsPrintSettingsX.mm
nsSandboxViolationSink.h
nsSandboxViolationSink.mm Bug 1302163 - Change code to use SprintfLiteral instead of snprintf. r=ehsan 2016-10-04 17:57:51 +02:00
nsScreenCocoa.h
nsScreenCocoa.mm Bug 1281686 - Part 1: Fix OSX Compile failure due to unified build. r=mstange 2016-06-29 11:24:43 +08:00
nsScreenManagerCocoa.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsScreenManagerCocoa.mm
nsSound.h
nsSound.mm
nsStandaloneNativeMenu.h
nsStandaloneNativeMenu.mm
nsSystemStatusBarCocoa.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsSystemStatusBarCocoa.mm
nsToolkit.h Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsToolkit.mm
nsWidgetFactory.mm Initialize nsAppShell in the GPU process. (bug 1294350 part 5, r=nfroyd) 2016-08-22 22:57:36 -07:00
nsWindowMap.h
nsWindowMap.mm
OSXNotificationCenter.h Bug 1233086, Part 3 - Use unified image loading for OS X alerts. r=mstange 2016-06-10 18:59:25 -07:00
OSXNotificationCenter.mm Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
RectTextureImage.h Bug 1281686 - Part 3: Using MacIOSurface for RectTextureImage. r=mstange 2016-06-29 11:24:44 +08:00
RectTextureImage.mm Bug 1281686 - Part 3: Using MacIOSurface for RectTextureImage. r=mstange 2016-06-29 11:24:44 +08:00
SwipeTracker.h
SwipeTracker.mm Bug 1259667 - part5: rename WidgetSimpleGestureEvent.delta to mDelta. r=masayuki 2016-05-10 04:16:55 +09:00
TextInputHandler.h Bug 1266369 - Don't define kVK_RightCommand when building against the macOS 10.12 SDK. r=masayuki 2016-07-09 12:57:01 -04:00
TextInputHandler.mm Bug 1309515 part.2 TextInputHandler::InsertText() should consume current key event when it dispatches composition events r=m_kato 2016-10-13 13:18:58 +09:00
VibrancyManager.h Bug 1297879 - Don't allow the cocoa GL context to be opaque if we vibrant regions within the window. r=mstange 2016-09-07 15:35:03 +12:00
VibrancyManager.mm Bug 1297879 - Don't allow the cocoa GL context to be opaque if we vibrant regions within the window. r=mstange 2016-09-07 15:35:03 +12:00
ViewRegion.h Bug 1070710 - Add mozilla::ViewRegion which assembles a LayoutDeviceIntRegion as NSViews. r=spohl 2016-07-16 17:07:45 -04:00
ViewRegion.mm Bug 1070710 - Add mozilla::ViewRegion which assembles a LayoutDeviceIntRegion as NSViews. r=spohl 2016-07-16 17:07:45 -04:00
WidgetTraceEvent.mm