gecko-dev/mozglue/misc/PlatformMutex.h
Nathan Froyd 8828af4759 Bug 1336344 - use sizeof(pthread_mutex_t) to size MutexImpl's platformData_; r=fitzgen
For pthreads platforms, we have a terribly large condition for the size
of a MutexImpl that attempts to hardcode the number of words that
pthread_mutex_t takes.  This hardcoding isn't always correct.  We
originally did this to try and keep <pthread.h> includes out of the
headers, but the PlatformConditionVariable.h header already includes
<pthread.h> anyway, and <pthread.h> isn't so namespace-invasive as
<windows.h>.  So go ahead and include <pthread.h> and use the actual
definition of pthread_mutex_t to size the platformData_ member.
2017-02-22 16:41:35 -05:00

64 lines
1.5 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_PlatformMutex_h
#define mozilla_PlatformMutex_h
#include "mozilla/Attributes.h"
#include "mozilla/Move.h"
#if !defined(XP_WIN)
# include <pthread.h>
#endif
namespace mozilla {
namespace detail {
class ConditionVariableImpl;
class MutexImpl
{
public:
struct PlatformData;
MFBT_API MutexImpl();
MFBT_API ~MutexImpl();
bool operator==(const MutexImpl& rhs) {
return platformData_ == rhs.platformData_;
}
protected:
MFBT_API void lock();
MFBT_API void unlock();
private:
MutexImpl(const MutexImpl&) = delete;
void operator=(const MutexImpl&) = delete;
MutexImpl(MutexImpl&&) = delete;
void operator=(MutexImpl&&) = delete;
PlatformData* platformData();
#if !defined(XP_WIN)
void* platformData_[sizeof(pthread_mutex_t) / sizeof(void*)];
static_assert(sizeof(pthread_mutex_t) / sizeof(void*) != 0 &&
sizeof(pthread_mutex_t) % sizeof(void*) == 0,
"pthread_mutex_t must have pointer alignment");
#else
void* platformData_[6];
#endif
friend class mozilla::detail::ConditionVariableImpl;
};
} // namespace detail
} // namespace mozilla
#endif // mozilla_PlatformMutex_h