mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 01:05:45 +00:00
28243d5736
In Bug 1622749 a user preference for where to open new documents (from a service worker notification) was temporarily overriden in order to quickly fix a crash that was happening in mozilla::dom::ClientOpenWindow. The crash was ocurring when the pref "browser.link.open_newwindow" was set to 2, meaning new documents are opened in a new window, instead of a new tab. The reason the browser crashed is because the path for opening a new document is different depending on the current user setting, and in NEWWINDOW case we did not get a browsing context returned when calling mozilla::dom::OpenWindow which resulted in a failed assertion. The solution is to pass in a callback to mozilla::dom::OpenWindow as part of nsOpenWindowInfo object, and invoke that callback with a corresponding BrowsingContext in nsFrameLoader when that browsing context is ready. After we call mozilla::dom::OpenWindow, we wait on a promise, that will be resolved when the callback is invoked, before executing the rest of the code that depends on the browsing context for a newly opened document being available. Differential Revision: https://phabricator.services.mozilla.com/D72745 |
||
|---|---|---|
| .. | ||
| actors | ||
| annotations | ||
| app | ||
| base | ||
| branding | ||
| chrome | ||
| components | ||
| config | ||
| docs | ||
| examples | ||
| fonts | ||
| geckoview | ||
| geckoview_example | ||
| gradle | ||
| installer | ||
| locales | ||
| modules | ||
| themes | ||
| .eslintrc.js | ||
| app.mozbuild | ||
| build.mk | ||
| confvars.sh | ||
| debug_sign_tool.py | ||
| gradle.configure | ||
| gradle.py | ||
| LICENSE | ||
| mach_commands.py | ||
| moz.build | ||
| moz.configure | ||