gecko-dev/netwerk/base/nsBase64Encoder.cpp
Nathan Froyd a51fed2b98 Bug 1439362 - make nsBase64Encoder slightly less malloc-happy; r=valentin
nsBase64Encoder::Finish currently works by calling PL_Base64Encode to
allocate a base64-encoded string, then Assign()'ing that to the result
string, another allocation.  mozilla::Base64Encode enables us to base64
encode directly into the result string with a single allocation, saving
an allocation.  (Base64Encode is also slightly more efficient, because
we don't have to do a strlen() on the string being Assign()'d.)  Let's
use Base64Encode instead.
2018-02-19 10:28:00 -05:00

66 lines
1.3 KiB
C++

/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "nsBase64Encoder.h"
#include "mozilla/Base64.h"
NS_IMPL_ISUPPORTS(nsBase64Encoder, nsIOutputStream)
NS_IMETHODIMP
nsBase64Encoder::Close()
{
return NS_OK;
}
NS_IMETHODIMP
nsBase64Encoder::Flush()
{
return NS_OK;
}
NS_IMETHODIMP
nsBase64Encoder::Write(const char* aBuf, uint32_t aCount, uint32_t* _retval)
{
mData.Append(aBuf, aCount);
*_retval = aCount;
return NS_OK;
}
NS_IMETHODIMP
nsBase64Encoder::WriteFrom(nsIInputStream* aStream, uint32_t aCount,
uint32_t* _retval)
{
return NS_ERROR_NOT_IMPLEMENTED;
}
NS_IMETHODIMP
nsBase64Encoder::WriteSegments(nsReadSegmentFun aReader,
void* aClosure,
uint32_t aCount,
uint32_t* _retval)
{
return NS_ERROR_NOT_IMPLEMENTED;
}
NS_IMETHODIMP
nsBase64Encoder::IsNonBlocking(bool* aNonBlocking)
{
*aNonBlocking = false;
return NS_OK;
}
nsresult
nsBase64Encoder::Finish(nsACString& result)
{
nsresult rv = mozilla::Base64Encode(mData, result);
if (NS_FAILED(rv)) {
return rv;
}
// Free unneeded memory and allow reusing the object
mData.Truncate();
return NS_OK;
}