mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-28 15:23:51 +00:00
Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
2c3173600a
This patch implements struct.{new,set,get} and ref.cast for Ion. The
implementation is in principle straightforward and is derived from the
baseline equivalents. There are however many pieces that need to be
coordinated. Changes:
* Compiler gating logic -- enable Ion for wasm GC extensions.
* Pertaining to the above, extend the guard conditions in many of the wasm/gc
test cases so as to limit them to baseline only, for now, so that we don't
get failures as a result of gc insns that are currently unimplemented in
Ion. This will need to be incrementally undone as more gc insns get
implemented in Ion.
* Pertaining to testing (lib/wasm-binary.js), remove wasm gc opcodes from the
lists of opcodes that we check are unimplemented.
* New test file wasm/gc/structs2.js, that tests 8- and 16-bit field accesses,
since the existing structs.js file doesn't.
* Add support to MIR and LIR to handle 8- and 16-bit memory accesses. One
possibility would have been to add MIRType::Int16 and MIRType::Int8, but I
didn't want to destabilise the existing, probably carefully-balanced MIR
optimisation machinery for JS. So I chose to add auxiliary descriptors just
for the 4 relevant MIR/LIR nodes instead:
- New enums MNarrowingOp and MWideningOp, to describe how to narrow to /
widen from Int32.
- Renamed wasm::FieldExtension to wasm::FieldWideningOp for consistency with
the above. Note MWideningOp and wasm::FieldWideningOp both need to exist;
neither can exactly do the job of the other.
- LIRGenerator::visitWasmLoadObjectField/LoadObjectFieldWithKA
/StoreObjectFieldWithKA: handle 8- and 16-bit accesses.
WasmStoreObjectRefFieldWithKA is unaffected since a ref can't be 8- or
16-bits long.
- CodeGenerator::visitWasm{Store,Load}Slot: handle 8- and 16-bit accesses.
* The actual implementations of struct.{new,set,get} and ref.cast, which are
pretty straightforward. They use the following new helper functions inside
class FunctionCompiler:
- FunctionCompiler::loadGcCanon, same function as the baseline version
- FunctionCompiler::writeValueToStructField, used for both struct.new
and struct.set.
- FunctionCompiler::readValueFromStructField, used for struct.get.
- FunctionCompiler::trapIfZero, used for ref.cast.
- FunctionCompiler::refCast, used for ref.cast.
- FunctionCompiler::field{Load,Store}InfoToMIR, used to create the right MIR
descriptions for 8- and 16-bit transactions.
It is envisaged that these helpers will be further refined in subsequent
patches to support accesses for the array instructions.
* Ridealong fix: FunctionCompiler::loadExceptionValues: add missing OOM check
for `auto* data = ..`.
Differential Revision: https://phabricator.services.mozilla.com/D161253
|
||
|---|---|---|
| .cargo | ||
| .vscode | ||
| accessible | ||
| browser | ||
| build | ||
| caps | ||
| chrome | ||
| config | ||
| devtools | ||
| docs | ||
| docshell | ||
| dom | ||
| editor | ||
| extensions | ||
| gfx | ||
| gradle/wrapper | ||
| hal | ||
| image | ||
| intl | ||
| ipc | ||
| js | ||
| layout | ||
| media | ||
| memory | ||
| mfbt | ||
| mobile | ||
| modules | ||
| mozglue | ||
| netwerk | ||
| nsprpub | ||
| other-licenses | ||
| parser | ||
| python | ||
| remote | ||
| security | ||
| services | ||
| servo | ||
| startupcache | ||
| storage | ||
| supply-chain | ||
| taskcluster | ||
| testing | ||
| third_party | ||
| toolkit | ||
| tools | ||
| uriloader | ||
| view | ||
| widget | ||
| xpcom | ||
| xpfe/appshell | ||
| .arcconfig | ||
| .babel-eslint.rc.js | ||
| .clang-format | ||
| .clang-format-ignore | ||
| .cron.yml | ||
| .eslintignore | ||
| .eslintrc-test-paths.js | ||
| .eslintrc.js | ||
| .flake8 | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .hg-annotate-ignore-revs | ||
| .hg-format-source | ||
| .hgignore | ||
| .hgtags | ||
| .isort.cfg | ||
| .lando.ini | ||
| .lldbinit | ||
| .mailmap | ||
| .prettierignore | ||
| .prettierrc | ||
| .taskcluster.yml | ||
| .trackerignore | ||
| .yamllint | ||
| .ycm_extra_conf.py | ||
| aclocal.m4 | ||
| AUTHORS | ||
| build.gradle | ||
| Cargo.lock | ||
| Cargo.toml | ||
| client.mk | ||
| client.py | ||
| CLOBBER | ||
| configure | ||
| configure.py | ||
| GNUmakefile | ||
| gradle.properties | ||
| gradlew | ||
| gradlew.bat | ||
| LICENSE | ||
| mach | ||
| mach.cmd | ||
| mach.ps1 | ||
| Makefile.in | ||
| mots.yaml | ||
| moz.build | ||
| moz.configure | ||
| mozilla-config.h.in | ||
| old-configure.in | ||
| package-lock.json | ||
| package.json | ||
| README.txt | ||
| settings.gradle | ||
| substitute-local-geckoview.gradle | ||
| test.mozbuild | ||
An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:
https://firefox-source-docs.mozilla.org/contributing/directory_structure.html
For information on how to build Firefox from the source code and create the patch see:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.
Nightly development builds can be downloaded from:
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
- or -
https://www.mozilla.org/firefox/channel/desktop/#nightly
Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.