Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 00:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
2cabfdfe65
gecko-dev/dom
History
Timothy Nikkel 2cabfdfe65 Bug 1671331. Create a new test-only pref that disables the zoom part of ZoomToFocusedInput and use it in layout/base/tests/ mochitests. r=botond 
layout/base/tests/test_bug332655-1.html calls focus on an element, this triggers a call to zoomToFocusedInput. This can zoom the parent document of the test, the mochitest harness.

Then test layout/base/tests/test_bug667512.html runs. It ends by synthesizing a left arrow key and then a right arrow key. With the old scrollbar code this results in no scrolling because there is no layout scrolling that can be done either in the test or the parent document. With the new scrollbar code we can scroll the visual viewport using the keyboard so this scrolls the visual viewport of the test harness (because it got zoomed from a previous test).

The test harness being scrolled means that the synthesized click in the next test test_bug677878 can not hit its intended target.

Using the pref apz.zoom-to-focused-input.enabled to disable zoom to focused input in this directory does work to fix this, but I'm tired of doing that.

I think the proper fix here would be to disable scrolling/zooming of the test harness document. Since it's the root content document and it is not scrollable if not zoomed this is equivalent to disabling the zooming part of zoom to focused input (except for tests that open their own window). To test the zooming part of zoom to focused input we can use a test that opens it's own window: we have gfx/layers/apz/test/mochitest/test_group_zoomToFocusedInput.html for this.

We already have the pref formhelper.autozoom would seems like it would work for this purpose, except it is entangled with java stuff in mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java that I don't really understand that means setting the pref in mochitest.ini doesn't seem to take affect.

So I created a new pref we can use specifically for this purpose. Hopefully we can use it instead of fully disabling the zoom to focused input, so we more closely test what we ship.

Differential Revision: https://phabricator.services.mozilla.com/D95423
2020-10-30 23:32:09 +00:00
..
abort Bug 1660555 - Move traverse/unlink operations on |AbortFollower| and |AbortSignalImpl| into static member functions. r=smaug 2020-10-29 08:02:58 +00:00
animation Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
audiochannel Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
base Bug 1671331. Create a new test-only pref that disables the zoom part of ZoomToFocusedInput and use it in layout/base/tests/ mochitests. r=botond 2020-10-30 23:32:09 +00:00
battery Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
bindings Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
broadcastchannel Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
browser-element Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
cache Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
canvas Bug 1631476 - Don't let CanvasRenderingContext2D::EnsureTarget lead to frame capture. r=nical 2020-10-19 20:26:55 +00:00
chrome-webidl Bug 1662771, remove willDestroy callback from JSActors, r=nika 2020-10-29 14:24:43 +00:00
clients Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
commandhandler Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
console Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
credentialmanagement Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
crypto Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
debugger Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
docs Bug 1662771, remove willDestroy callback from JSActors, r=nika 2020-10-29 14:24:43 +00:00
encoding Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
events Bug 1671657 - setPointerCapture should do nothing if the element's node document is not active document for the pointer; r=smaug 2020-10-30 08:31:42 +00:00
fetch Bug 1660555 - Move the runnable into |WorkerSignalFollower|. r=smaug 2020-10-30 20:17:21 +00:00
file Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
filehandle Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
filesystem Bug 1671641 - Make dom/filesystem buildable outside of unified-build environment. r=sg 2020-10-27 10:01:12 +00:00
flex Bug 1671641 - Make dom/flex buildable outside of unified-build environment. r=sg 2020-10-28 09:28:50 +00:00
gamepad Bug 1671641 - Make dom/gamepad buildable outside of unified-build environment. r=sg 2020-10-28 12:29:56 +00:00
geolocation Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
grid Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
html Bug 1671641 - Make dom/html buildable outside of unified-build environment. r=sg 2020-10-28 12:24:01 +00:00
imptests
indexedDB Bug 1673917 - Rename vprintf style nsTSubstring::AppendPrintf -> AppendVprintf. r=sg 2020-10-29 14:51:45 +00:00
interfaces Bug 1674078 - Remove nsIBrowserDOMWindow.OPEN_SWITCHTAB. r=edgar 2020-10-29 10:59:24 +00:00
ipc Bug 1671962 - Iframes loaded from restored session are loaded out of order when Fission enabled, r=peterv 2020-10-30 22:10:15 +00:00
jsurl Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
l10n Bug 1671641 - Make dom/l10n buildable outside of unified-build environment. r=sg 2020-10-28 12:49:46 +00:00
locales Bug 933562 - Implement complex :not(). r=jfkthame 2020-10-29 18:03:54 +00:00
localstorage Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
manifest Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
mathml Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
media Bug 1674463 - allow HD simulcast stream to start a bit earlier. r=ng 2020-10-30 21:44:54 +00:00
messagechannel Bug 1626555 - Add dom/messagechannel to the list of non-unified-build-compatible directories. r=sg 2020-10-29 14:15:23 +00:00
midi Bug 1626555 - Add dom/midi to the list of non-unified-build-compatible directories. r=sg 2020-10-29 15:24:40 +00:00
network Bug 1626555 - Add dom/network to the list of non-unified-build-compatible directories. r=sg 2020-10-29 15:21:44 +00:00
notification Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
offline Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
payments Bug 1626555 - Add dom/payments to the list of non-unified-build-compatible directories. r=sg 2020-10-29 16:15:45 +00:00
performance Bug 1626555 - Add dom/performance to the list of non-unified-build-compatible directories. r=sg 2020-10-29 17:37:02 +00:00
permission Bug 1626555 - Add dom/permission to the list of non-unified-build-compatible directories. r=sg 2020-10-29 16:21:52 +00:00
plugins Bug 1663365 - Don't include "js/friend/ErrorMessages.h" in jsfriendapi.h. r=arai 2020-10-30 06:33:56 +00:00
power Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
presentation Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
prio Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
promise Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
prototype Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
push Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
quota Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
reporting Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
res
script Bug 1663365 - Don't include "js/friend/ErrorMessages.h" in jsfriendapi.h. r=arai 2020-10-30 06:33:56 +00:00
security Backed out changeset 5ea7a34f266c (bug 1660969) for Browser-chrome failures in browser_test_mixed_content_download.js. CLOSED TREE 2020-10-29 18:37:39 +02:00
serviceworkers Bug 1588152 - Eliminate redundant profile-change-teardown observer. r=asuth 2020-10-30 18:44:54 +00:00
simpledb Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
smil Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
storage Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
svg Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
system Bug 1663365 - Don't include "js/friend/ErrorMessages.h" in jsfriendapi.h. r=arai 2020-10-30 06:33:56 +00:00
tests Bug 1518999 - Refactor some performance.getEntries related tests r=mstange 2020-10-27 16:25:50 +00:00
u2f Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
url Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
vr Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
webauthn Bug 1660555 - Move traverse/unlink operations on |AbortFollower| and |AbortSignalImpl| into static member functions. r=smaug 2020-10-29 08:02:58 +00:00
webbrowserpersist Bug 1599616 - Don't try to save document when document actor has been destroyed. r=smaug 2020-10-26 19:19:51 +00:00
webgpu Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
webidl Bug 1673885 - Don't expose incomplete sheets in LinkStyle.sheet / Document.styleSheets. r=nordzilla 2020-10-30 23:30:14 +00:00
webshare Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
websocket Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
workers Bug 1663365 - Don't include "js/friend/ErrorMessages.h" in jsfriendapi.h. r=arai 2020-10-30 06:33:56 +00:00
worklet Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
xhr Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
xml Bug 1673885 - Don't expose incomplete sheets in LinkStyle.sheet / Document.styleSheets. r=nordzilla 2020-10-30 23:30:14 +00:00
xslt Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
xul Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
jar.mn
moz.build Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00