mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-21 17:25:36 +00:00
f42cec8f44
Re-enabling the PGO jarlog, which was unexpectedly disabled since Firefox 56 showed a regression on Windows 7, due to the use of mozilla::ReadAhead, which on Windows 7 does explicit I/O on the caller thread. While there may be some benefit from doing so, evidence says the opposite, which is presumably due to the amount of data being loaded not being relevant in every case: the jarlog is gathered from a first-run, which has a different jar-loading profile from subsequent runs of Firefox. While we may want to improve the situation later on, the immediate thing we can do is stop doing this explicit read, while keeping the OS readahead hints on other platforms, which don't imply explicit I/O. All this does is effectively get us back to the same state as if jarlogs were disabled like it was since Firefox 56, for Windows 7 only. aFd not being used anymore, the code could be cleaned up a lot, but we may reintroduce the readahead later, so keep the status quo for now. Differential Revision: https://phabricator.services.mozilla.com/D23642 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| test | ||
| zipwriter | ||
| appnote.txt | ||
| components.conf | ||
| moz.build | ||
| nsIJARChannel.idl | ||
| nsIJARURI.idl | ||
| nsIZipReader.idl | ||
| nsJAR.cpp | ||
| nsJAR.h | ||
| nsJARChannel.cpp | ||
| nsJARChannel.h | ||
| nsJARInputStream.cpp | ||
| nsJARInputStream.h | ||
| nsJARProtocolHandler.cpp | ||
| nsJARProtocolHandler.h | ||
| nsJARURI.cpp | ||
| nsJARURI.h | ||
| nsZipArchive.cpp | ||
| nsZipArchive.h | ||
| zipstruct.h | ||