mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-24 21:31:04 +00:00
fc57d9bf0f
`GetInternalCommand()` is currently used only by `EditorCommand` and it treats the additional parameter only when given command is `cmd_align`. However, the value is complicated since `AlignCommand` allows both `CString` value and `String` value. Therefore, `EditorCommand::DoCommandParams()` may fail to solve `cmd_align` to a `Command` value without checking both of them. Therefore, it must make sense that `GetInternalCommand()` take `nsCommandParams` as optional argument and check it only when given command matches `cmd_align`. Then, we don't need to waste unnecessary run-time cost. Note that this bug has been hidden since `AlignCommand` class does not refer the `Command` value but refers only `nsCommandParams`. However, the previous patch makes `EditorCommand::GetParamType()` not allow `Command::DoNothing`. Therefore, we need this follow-up fix now. Differential Revision: https://phabricator.services.mozilla.com/D30501 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| composer | ||
| libeditor | ||
| reftests | ||
| spellchecker | ||
| txmgr | ||
| AsyncSpellCheckTestHelper.jsm | ||
| moz.build | ||
| nsIDocumentStateListener.idl | ||
| nsIEditActionListener.idl | ||
| nsIEditor.idl | ||
| nsIEditorMailSupport.idl | ||
| nsIEditorObserver.idl | ||
| nsIEditorSpellCheck.idl | ||
| nsIEditorStyleSheets.idl | ||
| nsIHTMLAbsPosEditor.idl | ||
| nsIHTMLEditor.idl | ||
| nsIHTMLInlineTableEditor.idl | ||
| nsIHTMLObjectResizer.idl | ||
| nsIPlaintextEditor.idl | ||
| nsITableEditor.idl | ||
| nsIURIRefObject.idl | ||