mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-23 21:01:08 +00:00
11ac9e9cf8
* Remove redundant virtual keywords
* Mark all destructors of inheriting classes as virtual for clarity
* Mark all classes without virtual destructor as final (exposed errors)
* Make destructor virtual where it needed to be (some were missing)
* Replace empty ({}) code declaration in header with = default
* Remove virtual unused methods
I probably missed some, it quickly became a rabbit hole.
Differential Revision: https://phabricator.services.mozilla.com/D26060
--HG--
extra : moz-landing-system : lando
60 lines
1.5 KiB
C++
60 lines
1.5 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef MOZILLA_LAYERS_IPDLACTOR_H
|
|
#define MOZILLA_LAYERS_IPDLACTOR_H
|
|
|
|
#include "mozilla/ipc/ProtocolUtils.h"
|
|
#include "mozilla/layers/CompositableForwarder.h"
|
|
#include "mozilla/Unused.h"
|
|
#include "gfxPlatform.h"
|
|
|
|
namespace mozilla {
|
|
namespace layers {
|
|
|
|
/// A base class to facilitate the deallocation of IPDL actors.
|
|
///
|
|
/// Implements the parent side of the simple deallocation handshake.
|
|
/// Override the Destroy method rather than the ActorDestroy method.
|
|
template <typename Protocol>
|
|
class ParentActor : public Protocol {
|
|
public:
|
|
ParentActor() : mDestroyed(false) {}
|
|
|
|
~ParentActor() { MOZ_ASSERT(mDestroyed); }
|
|
|
|
bool CanSend() const { return !mDestroyed; }
|
|
|
|
// Override this rather than ActorDestroy
|
|
virtual void Destroy() {}
|
|
|
|
mozilla::ipc::IPCResult RecvDestroy() final {
|
|
DestroyIfNeeded();
|
|
Unused << Protocol::Send__delete__(this);
|
|
return IPC_OK();
|
|
}
|
|
|
|
typedef ipc::IProtocol::ActorDestroyReason Why;
|
|
|
|
void ActorDestroy(Why) override { DestroyIfNeeded(); }
|
|
|
|
protected:
|
|
void DestroyIfNeeded() {
|
|
if (!mDestroyed) {
|
|
Destroy();
|
|
mDestroyed = true;
|
|
}
|
|
}
|
|
|
|
private:
|
|
bool mDestroyed;
|
|
};
|
|
|
|
} // namespace layers
|
|
} // namespace mozilla
|
|
|
|
#endif
|