gecko-dev/ipc/unixfd
Nicholas Nethercote 34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
..
moz.build Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
UnixFdWatcher.cpp Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 2016-09-02 17:12:24 +10:00
UnixFdWatcher.h Bug 979858: Add include guards to headers in ipc/unixfd, r=kyle 2014-03-06 09:32:25 +01:00
UnixFileWatcher.cpp
UnixFileWatcher.h Bug 979858: Add include guards to headers in ipc/unixfd, r=kyle 2014-03-06 09:32:25 +01:00
UnixSocketWatcher.cpp Bug 1162524: Move |accept| out of |UnixSocketWatcher|, r=kmachulis 2015-05-08 09:43:01 +02:00
UnixSocketWatcher.h Bug 1167210: Replace |union sockaddr_any| with |struct sockaddr_storage|, r=kmachulis 2015-05-27 13:49:07 +02:00