gecko-dev/python/mozbuild
Mike Hommey 30cbb26b96 Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r=chmanchester
Several things were wrong with the wrapping:
- the equality test on functions was actually comparing the memoized
  functions, which have a type memoize, which inherits from dict. So
  they weren't comparing actual functions, but the dict used to store
  the cache of their invocation.
- each CombinedDependsFunction created for the same combination function
  used a different wrapped function, so even if the dict problem wasn't
  there, the equality test still wouldn't work, except if the function
  wrapping itself was memoized.
- the memoization was not particularly useful.

Also, for upcoming changes, we'd actually like the combination function to
take an iterable instead of a variable argument list, so that items of
the iterable can be skipped.

--HG--
extra : rebase_source : 2c91889315b49695a2e2b709a9264de9ff237598
2017-01-25 16:50:29 +09:00
..
dumbmake Bug 1317970 - Use manifestparser manifests for python unit tests, r=chmanchester 2016-11-16 09:59:22 -05:00
mozbuild Bug 1322025 - Don't wrap the combination function in CombinedDependsFunction. r=chmanchester 2017-01-25 16:50:29 +09:00
mozpack Backed out changeset 349a316ed0f7 (bug 1316735) for build packaging failures 2016-12-13 10:48:40 -08:00
setup.py
TODO