mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-05 22:05:40 +00:00
a15c6351cb
Since bug 635961, building with relro makes elfhack try to use the bss data for a temporary function pointer. If there is not enough space for a pointer in the bss, elfhack will complain it couldn't find the bss. In normal circumstances, this is most likely fine. Libraries with a bss so small that it can't fit a pointer are already too small to be elfhacked anyways. In Firefox, the two libraries with the smallest bss have enough space for two pointers, and aren't elfhacked (libmozgtk.so and libplds4.so). However, the testcase that is used during the build to validate that elfhack works doesn't have a large enough bss on x86-64, making elfhack bail out, and the build fail as a consequence. This, in turn, is due to the only non-thread-local zeroed data being an int, which is not enough to fit a pointer on x86-64. We thus make it a size_t. --HG-- extra : rebase_source : bca2ddbf9d4a5e8786881fc524d642c38d610227