mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-22 17:55:50 +00:00
ae31355192
The current JSWindowActor code assumes that all actors will be created in the shared JSM global. This has a few problems: 1) For actors in other scopes, it enters the wrong compartment before decoding messages, which leads to a compartment checker error when trying to call message handlers. That could be fixed by just wrapping the result for the caller, but that would lead to other problems. Aside from the efficiency concerns of having to deal with cross-compartment wrappers, SpecialPowers in particular would not be able to pass the resulting objects to unprivileged scopes, since only SpecialPowers compartments have permissive CCWs enabled. 2) It also leads to the prototype objects for the actor instances being created in the shared JSM scope, even when the actors themselves are defined in other compartments. Again, aside from CCW efficiency issues, this prevents the SpecialPowers instances from being accessed by the unprivileged scopes that they're exposed to, since the prototype objects live in privileged scopes which don't have permissive CCWs enabled. This patch changes child actors to always create their objects in the global of their constructors. The parent objects are still created in the shared JSM global, but they now wrap values for the appropriate compartment before trying to call message handlers. Differential Revision: https://phabricator.services.mozilla.com/D35051 --HG-- extra : rebase_source : 436ce516080812680d1433bf3ecbd12f91d88165 extra : source : 61fa2745733f3631488a3ecccc144823683b7b6d
67 lines
1.9 KiB
C++
67 lines
1.9 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim:set ts=2 sw=2 sts=2 et cindent: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_dom_JSWindowActorParent_h
|
|
#define mozilla_dom_JSWindowActorParent_h
|
|
|
|
#include "js/TypeDecls.h"
|
|
#include "mozilla/Attributes.h"
|
|
#include "mozilla/ErrorResult.h"
|
|
#include "mozilla/dom/BindingDeclarations.h"
|
|
#include "mozilla/dom/JSWindowActor.h"
|
|
#include "nsCycleCollectionParticipant.h"
|
|
#include "nsWrapperCache.h"
|
|
|
|
namespace mozilla {
|
|
namespace dom {
|
|
|
|
class WindowGlobalParent;
|
|
|
|
} // namespace dom
|
|
} // namespace mozilla
|
|
|
|
namespace mozilla {
|
|
namespace dom {
|
|
|
|
class JSWindowActorParent final : public JSWindowActor {
|
|
public:
|
|
NS_DECL_ISUPPORTS_INHERITED
|
|
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS_INHERITED(JSWindowActorParent,
|
|
JSWindowActor)
|
|
|
|
JSObject* WrapObject(JSContext* aCx,
|
|
JS::Handle<JSObject*> aGivenProto) override;
|
|
|
|
static already_AddRefed<JSWindowActorParent> Constructor(
|
|
GlobalObject& aGlobal, ErrorResult& aRv) {
|
|
return MakeAndAddRef<JSWindowActorParent>();
|
|
}
|
|
|
|
nsIGlobalObject* GetParentObject() const override;
|
|
|
|
WindowGlobalParent* GetManager() const;
|
|
void Init(const nsAString& aName, WindowGlobalParent* aManager);
|
|
void StartDestroy();
|
|
void AfterDestroy();
|
|
CanonicalBrowsingContext* GetBrowsingContext(ErrorResult& aRv);
|
|
|
|
protected:
|
|
void SendRawMessage(const JSWindowActorMessageMeta& aMeta,
|
|
ipc::StructuredCloneData&& aData,
|
|
ErrorResult& aRv) override;
|
|
|
|
private:
|
|
~JSWindowActorParent();
|
|
|
|
bool mCanSend = true;
|
|
RefPtr<WindowGlobalParent> mManager;
|
|
};
|
|
|
|
} // namespace dom
|
|
} // namespace mozilla
|
|
|
|
#endif // mozilla_dom_JSWindowActorParent_h
|