mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-24 21:31:04 +00:00
01e0dbf44b
This patch simplifies nsStaticCaseInsensitiveNameTable greatly by taking
advantage of the following observations.
- |new| is infallible, so |new nsStaticCaseInsensitiveNameTable()| calls don't
need their return value checked.
- nsStaticCaseInsensitiveNameTable::Init() checks if any of the added entries
differ only in case, so the callers of that function don't need to do the
same check.
- nsStaticCaseInsensitiveNameTable::Init() never returns false because
moz_xmalloc() is infallible. (Its callers never check the return value
anyway.) So it can be merged into the constructor. And
~nsStaticCaseInsensitiveNameTable() need not null-check |mNameArray|.
- PLDHashTable now has an initializing constructor and destructor, so these can
be used in nsStaticCaseInsensitiveNameTable, thus avoiding manual
PLD_HashTable{Init,Finish}() calls.
88 lines
2.5 KiB
C++
88 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
/* keywords used within CSS property values */
|
|
|
|
#include "nsCSSKeywords.h"
|
|
#include "nsString.h"
|
|
#include "nsStaticNameTable.h"
|
|
|
|
// required to make the symbol external, so that TestCSSPropertyLookup.cpp can link with it
|
|
extern const char* const kCSSRawKeywords[];
|
|
|
|
// define an array of all CSS keywords
|
|
#define CSS_KEY(_name,_id) #_name,
|
|
const char* const kCSSRawKeywords[] = {
|
|
#include "nsCSSKeywordList.h"
|
|
};
|
|
#undef CSS_KEY
|
|
|
|
static int32_t gKeywordTableRefCount;
|
|
static nsStaticCaseInsensitiveNameTable* gKeywordTable;
|
|
|
|
void
|
|
nsCSSKeywords::AddRefTable(void)
|
|
{
|
|
if (0 == gKeywordTableRefCount++) {
|
|
NS_ASSERTION(!gKeywordTable, "pre existing array!");
|
|
gKeywordTable =
|
|
new nsStaticCaseInsensitiveNameTable(kCSSRawKeywords, eCSSKeyword_COUNT);
|
|
#ifdef DEBUG
|
|
// Partially verify the entries.
|
|
int32_t index = 0;
|
|
for (; index < eCSSKeyword_COUNT && kCSSRawKeywords[index]; ++index) {
|
|
nsAutoCString temp(kCSSRawKeywords[index]);
|
|
NS_ASSERTION(-1 == temp.FindChar('_'), "underscore char in table");
|
|
}
|
|
NS_ASSERTION(index == eCSSKeyword_COUNT, "kCSSRawKeywords and eCSSKeyword_COUNT are out of sync");
|
|
#endif
|
|
}
|
|
}
|
|
|
|
void
|
|
nsCSSKeywords::ReleaseTable(void)
|
|
{
|
|
if (0 == --gKeywordTableRefCount) {
|
|
if (gKeywordTable) {
|
|
delete gKeywordTable;
|
|
gKeywordTable = nullptr;
|
|
}
|
|
}
|
|
}
|
|
|
|
nsCSSKeyword
|
|
nsCSSKeywords::LookupKeyword(const nsACString& aKeyword)
|
|
{
|
|
NS_ASSERTION(gKeywordTable, "no lookup table, needs addref");
|
|
if (gKeywordTable) {
|
|
return nsCSSKeyword(gKeywordTable->Lookup(aKeyword));
|
|
}
|
|
return eCSSKeyword_UNKNOWN;
|
|
}
|
|
|
|
nsCSSKeyword
|
|
nsCSSKeywords::LookupKeyword(const nsAString& aKeyword)
|
|
{
|
|
NS_ASSERTION(gKeywordTable, "no lookup table, needs addref");
|
|
if (gKeywordTable) {
|
|
return nsCSSKeyword(gKeywordTable->Lookup(aKeyword));
|
|
}
|
|
return eCSSKeyword_UNKNOWN;
|
|
}
|
|
|
|
const nsAFlatCString&
|
|
nsCSSKeywords::GetStringValue(nsCSSKeyword aKeyword)
|
|
{
|
|
NS_ASSERTION(gKeywordTable, "no lookup table, needs addref");
|
|
NS_ASSERTION(0 <= aKeyword && aKeyword < eCSSKeyword_COUNT, "out of range");
|
|
if (gKeywordTable) {
|
|
return gKeywordTable->GetStringValue(int32_t(aKeyword));
|
|
} else {
|
|
static nsDependentCString kNullStr("");
|
|
return kNullStr;
|
|
}
|
|
}
|
|
|