mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-19 08:15:31 +00:00
33a69b7eea
In upcoming changes, we're going to use the normal compiler flags for bindgen instead of having a separate logic for essentially the same flags (and there's not much reason not to use the same flags after all). One hiccup, though is that for some reason, --target=i686-linux-gnu doesn't work with bindgen while it works with clang in the same setup. But -m32 does. Considering -m32 and -m64 are standard flags and that we're using them in many cases, it doesn't hurt to use them instead of --target with clang. While we're doing that, we might as well refactor a little to avoid the multiple branches handling the use of -m32/-m64, and fix the theoretical compile-x86_64-with-x86-clang-cl case, as well as the weird check for aarch64. And because only two cases actually require -Xclang, only one of which requires a condition, and the control flow is not too complex to avoid flag duplication, we just remove the append_flag function; it was too confusing, with all the cases we skipped it when -Xclang was not wanted. Differential Revision: https://phabricator.services.mozilla.com/D18316 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| devtools/migrate-l10n | ||
| docs | ||
| l10n/fluent_migrations | ||
| mach | ||
| mozboot | ||
| mozbuild | ||
| mozlint | ||
| mozrelease | ||
| mozterm | ||
| mozversioncontrol | ||
| safety | ||
| mach_commands.py | ||
| moz.build | ||
| README | ||
This directory contains common Python code. The basic rule is that if Python code is cross-module (that's "module" in the Mozilla meaning - as in "module ownership") and is MPL-compatible, it should go here. What should not go here: * Vendored python modules (use third_party/python instead) * Python that is not MPL-compatible (see other-licenses/) * Python that has good reason to remain close to its "owning" (Mozilla) module (e.g. it is only being consumed from there). Historical information can be found at https://bugzilla.mozilla.org/show_bug.cgi?id=775243 https://bugzilla.mozilla.org/show_bug.cgi?id=1346025