mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-27 12:15:33 +00:00
33a9e6d050
<!-- Please describe your changes on the following line: --> Before this PR, every object reflected in CSSOM is in `Arc<RwLock<_>>` to enable safe (synchronized) mutable aliasing. Acquiring all these locks has significant cost during selector matching: * https://bugzilla.mozilla.org/show_bug.cgi?id=1311469 * https://bugzilla.mozilla.org/show_bug.cgi?id=1335941 * https://bugzilla.mozilla.org/show_bug.cgi?id=1339703 This PR introduce a mechanism to protect many objects with the same `RwLock` that only needs to be acquired once. In Stylo, there is one such lock per process (in a `lazy_static`), used for everything. I non-Stylo Servo, I originally intended to have one such lock per document (for author-origin stylesheets, and one per process for user-agent and user sytlesheets since they’re shared across documents, and never mutated anyway). However I failed to have the same document-specific (or pipeline-specific) `Arc` reachable from both `Document` nodes and `LayoutThread`. Recursively following callers lead me to include this `Arc` in `UnprivilegedPipelineContent`, but that needs to be serializable. So there is a second process-wide lock. This was previously #15998, closed accidentally. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: bb54f0a429de0e8b8861f8071b6cf82f73622664 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 851230e57ac8775707df5f0f103be5feac81fc41
31 lines
814 B
TOML
31 lines
814 B
TOML
[package]
|
|
name = "geckoservo"
|
|
version = "0.0.1"
|
|
authors = ["The Servo Project Developers"]
|
|
license = "MPL-2.0"
|
|
|
|
[lib]
|
|
name = "geckoservo"
|
|
path = "lib.rs"
|
|
crate-type = ["staticlib", "rlib"]
|
|
|
|
[features]
|
|
bindgen = ["style/use_bindgen"]
|
|
testing = ["style/testing"]
|
|
|
|
[dependencies]
|
|
atomic_refcell = "0.1"
|
|
cssparser = "0.12"
|
|
env_logger = {version = "0.4", default-features = false} # disable `regex` to reduce code size
|
|
lazy_static = "0.2"
|
|
libc = "0.2"
|
|
log = {version = "0.3.5", features = ["release_max_level_info"]}
|
|
parking_lot = "0.3"
|
|
selectors = {path = "../../components/selectors"}
|
|
servo_url = {path = "../../components/url"}
|
|
style = {path = "../../components/style", features = ["gecko"]}
|
|
style_traits = {path = "../../components/style_traits"}
|
|
|
|
[dev-dependencies]
|
|
stylo_tests = {path = "../../tests/unit/stylo"}
|