Gerald Squelart b51e0fd0cc Bug 1489944 - Fixed some std::move warnings - r=froydnj ... > dom/media/gmp/CDMStorageIdProvider.cpp(63,10): warning: > local variable 'storageId' will be copied despite being returned by name [-Wreturn-std-move] nsAutoCString -> nsCString, will add std::move(). > layout/painting/DisplayItemClip.cpp(581,10): warning: > local variable 'str' will be copied despite being returned by name [-Wreturn-std-move] nsAutoCString -> nsCString, will add std::move(). > layout/painting/DisplayItemClipChain.cpp(88,10): warning: > local variable 'str' will be copied despite being returned by name [-Wreturn-std-move] nsAutoCString -> nsCString, will add std::move(). > layout/painting/nsDisplayList.cpp(179,10): warning: > local variable 'str' will be copied despite being returned by name [-Wreturn-std-move] nsAutoCString -> nsCString, will add std::move(). > gfx/thebes/gfxWindowsPlatform.cpp(454,10): warning: > moving a local object in a return statement prevents copy elision [-Wpessimizing-move] Will remove std::move(). > gfx/thebes/gfxFontEntry.cpp(245,20): warning: > local variable 'name' will be copied despite being returned by name [-Wreturn-std-move] nsAutoCString -> nsCString, will add std::move(). > netwerk/cookie/nsCookieService.cpp(4460,10): warning: > local variable 'path' will be copied despite being returned by name [-Wreturn-std-move] GetPathFromURI() result is stored in an nsAutoCString, so it might as well return that type. > toolkit/components/extensions/WebExtensionPolicy.cpp(462,12): warning: > local variable 'result' will be copied despite being returned by name [-Wreturn-std-move] > toolkit/components/extensions/WebExtensionPolicy.cpp(475,10): warning: > local variable 'result' will be copied despite being returned by name [-Wreturn-std-move] `result` may be empty or may be arbitrarily long, so I'll use nsCString inside the function. > toolkit/xre/CmdLineAndEnvUtils.h(349,10): warning: > moving a local object in a return statement prevents copy elision [-Wpessimizing-move] Returning an UniquePtr, will remove std::move(). Also will `return s` instead of `return nullptr` when `(!s)`, to avoid extra construction which could also prevent elision (not entirely sure, but it's at least not worse!); and it's clearer that the two `return`s return the same already-constructed on-stack object. > tools/profiler/core/shared-libraries-win32.cc(111,10): warning: > local variable 'version' will be copied despite being returned by name [-Wreturn-std-move] nsPrintfCString -> nsCString, will add std::move(). > xpcom/glue/FileUtils.cpp(179,10): warning: > local variable 'fullName' will be copied despite being returned by name [-Wreturn-std-move] > xpcom/glue/FileUtils.cpp(209,10): warning: > local variable 'path' will be copied despite being returned by name [-Wreturn-std-move] nsAuto{,C}String -> ns{,C}String, will add std::move(). This allowed removals of 'AllowCompilerWarnings' from layout/painting, netwerk/cookie, and toolkit/components/extensions. Differential Revision: https://phabricator.services.mozilla.com/D5425 --HG-- extra : moz-landing-system : lando		2018-09-10 15:51:48 +00:00
..
standalone
FileUtils.cpp
FileUtils.h
moz.build
objs.mozbuild
XREAppData.cpp