mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-02 18:08:58 +00:00
d20809a078
Pixel 6, 7, and 8 devices running Android 14 are affected by a bug where video frames with SMPTE 432 color primaries are rendered incorrectly when sampled from an external texture in GLES. To work around this, we force these frames to be converted to RGB using BT709 colorspace instead. While this won't look exactly right, it is much better than the current situation. When we detect that a frame is decoded with that color space on an affected device, we set a "ForceBT709" flag which gets passed through to webrender as a new ImageBufferKind. Rendering this ImageBufferKind is handled via a new shader feature TEXTURE_EXTERNAL_BT709, which works much like the existing TEXTURE_EXTERNAL feature, but additionally uses the EXT_YUV_TARGET extension to override the colorspace transformation. This approach could be extended in the future to handle additional colorspace transformations, but for now only handles the one required to workaround this particular driver bug. Differential Revision: https://phabricator.services.mozilla.com/D195800
118 lines
3.8 KiB
C++
118 lines
3.8 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef GFX_GLIMAGES_H
|
|
#define GFX_GLIMAGES_H
|
|
|
|
#include "GLContextTypes.h"
|
|
#include "GLTypes.h"
|
|
#include "ImageContainer.h" // for Image
|
|
#include "ImageTypes.h" // for ImageFormat::SHARED_GLTEXTURE
|
|
#include "nsCOMPtr.h" // for already_AddRefed
|
|
#include "mozilla/Maybe.h" // for Maybe
|
|
#include "mozilla/gfx/Matrix.h" // for Matrix4x4
|
|
#include "mozilla/gfx/Point.h" // for IntSize
|
|
|
|
#ifdef MOZ_WIDGET_ANDROID
|
|
# include "AndroidSurfaceTexture.h"
|
|
#endif
|
|
|
|
namespace mozilla {
|
|
namespace layers {
|
|
|
|
class GLImage : public Image {
|
|
public:
|
|
explicit GLImage(ImageFormat aFormat) : Image(nullptr, aFormat) {}
|
|
|
|
already_AddRefed<gfx::SourceSurface> GetAsSourceSurface() override;
|
|
|
|
nsresult BuildSurfaceDescriptorBuffer(
|
|
SurfaceDescriptorBuffer& aSdBuffer, BuildSdbFlags aFlags,
|
|
const std::function<MemoryOrShmem(uint32_t)>& aAllocate) override;
|
|
|
|
GLImage* AsGLImage() override { return this; }
|
|
|
|
protected:
|
|
nsresult ReadIntoBuffer(uint8_t* aData, int32_t aStride,
|
|
const gfx::IntSize& aSize,
|
|
gfx::SurfaceFormat aFormat);
|
|
};
|
|
|
|
#ifdef MOZ_WIDGET_ANDROID
|
|
|
|
class SurfaceTextureImage final : public GLImage {
|
|
public:
|
|
class SetCurrentCallback {
|
|
public:
|
|
virtual void operator()(void) = 0;
|
|
virtual ~SetCurrentCallback() {}
|
|
};
|
|
|
|
SurfaceTextureImage(AndroidSurfaceTextureHandle aHandle,
|
|
const gfx::IntSize& aSize, bool aContinuous,
|
|
gl::OriginPos aOriginPos, bool aHasAlpha,
|
|
bool aForceBT709ColorSpace,
|
|
Maybe<gfx::Matrix4x4> aTransformOverride);
|
|
|
|
gfx::IntSize GetSize() const override { return mSize; }
|
|
AndroidSurfaceTextureHandle GetHandle() const { return mHandle; }
|
|
bool GetContinuous() const { return mContinuous; }
|
|
gl::OriginPos GetOriginPos() const { return mOriginPos; }
|
|
bool GetHasAlpha() const { return mHasAlpha; }
|
|
bool GetForceBT709ColorSpace() const { return mForceBT709ColorSpace; }
|
|
const Maybe<gfx::Matrix4x4>& GetTransformOverride() const {
|
|
return mTransformOverride;
|
|
}
|
|
|
|
already_AddRefed<gfx::SourceSurface> GetAsSourceSurface() override {
|
|
// We can implement this, but currently don't want to because it will cause
|
|
// the SurfaceTexture to be permanently bound to the snapshot readback
|
|
// context.
|
|
return nullptr;
|
|
}
|
|
|
|
nsresult BuildSurfaceDescriptorBuffer(
|
|
SurfaceDescriptorBuffer& aSdBuffer, BuildSdbFlags aFlags,
|
|
const std::function<MemoryOrShmem(uint32_t)>& aAllocate) override {
|
|
// We can implement this, but currently don't want to because it will cause
|
|
// the SurfaceTexture to be permanently bound to the snapshot readback
|
|
// context.
|
|
return NS_ERROR_NOT_IMPLEMENTED;
|
|
}
|
|
|
|
SurfaceTextureImage* AsSurfaceTextureImage() override { return this; }
|
|
|
|
Maybe<SurfaceDescriptor> GetDesc() override;
|
|
|
|
void RegisterSetCurrentCallback(UniquePtr<SetCurrentCallback> aCallback) {
|
|
mSetCurrentCallback = std::move(aCallback);
|
|
}
|
|
|
|
void OnSetCurrent() {
|
|
if (mSetCurrentCallback) {
|
|
(*mSetCurrentCallback)();
|
|
mSetCurrentCallback.reset();
|
|
}
|
|
}
|
|
|
|
private:
|
|
AndroidSurfaceTextureHandle mHandle;
|
|
gfx::IntSize mSize;
|
|
bool mContinuous;
|
|
gl::OriginPos mOriginPos;
|
|
const bool mHasAlpha;
|
|
const bool mForceBT709ColorSpace;
|
|
const Maybe<gfx::Matrix4x4> mTransformOverride;
|
|
UniquePtr<SetCurrentCallback> mSetCurrentCallback;
|
|
};
|
|
|
|
#endif // MOZ_WIDGET_ANDROID
|
|
|
|
} // namespace layers
|
|
} // namespace mozilla
|
|
|
|
#endif // GFX_GLIMAGES_H
|