mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-13 05:15:45 +00:00
3644913b9c
Usually, documentUrlPatterns applies to the URL of the document where the context menu is opened. In some cases, there is no document, such as menus on browser UI (extension action buttons, tools menu, tabs). In these cases, `documentUrlPatterns` matches the (active) tab's URL. This causes ambiguity when `browser.menus.overrideContext` is used to change the context to the "tab" context. Before this patch, `documentUrlPatterns` applied to the tab's URL. After this patch, `documentUrlPatterns` applies to the URL of the document where the menu was opened, *if* `viewTypes` is also set. Using this property is a strong signal from the extension that the menu is meant to be shown in a document rather than browser UI, so extensions can reasonably expect `documentUrlPatterns` to match the original document's URL instead of the URL of the spoofed tab context. There was no existing test coverage for documentUrlPatterns on tab contexts, so this does not only add tests for documentUrlPatterns on overridden contexts (browser_ext_menus_replace_menu_context.js), but also documentUrlPatterns in normal tab contexts (browser_ext_menus.js). Differential Revision: https://phabricator.services.mozilla.com/D9249 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| actors | ||
| app | ||
| base | ||
| branding | ||
| components | ||
| config | ||
| docs | ||
| extensions | ||
| fonts | ||
| installer | ||
| locales | ||
| modules | ||
| themes | ||
| tools/mozscreenshots | ||
| .eslintrc.js | ||
| app.mozbuild | ||
| build.mk | ||
| confvars.sh | ||
| defs.mk | ||
| LICENSE | ||
| Makefile.in | ||
| moz.build | ||
| moz.configure | ||