mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-01 17:23:59 +00:00
c0e93222ee
IsStartOfGroup wants to peek at the previous character. It calls PrevChar, but it doesn't check for failure. It then unconditionally increments mOffset to "undo" PrevChar. If PrevChar failed, that means we're now 1 character after where we started. This wasn't causing any test failures and I can't think of a test case that shows breakage here. Nevertheless, it definitely doesn't make sense and could cause difficult-to-diagnose bugs. This in turn exposed a bug in PrevChar whereby it didn't handle being called again after it had already failed. That also had to be fixed here. Differential Revision: https://phabricator.services.mozilla.com/D128332 |
||
---|---|---|
.. | ||
AccAttributes.cpp | ||
AccAttributes.h | ||
AccEvent.cpp | ||
AccEvent.h | ||
AccGroupInfo.cpp | ||
AccGroupInfo.h | ||
AccIterator.cpp | ||
AccIterator.h | ||
AccTypes.h | ||
ARIAMap.cpp | ||
ARIAMap.h | ||
ARIAStateMap.cpp | ||
ARIAStateMap.h | ||
Asserts.cpp | ||
CacheConstants.h | ||
DocManager.cpp | ||
DocManager.h | ||
EmbeddedObjCollector.cpp | ||
EmbeddedObjCollector.h | ||
EventQueue.cpp | ||
EventQueue.h | ||
EventTree.cpp | ||
EventTree.h | ||
Filters.cpp | ||
Filters.h | ||
FocusManager.cpp | ||
FocusManager.h | ||
HTMLMarkupMap.h | ||
IDSet.h | ||
Logging.cpp | ||
Logging.h | ||
MathMLMarkupMap.h | ||
moz.build | ||
NotificationController.cpp | ||
NotificationController.h | ||
nsAccCache.h | ||
nsAccessibilityService.cpp | ||
nsAccessibilityService.h | ||
nsAccessiblePivot.cpp | ||
nsAccessiblePivot.h | ||
nsAccUtils.cpp | ||
nsAccUtils.h | ||
nsCoreUtils.cpp | ||
nsCoreUtils.h | ||
nsEventShell.cpp | ||
nsEventShell.h | ||
nsTextEquivUtils.cpp | ||
nsTextEquivUtils.h | ||
Pivot.cpp | ||
Pivot.h | ||
Platform.h | ||
Relation.h | ||
RelationType.h | ||
RelationTypeMap.h | ||
Role.h | ||
RoleMap.h | ||
SelectionManager.cpp | ||
SelectionManager.h | ||
States.h | ||
Statistics.h | ||
StyleInfo.cpp | ||
StyleInfo.h | ||
TextAttrs.cpp | ||
TextAttrs.h | ||
TextLeafRange.cpp | ||
TextLeafRange.h | ||
TextRange-inl.h | ||
TextRange.cpp | ||
TextRange.h | ||
TextUpdater.cpp | ||
TextUpdater.h | ||
TreeWalker.cpp | ||
TreeWalker.h | ||
XULMap.h |