gecko-dev/accessible/base
James Teh c0e93222ee Bug 1735464: PrevWordBreakClassWalker::IsStartOfGroup: Don't advance mOffset if PrevChar fails. r=eeejay
IsStartOfGroup wants to peek at the previous character.
It calls PrevChar, but it doesn't check for failure.
It then unconditionally increments mOffset to "undo" PrevChar.
If PrevChar failed, that means we're now 1 character after where we started.
This wasn't causing any test failures and I can't think of a test case that shows breakage here.
Nevertheless, it definitely doesn't make sense and could cause difficult-to-diagnose bugs.

This in turn exposed a bug in PrevChar whereby it didn't handle being called again after it had already failed.
That also had to be fixed here.

Differential Revision: https://phabricator.services.mozilla.com/D128332
2021-10-26 22:25:29 +00:00
..
AccAttributes.cpp Bug 1731374 - Add string storage to AccAttributes with move semantics. r=Jamie 2021-09-28 22:01:35 +00:00
AccAttributes.h Bug 1731374 - Add string storage to AccAttributes with move semantics. r=Jamie 2021-09-28 22:01:35 +00:00
AccEvent.cpp
AccEvent.h
AccGroupInfo.cpp
AccGroupInfo.h
AccIterator.cpp Bug 1725145 - fixes for linking in the hybrid build env. r=valentin 2021-08-22 10:21:56 +00:00
AccIterator.h
AccTypes.h Bug 1611062 - Remove unused eAutoComplete. r=Jamie 2021-10-04 16:30:45 +00:00
ARIAMap.cpp Bug 1727616 - Add meter ARIA role. r=Jamie 2021-08-26 16:17:21 +00:00
ARIAMap.h Backed out 4 changesets (bug 1722396) for causing multiple failures CLOSED TREE 2021-07-30 01:39:18 +03:00
ARIAStateMap.cpp
ARIAStateMap.h
Asserts.cpp
CacheConstants.h Bug 1734322 follow-up: Use different value for Text and DOMNodeID CacheDomains. r=morgan 2021-10-14 01:52:46 +00:00
DocManager.cpp Bug 1730541, remove nsCoreUtils::IsContentDocument, r=nika 2021-09-13 21:01:23 +00:00
DocManager.h
EmbeddedObjCollector.cpp
EmbeddedObjCollector.h
EventQueue.cpp Bug 1723614 - P2: Robustify name change events and use events in name tests. r=Jamie 2021-08-05 23:04:17 +00:00
EventQueue.h
EventTree.cpp Bug 1725145 - fixes for linking in the hybrid build env. r=valentin 2021-08-22 10:21:56 +00:00
EventTree.h
Filters.cpp
Filters.h
FocusManager.cpp
FocusManager.h
HTMLMarkupMap.h
IDSet.h
Logging.cpp Bug 1729061 - Introduce cache verification logging. r=Jamie 2021-09-28 21:55:41 +00:00
Logging.h Bug 1729061 - Introduce cache verification logging. r=Jamie 2021-09-28 21:55:41 +00:00
MathMLMarkupMap.h
moz.build Bug 1729407 part 1: Add new TextLeafPoint and TextLeafRange classes. r=eeejay 2021-09-23 11:38:09 +00:00
NotificationController.cpp Bug 1730093 part 1: Push text and line start offsets to the cache. r=eeejay 2021-10-06 04:53:52 +00:00
NotificationController.h
nsAccCache.h
nsAccessibilityService.cpp Bug 1733238 - P2: Make ImageAccessible an imgINotificationObserver. r=Jamie 2021-10-12 15:46:38 +00:00
nsAccessibilityService.h Bug 1733238 - P2: Make ImageAccessible an imgINotificationObserver. r=Jamie 2021-10-12 15:46:38 +00:00
nsAccessiblePivot.cpp
nsAccessiblePivot.h
nsAccUtils.cpp Bug 1730093 part 3: Support RemoteAccessible in nsAccUtils::TextLength. r=eeejay 2021-10-06 04:53:53 +00:00
nsAccUtils.h Bug 1733248 - Fire state change events for autocomplete changes. r=morgan 2021-10-21 22:47:43 +00:00
nsCoreUtils.cpp Bug 1730541, remove nsCoreUtils::IsContentDocument, r=nika 2021-09-13 21:01:23 +00:00
nsCoreUtils.h Bug 1730541, remove nsCoreUtils::IsContentDocument, r=nika 2021-09-13 21:01:23 +00:00
nsEventShell.cpp Bug 1727373 - Add state change info in event logging. r=morgan 2021-08-24 23:49:59 +00:00
nsEventShell.h
nsTextEquivUtils.cpp Bug 1725145 - header files fixes in the hybrid build env. r=valentin 2021-08-22 10:21:55 +00:00
nsTextEquivUtils.h
Pivot.cpp
Pivot.h
Platform.h
Relation.h
RelationType.h
RelationTypeMap.h
Role.h
RoleMap.h Bug 1732108: Map ATK_ROLE_CONTENT_DELETION/INSERTION. r=eeejay 2021-09-24 00:05:50 +00:00
SelectionManager.cpp
SelectionManager.h
States.h
Statistics.h
StyleInfo.cpp Bug 1723921 - Cleanup nsComputedDOMStyle and related APIs. r=layout-reviewers,jfkthame 2021-08-07 09:47:15 +00:00
StyleInfo.h
TextAttrs.cpp Bug 1731374 - Add string storage to AccAttributes with move semantics. r=Jamie 2021-09-28 22:01:35 +00:00
TextAttrs.h
TextLeafRange.cpp Bug 1735464: PrevWordBreakClassWalker::IsStartOfGroup: Don't advance mOffset if PrevChar fails. r=eeejay 2021-10-26 22:25:29 +00:00
TextLeafRange.h Bug 1730093 part 4: Support RemoteAccessible in TextLeafPoint. r=eeejay 2021-10-06 04:53:54 +00:00
TextRange-inl.h
TextRange.cpp
TextRange.h
TextUpdater.cpp
TextUpdater.h
TreeWalker.cpp Bug 1731526 - Fix non-unified build errors in accessible/. r=eeejay 2021-09-22 01:41:40 +00:00
TreeWalker.h
XULMap.h