gecko-dev/ipc
Kyle Huey 76e3009ab8 Bug 1179909: Refactor stable state handling. r=smaug
This is motivated by three separate but related problems:

1. Our concept of recursion depth is broken for things that run from AfterProcessNextEvent observers (e.g. Promises). We decrement the recursionDepth counter before firing observers, so a Promise callback running at the lowest event loop depth has a recursion depth of 0 (whereas a regular nsIRunnable would be 1). This is a problem because it's impossible to distinguish a Promise running after a sync XHR's onreadystatechange handler from a top-level event (since the former runs with depth 2 - 1 = 1, and the latter runs with just 1).

2. The nsIThreadObserver mechanism that is used by a lot of code to run "after" the current event is a poor fit for anything that runs script. First, the order the observers fire in is the order they were added, not anything fixed by spec. Additionally, running script can cause the event loop to spin, which is a big source of pain here (bholley has some nasty bug caused by this).

3. We run Promises from different points in the code for workers and main thread. The latter runs from XPConnect's nsIThreadObserver callbacks, while the former runs from a hardcoded call to run Promises in the worker event loop. What workers do is particularly problematic because it means we can't get the right recursion depth no matter what we do to nsThread.

The solve this, this patch does the following:

1. Consolidate some handling of microtasks and all handling of stable state from appshell and WorkerPrivate into CycleCollectedJSRuntime.
2. Make the recursionDepth counter only available to CycleCollectedJSRuntime (and its consumers) and remove it from the nsIThreadInternal and nsIThreadObserver APIs.
3. Adjust the recursionDepth counter so that microtasks run with the recursionDepth of the task they are associated with.
4. Introduce the concept of metastable state to replace appshell's RunBeforeNextEvent. Metastable state is reached after every microtask or task is completed. This provides the semantics that bent and I want for IndexedDB, where transactions autocommit at the end of a microtask and do not "spill" from one microtask into a subsequent microtask. This differs from appshell's RunBeforeNextEvent in two ways:
a) It fires between microtasks, which was the motivation for starting this.
b) It no longer ensures that we're at the same event loop depth in the native event queue. bent decided we don't care about this.
5. Reorder stable state to happen after microtasks such as Promises, per HTML. Right now we call the regular thread observers, including appshell, before the main thread observer (XPConnect), so stable state tasks happen before microtasks.
2015-08-11 06:10:46 -07:00
..
app Bug 1141693 - Build and use a PIE plugin-container on Android 5.0+. Based on a patch by Mike Hommey. r=me,glandium 2015-06-03 10:26:16 -05:00
chromium Bug 1056356 - Allow calling NewRunnableMethod() with a const pointer to the callee object. r=froydnj 2015-07-29 19:51:36 -04:00
contentproc Bug 1171796: Add sandbox rule for child process NSPR log file on Windows. r=bbondy 2015-07-30 10:04:42 +01:00
dbus Bug 1156632 - Remove unused forward class declarations - patch 4 - netwerk image and dom, r=ehsan 2015-04-22 08:29:20 +02:00
glue Bug 1179909: Refactor stable state handling. r=smaug 2015-08-11 06:10:46 -07:00
hal Bug 1187904: Add |DaemonSocketConnector|, r=shuang 2015-08-03 13:17:02 +02:00
ipdl Bug 1188696 - Hoist nsRefPtr.h into MFBT. r=froydnj 2015-07-29 10:44:59 -07:00
keystore Bug 1185478: Add leak checks to socket I/O classes 2015-07-21 08:06:29 +02:00
netd Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
nfc Bug 1185478: Add leak checks to socket I/O classes 2015-07-21 08:06:29 +02:00
ril Bug 1185478: Add leak checks to socket I/O classes 2015-07-21 08:06:29 +02:00
testshell Bug 1177825 - Remove JSVAL_* constants. r=evilpie 2015-06-29 18:36:44 -07:00
unixfd Bug 1167210: Replace |union sockaddr_any| with |struct sockaddr_storage|, r=kmachulis 2015-05-27 13:49:07 +02:00
unixsocket Bug 1185478: Remove strong references from socket I/O class to socket classes 2015-07-21 08:06:29 +02:00
moz.build Bug 1171017: Move classes from ipc/bluetooth to ipc/hal, r=shuang 2015-06-15 14:44:03 +02:00
pull-chromium.py