Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 17:55:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
3a6e26fa6a
gecko-dev/xpcom/ds
History
Nathan Froyd e7b3b3140d Bug 1415980 - make hash keys movable and not copyable; r=erahm 
Everything that goes in a PLDHashtable (and its derivatives, like
nsTHashtable) needs to inherit from PLDHashEntryHdr. But through a lack
of enforcement, copy constructors for these derived classes didn't
explicitly invoke the copy constructor for PLDHashEntryHdr (and the
compiler didn't invoke the copy constructor for us). Instead,
PLDHashTable explicitly copied around the bits that the copy constructor
would have.

The current setup has two problems:

1) Derived classes should be using move construction, not copy
   construction, since anything that's shuffling hash table keys/entries
   around will be using move construction.

2) Derived classes should take responsibility for transferring bits of
   superclass state around, and not rely on something else to handle that.

The second point is not a huge problem for PLDHashTable (PLDHashTable
only has to copy PLDHashEntryHdr's bits in a single place), but future
hash table implementations that might move entries around more
aggressively would have to insert compensation code all over the
place. Additionally, if moving entries is implemented via memcpy (which
is quite common), PLDHashTable copying around bits *again* is
inefficient.

Let's fix all these problems in one go, by:

1) Explicitly declaring the set of constructors that PLDHashEntryHdr
   implements (and does not implement). In particular, the copy
   constructor is deleted, so any derived classes that attempt to make
   themselves copyable will be detected at compile time: the compiler
   will complain that the superclass type is not copyable.

This change on its own will result in many compiler errors, so...

2) Change any derived classes to implement move constructors instead of
   copy constructors. Note that some of these move constructors are,
   strictly speaking, unnecessary, since the relevant classes are moved
   via memcpy in nsTHashtable and its derivatives.
2018-09-20 11:20:36 -04:00
..
tools Bug 1474739 - Part 3: Linting fixes on a CLOSED TREE, a=bustage 2018-08-01 18:23:21 -04:00
ArenaAllocator.h Bug 1406727 - Improve diagnostics in BuildDisplayList. r=froydnj 2018-02-06 12:21:31 +13:00
ArenaAllocatorExtensions.h Bug 1412416 - Part 2: Simplify ArenaStrdup for xpcom strings. r=froydnj 2017-10-27 13:26:47 -07:00
ArrayIterator.h
Atom.py Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio 2018-08-15 15:52:42 +10:00
AtomArray.h Bug 1407843 part 1 - Introduce a global-level AtomArray type alias. r=froydnj 2017-10-13 11:59:23 +11:00
Dafsa.cpp
Dafsa.h
HTMLAtoms.py Bug 1482782 - Part 1: Generate nsGkAtomList.h from a Python file. r=njn,hsivonen 2018-08-15 15:46:00 +10:00
IncrementalTokenizer.cpp Bug 1492204 - Part 3: Remove references to char_iterator. r=froydnj 2018-09-18 12:05:23 -07:00
IncrementalTokenizer.h Bug 1463786 - Make mozilla::Tokenizer work also with char16_t, r=froydnj 2018-05-31 03:40:00 +03:00
moz.build Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj 2018-09-18 00:58:52 -04:00
MruCache.h Bug 1491151 - Part 1: Add MruCache. r=smaug,froydnj 2018-09-10 14:45:55 -07:00
nsArray.cpp Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsArray.h
nsArrayEnumerator.cpp Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsArrayEnumerator.h Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsArrayUtils.cpp
nsArrayUtils.h
nsAtom.h Bug 1488697 - Make StringBuilder::ToString avoid repeated capacity and aliasing checks as well as terminator writes. r=smaug 2018-09-08 07:47:28 +00:00
nsAtomTable.cpp Bug 1491151 - Part 4: Convert atom table to use MRU cache. r=smaug 2018-09-12 17:51:53 -07:00
nsAtomTable.h Bug 1447951 - Store nsDynamicAtom's chars after the end of the object. r=froydnj 2018-06-22 09:38:42 +10:00
nsBaseHashtable.h Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
nsCharSeparatedTokenizer.h
nsCheapSets.h Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj 2018-06-17 22:43:11 -07:00
nsClassHashtable.h Bug 1466168: Remove mozilla::Forward in favor of std::forward. r=froydnj 2018-06-02 09:33:26 +02:00
nsCOMArray.cpp Bug 1407838 - Remove the remains of NS_Alloc/NS_Realloc/NS_Free. r=njn 2017-10-12 11:08:44 +09:00
nsCOMArray.h Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
nsCRT.cpp Bug 1427025 - Remove nsCRT::memmem. r=froydnj 2018-04-10 04:47:52 +10:00
nsCRT.h Bug 1453456 - Replace nsCRT::IsAscii{Alpha,Digit} with mfbt/TextUtils.h versions. r=froydnj 2018-04-12 20:19:30 -07:00
nsDataHashtable.h Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
nsDeque.cpp
nsDeque.h
nsEnumeratorUtils.cpp Bug 1486147: Part 1 - Add JS iterator support to nsIStringEnumerator. r=mccr8 2018-08-24 16:21:33 -07:00
nsEnumeratorUtils.h
nsExpirationTracker.h Bug 1453795 - XPCOM - Initialize member fields in classes/ structures. r=froydnj 2018-06-15 14:41:20 +03:00
nsGkAtoms.cpp Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio 2018-08-15 15:52:42 +10:00
nsGkAtoms.h Bug 1483121 - Generate static atom hash in StaticAtoms.py. r=njn,emilio 2018-08-15 15:52:42 +10:00
nsHashKeys.h Bug 1415980 - make hash keys movable and not copyable; r=erahm 2018-09-20 11:20:36 -04:00
nsHashPropertyBag.cpp Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsHashPropertyBag.h
nsIArray.idl Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsIArrayExtensions.idl Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsIHashable.idl
nsIINIParser.idl Bug 1484844: Make nsINIParser mutable. r=froydnj 2017-10-12 14:20:57 -07:00
nsIMutableArray.idl Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsINIParserImpl.cpp Bug 1484844: Make nsINIParser mutable. r=froydnj 2017-10-12 14:20:57 -07:00
nsINIParserImpl.h
nsInterfaceHashtable.h Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
nsIObserver.idl
nsIObserverService.idl
nsIPersistentProperties2.idl Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj 2018-09-18 00:58:52 -04:00
nsIPersistentProperties.h
nsIProperties.idl
nsIProperty.idl
nsIPropertyBag2.idl
nsIPropertyBag.idl
nsISerializable.idl Bug 1440808 - Cleanup error handling in nsXULPrototypeDocument::Read. r=mccr8 2018-02-22 11:33:20 -08:00
nsISimpleEnumerator.idl Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsIStringEnumerator.idl Bug 1486147: Part 1 - Add JS iterator support to nsIStringEnumerator. r=mccr8 2018-08-24 16:21:33 -07:00
nsISupportsIterators.idl
nsISupportsPrimitives.idl
nsIVariant.idl Bug 1474369 - Part 7: Rename [array] to LegacyArray within xpt and xpidl, r=mccr8 2018-07-31 17:53:03 -04:00
nsIWindowsRegKey.idl
nsIWritablePropertyBag2.idl
nsIWritablePropertyBag.idl
nsJSThingHashtable.h
nsMathUtils.h
nsObserverList.cpp Bug 1484496: Part 3 - Fix nsISimpleEnumerator implementations with broken contracts. r=froydnj 2018-08-18 18:28:10 -07:00
nsObserverList.h Bug 1415980 - make hash keys movable and not copyable; r=erahm 2018-09-20 11:20:36 -04:00
nsObserverService.cpp Bug 1464252 - Remove global observers functionality from the observer service; r=froydnj 2018-05-24 23:58:31 +02:00
nsObserverService.h
nsPersistentProperties.cpp Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj 2018-09-18 00:58:52 -04:00
nsPersistentProperties.h Bug 1491574 - Part 2: Remove the XPCOM registration for nsPersistentProperties; r=froydnj 2018-09-18 00:58:52 -04:00
nsPointerHashKeys.h Bug 1415980 - make hash keys movable and not copyable; r=erahm 2018-09-20 11:20:36 -04:00
nsProperties.cpp
nsProperties.h Bug 1491574 - Part 1: Remove the XPCOM registration for nsProperties; r=froydnj 2018-09-18 00:33:59 -04:00
nsQuickSort.cpp
nsQuickSort.h
nsRefPtrHashtable.h Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
nsSimpleEnumerator.cpp Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsSimpleEnumerator.h Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj 2018-08-18 21:06:32 -07:00
nsStaticAtomUtils.h Bug 1483449 - Simplify nsStaticAtomUtils::Lookup. r=njn 2018-08-16 11:40:02 +10:00
nsStaticNameTable.cpp Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r=Ehsan 2018-07-13 19:01:53 +09:00
nsStaticNameTable.h Bug 1475461 - part 2: Make callers of PLDHashTable::Search() const methods if possible r=Ehsan 2018-07-13 19:01:53 +09:00
nsStringEnumerator.cpp Bug 1486147: Follow-up: Fix missing QueryInterface entries. r=bustage 2018-09-19 17:34:10 -07:00
nsStringEnumerator.h Bug 1486147: Part 1 - Add JS iterator support to nsIStringEnumerator. r=mccr8 2018-08-24 16:21:33 -07:00
nsSupportsPrimitives.cpp Bug 1409227 (part 4) - Replace nsMemory::Clone(id, sizeof(nsID)) with nsID::Clone(id). r=mccr8. 2017-10-18 10:39:20 +11:00
nsSupportsPrimitives.h
nsTArray-inl.h Bug 1473804: Don't lie to AutoTArray::EnsureCapacity. r=erahm 2018-07-17 10:23:47 +02:00
nsTArray.cpp Bug 1460733 - Rename nsTArrayHeader::sEmptyHdr to extern "C" { sEmptyTArrayHeader } so that thin-vec can link with it. r=froydnj 2018-05-10 16:37:27 -04:00
nsTArray.h Bug 1479996 - Combine nsTArray::IndexOf and element access into lambda-friendly functions - r=froydnj 2018-08-28 22:04:09 +00:00
nsTArrayForwardDeclare.h
nsTHashtable.h Bug 1477626 - Document some differences between mozilla::HashTable and PLDHashTable. r=Waldo 2018-07-26 20:15:55 +10:00
nsTObserverArray.cpp Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
nsTObserverArray.h
nsTPriorityQueue.h
nsVariant.cpp Bug 1486690 - Rename nsMemory::Clone() and remove unnecessary checks after it. r=glandium 2018-08-28 15:59:19 +10:00
nsVariant.h Bug 1453795 - XPCOM - Initialize member fields in classes/ structures. r=froydnj 2018-06-15 14:41:20 +03:00
nsWhitespaceTokenizer.h
nsWindowsRegKey.cpp Bug 1492204 - Part 1: Stop using deprecated string writing iterators. r=froydnj 2018-09-18 09:44:57 -07:00
nsWindowsRegKey.h
Observer.h Bug 1469914 - Prevent the HAL from registering duplicate observers; r=froydnj 2018-06-22 00:35:08 +02:00
PLDHashTable.cpp Bug 1477626 - Move ScrambleHashCode() from js/src/Utility.h to mfbt/HashFunctions.h. r=Waldo 2018-07-26 18:52:47 +10:00
PLDHashTable.h Bug 1415980 - make hash keys movable and not copyable; r=erahm 2018-09-20 11:20:36 -04:00
SimpleEnumerator.h Bug 1484373: Follow-up: Fix missed review comment. r=froydnj (implied) 2018-08-24 22:31:10 -07:00
StaticAtoms.py Bug 1472026 - Implement PaymentResponse.prototype.onpayerdetailchange. r=edenchuang,baku 2018-09-19 11:23:33 +00:00
StickyTimeDuration.h
Tokenizer.cpp Bug 1463786 - Make mozilla::Tokenizer work also with char16_t, r=froydnj 2018-05-31 03:40:00 +03:00
Tokenizer.h Bug 1463786 - Make mozilla::Tokenizer work also with char16_t, r=froydnj 2018-05-31 03:40:00 +03:00