Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Go to file
Julian Descottes 3ad6fe2ca8 Bug 1676974 - [devtools] Remove unused protocol/utils.js method() helper r=ochameau
Current implementation
```lang=javascript
exports.method = function(fn, spec = {}) {
  fn._methodSpec = Object.freeze(spec);
  if (spec.request) {
    Object.freeze(spec.request);
  }
  if (spec.response) {
    Object.freeze(spec.response);
  }
  return fn;
};
```
https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/devtools/shared/protocol/utils.js#70-79

The helper method() in protocol/utils.js is only called from two methods:
- actorBridge (never used in the codebase)
- actorBridgeWithSpec (used by a few actors)

actorBridgeWithSpec doesn't pass the second argument, so in practice, this method could be reduced to:
```lang=javascript
exports.method = function(fn) {
  fn._methodSpec = Object.freeze({});
  return fn;
};
```

`_methodSpec` is only mentioned in one other spot: https://searchfox.org/mozilla-central/rev/5a1a34953a26117f3be1a00db20c8bbdc03273d6/devtools/shared/protocol/Actor/generateActorSpec.js#27-40

But based on our coverage tooling, we never actually have a `_methodSpec` when we run this code: https://coverage.moz.tools/#view=file&revision=latest&path=devtools/shared/protocol/Actor/generateActorSpec.js

To hit it, we would have to call `generateActorSpec` directly with an actor where we used `actorBridgeWithSpec`. But we never do that, we only use it with plain JS objects in the devtools/shared/specs folder.

Consequently, this helper can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D96935
2020-11-13 09:49:53 +00:00
.cargo Bug 1675719 - P2: mach vendor rust r=cubeb-reviewers,kinetik 2020-11-10 20:00:22 +00:00
.vscode
accessible Backed out 4 changesets (bug 1198336) for bustage on rules.mk. CLOSED TREE 2020-11-13 11:06:12 +02:00
browser Backed out changeset d86e4d6c2be4 (bug 1595858) for browser_ext_chrome_settings_overrides_home.js failures CLOSED TREE 2020-11-13 06:11:35 +02:00
build Bug 1676951: Improve "on Windows" * 2 sentence r=smacleod DONTBUILD 2020-11-12 20:39:19 +00:00
caps Bug 1673682 - Accept functors rather than a virtual function override in URLParams::Parse. r=valentin,necko-reviewers 2020-11-13 08:12:12 +00:00
chrome Bug 1673054 - Migrate uses of intl.uidirection to intl.l10n.pseudo; r=Gijs,zbraniecki 2020-11-09 15:33:39 +00:00
config Backed out 2 changesets (bug 1674773) for turning Bug 1646925 into almost permafail. 2020-11-10 11:27:50 +02:00
devtools Bug 1676974 - [devtools] Remove unused protocol/utils.js method() helper r=ochameau 2020-11-13 09:49:53 +00:00
docs Bug 1676087: Add documentation for Accessibility Review process. r=bgrins 2020-11-10 17:17:28 +00:00
docshell Bug 1676692 - Simplify browser_contentSearchUI.js and avoid the need for separate xml search engine definitions. r=daleharvey 2020-11-12 18:54:46 +00:00
dom Bug 1672072 - P13. Always shut down decoder after creation. r=mattwoodrow,bryce,padenot 2020-11-13 04:21:17 +00:00
editor Bug 1627673 - Do null-check the result of DragEvent::GetDataTransfer() in EditorEventListener` r=smaug 2020-11-09 23:39:10 +00:00
extensions Bug 1676573 - Add support for named in-memory databases; r=asuth,dom-workers-and-storage-reviewers 2020-11-11 07:26:41 +00:00
gfx Bug 1676925 - Remove code supporting the defunct WebRender experiments. r=jrmuizel,marionette-reviewers 2020-11-13 05:40:10 +00:00
gradle/wrapper
hal Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
image Bug 1676988. Use GetFrame instead of Seek in AnimationState::UpdateStateInternal. r=aosmond 2020-11-13 03:25:33 +00:00
intl Backed out 3 changesets (bug 1675789) for test_pseudo.js failures CLOSED TREE 2020-11-13 04:21:54 +02:00
ipc Bug 1672072 - P10. Promisify launch of RDD process and remove sync dispatch. r=mattwoodrow,bryce,mjf,padenot 2020-11-13 04:21:16 +00:00
js Bug 1676821 - Use vector to map delazified function to function index. r=tcampbell 2020-11-13 10:01:52 +00:00
layout Backed out changeset 71d9d66a6a7f (bug 1673524) for mathml failures CLOSED TREE 2020-11-13 06:04:24 +02:00
media Backed out 4 changesets (bug 1675534) for mass test failures. CLOSED TREE 2020-11-10 11:28:32 +02:00
memory Bug 1519636 - Reformat recent changes to the Google coding style r=andi 2020-11-04 18:46:00 +00:00
mfbt Bug 1672072 - P12. Add constructor for WeakPtr(RefPtr). r=sg 2020-11-13 04:21:17 +00:00
mobile Bug 1675644 - Flush extension messages per-session and per-nativeApp. r=esawin 2020-11-11 22:46:22 +00:00
modules Backed out changeset b5cf0a593e64 (bug 1675205) for xpcshell failures on test_empty_jar_telemetry. 2020-11-13 02:36:00 +02:00
mozglue Bug 1665461: reflect the correct colors for default themes in the skeleton UI. r=dthayer 2020-11-12 23:56:44 +00:00
netwerk Bug 1673682 - Add missing include. r=fix. CLOSED TREE 2020-11-13 12:14:29 +02:00
nsprpub
other-licenses Bug 1461690 Part 3: HttpPostFile plugin for uploading uninstall ping via POST. r=mhowell 2020-10-20 23:20:25 +00:00
parser Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
python Bug 1676925 - Remove code supporting the defunct WebRender experiments. r=jrmuizel,marionette-reviewers 2020-11-13 05:40:10 +00:00
remote Bug 1605784 - [remote] Implement Emulation.setTouchEmulationEnabled. r=remote-protocol-reviewers,jdescottes 2020-11-11 19:22:46 +00:00
security No bug - Fix typo to trigger mochitest jobs. 2020-11-12 21:18:08 +02:00
services Bug 1649621, remove OS.File usages from FxAccountsStorage.jsm r=Gijs 2020-11-12 16:38:03 +00:00
servo Bug 1676062 - Use a dummy URL data in Servo_ParseEasing and drop Document* and URLExtraData* arguments from relevant functions. r=boris 2020-11-12 20:34:01 +00:00
startupcache Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
storage Bug 1673682 - Accept functors rather than a virtual function override in URLParams::Parse. r=valentin,necko-reviewers 2020-11-13 08:12:12 +00:00
taskcluster Bug 1676925 - Remove code supporting the defunct WebRender experiments. r=jrmuizel,marionette-reviewers 2020-11-13 05:40:10 +00:00
testing Bug 1676925 - Remove code supporting the defunct WebRender experiments. r=jrmuizel,marionette-reviewers 2020-11-13 05:40:10 +00:00
third_party Backed out 3 changesets (bug 1675789) for test_pseudo.js failures CLOSED TREE 2020-11-13 04:21:54 +02:00
toolkit Bug 1673682 - Accept functors rather than a virtual function override in URLParams::Parse. r=valentin,necko-reviewers 2020-11-13 08:12:12 +00:00
tools Bug 1676502 - part1 : move remaining sound indicator browser tests to 'browser/base/content/test/tabMediaIndicator/'. r=bryce 2020-11-13 00:30:18 +00:00
uriloader Bug 1652520 - do not overwrite extensions for all filetypes, r=mak 2020-11-10 13:59:39 +00:00
view Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
widget Bug 1676936 - Enable WebRender on Kaveri in nightly/early beta. r=aosmond 2020-11-12 20:01:51 +00:00
xpcom Backed out 4 changesets (bug 1198336) for bustage on rules.mk. CLOSED TREE 2020-11-13 11:06:12 +02:00
xpfe/appshell Bug 1670957, add placeholder rectangles for toolbarbuttons and display in skeleton UI r=dthayer,smaug,Gijs 2020-11-10 16:48:10 +00:00
.arcconfig
.babel-eslint.rc.js
.clang-format
.clang-format-ignore Bug 1667674 - [Wayland] Support public primary-selection unstable protocol. r=stransky 2020-10-02 09:13:06 +00:00
.cron.yml
.eslintignore Bug 1669956 - [devtools] Enable eslint for devtools/client/shared/components/reps. r=jdescottes. 2020-10-14 11:33:16 +00:00
.eslintrc.js Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
.flake8 Bug 1673700 - Don't use double quotes around strings in definition of fork_interpose r=firefox-build-system-reviewers,glandium 2020-10-29 15:47:14 +00:00
.git-blame-ignore-revs Bug 1637889 - Add commits from bug 1488698 and its blockers to the list of commits to ignore for blame. r=sylvestre 2020-11-12 11:47:20 +00:00
.gitattributes
.gitignore Backed out 4 changesets (bug 1666347, bug 1667152, bug 1661624, bug 1666345) for causing mingw bustage. CLOSED TREE 2020-11-12 19:55:58 +02:00
.hg-annotate-ignore-revs Bug 1637889 - Add commits from bug 1488698 and its blockers to the list of commits to ignore for blame. r=sylvestre 2020-11-12 11:47:20 +00:00
.hg-format-source
.hgignore Backed out 4 changesets (bug 1666347, bug 1667152, bug 1661624, bug 1666345) for causing mingw bustage. CLOSED TREE 2020-11-12 19:55:58 +02:00
.hgtags No bug - tagging 6d98cc745df58e544a8d71c131f060fc2c460d83 with FIREFOX_NIGHTLY_83_END a=release DONTBUILD CLOSED TREE 2020-10-19 16:38:59 +00:00
.lldbinit
.mailmap
.prettierignore
.prettierrc
.taskcluster.yml Bug 1666809 - Insert decision task indexes directly via taskluster API rather than index-task, r=taskgraph-reviewers,aki 2020-09-24 19:19:36 +00:00
.trackerignore
.yamllint
.ycm_extra_conf.py Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
aclocal.m4
AUTHORS
build.gradle Bug 1671460 - Update to apilint 0.4.0. r=snorp 2020-11-02 19:42:25 +00:00
Cargo.lock Backed out 3 changesets (bug 1675789) for test_pseudo.js failures CLOSED TREE 2020-11-13 04:21:54 +02:00
Cargo.toml Bug 1622846 - Serialize WebGPU descriptors via Serde for IPC r=jgilbert,webidl,smaug 2020-11-07 02:43:09 +00:00
client.mk Bug 1671424 - Move configure execution from client.mk to mach configure. r=firefox-build-system-reviewers,rstewart 2020-10-20 20:41:52 +00:00
client.py Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
CLOBBER
configure.in Bug 1671424 - Move configure execution from client.mk to mach configure. r=firefox-build-system-reviewers,rstewart 2020-10-20 20:41:52 +00:00
configure.py Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
GNUmakefile
gradle.properties Bug 1553459 - Migrate to AndroidX r=geckoview-reviewers,agi 2020-09-18 22:29:04 +00:00
gradlew
gradlew.bat
LICENSE
mach Bug 1638947 - Run 'mach android' with python 3; r=nalexander 2020-11-09 17:54:33 +00:00
Makefile.in Bug 1675086 - drop reference to 'pgo' from Windows AArch EME artifact build. r=nalexander 2020-11-03 22:46:57 +00:00
moz.build Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
moz.configure Bug 1654103: Standardize on Black for Python code in mozilla-central. 2020-10-26 18:34:53 +00:00
mozilla-config.h.in
old-configure.in Bug 1654109 - Use PDB basename in cross-compiled Windows builds r=firefox-build-system-reviewers,mhentges 2020-11-11 02:34:44 +00:00
package-lock.json Bug 1668274 - update eslint, eslint-plugin-no-unsanitized and mocha to allow use of logical assignment operators, r=Standard8 2020-10-02 18:00:40 +00:00
package.json Bug 1668274 - update eslint, eslint-plugin-no-unsanitized and mocha to allow use of logical assignment operators, r=Standard8 2020-10-02 18:00:40 +00:00
README.txt
settings.gradle
substitute-local-geckoview.gradle
test.mozbuild

An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://firefox-source-docs.mozilla.org/contributing/directory_structure.html

For information on how to build Firefox from the source code and create the patch see:

    https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.


Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.