mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-26 03:35:33 +00:00
525200b457
When we receive animations on the compositor, we assert that either they're not playing, or they have a resolved start and origin time. However, on the main thread we determine if an animation is playing by checking if it has a timeline, if it's in the correct state, and if it has a non-zero playback rate. The problem with this check is that if an animation has a timeline but it is inactive, that is, its current time is null, we will not be able to get a resolved origin time -- yet we will still report that is is playing. This patch fixes this mismatch by treating animations with an inactive timeline as "not playing". The IsPlaying() method is used a number of call sites but it appears that they all would expect an animation with an inactive timeline to be considered "not playing". Furthermore, this makes IsPlaying() consistent with the check we do for an active timeline in other functions such as Animation::Tick(), TriggerNow(), SilentlySetCurrentTime(), UpdateFinishedState(), and IsPossibleOrphanedPendingAnimation(). MozReview-Commit-ID: BQOBpHHFMoD --HG-- extra : rebase_source : e84a50a16a61d48553610cb7ea0863f09ba86c60 |
||
|---|---|---|
| .. | ||
| 1216842-1.html | ||
| 1216842-2.html | ||
| 1216842-3.html | ||
| 1216842-4.html | ||
| 1216842-5.html | ||
| 1216842-6.html | ||
| 1239889-1.html | ||
| 1244595-1.html | ||
| 1272475-1.html | ||
| 1272475-2.html | ||
| 1277272-1-inner.html | ||
| 1277272-1.html | ||
| 1278485-1.html | ||
| 1282691-1.html | ||
| 1291413-1.html | ||
| 1291413-2.html | ||
| 1304886-1.html | ||
| 1322291-1.html | ||
| 1322291-2.html | ||
| 1322382-1.html | ||
| 1323114-1.html | ||
| 1323114-2.html | ||
| 1324554-1.html | ||
| 1325193-1.html | ||
| 1330190-1.html | ||
| 1330190-2.html | ||
| 1330513-1.html | ||
| 1333539-1.html | ||
| 1333539-2.html | ||
| 1334582-1.html | ||
| 1334582-2.html | ||
| 1334583-1.html | ||
| 1335998-1.html | ||
| 1343589-1.html | ||
| 1359658-1.html | ||
| 1373712-1.html | ||
| 1379606-1.html | ||
| 1393605-1.html | ||
| 1400022-1.html | ||
| 1401809.html | ||
| 1411318-1.html | ||
| crashtests.list | ||