mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-23 21:01:08 +00:00
3d859095f0
Only the bookmarks menu button is doing this peculiar re-using of options. I tried various fixes: keeping the inheritance but replacing only the rootElt/viewElt (and using Object.assign to clone the options so modifications don't 'transmit' to the ancestor menus) but it was messy and net code increase for a pretty crufty UI surface. I also wasn't sure if that would end up negatively influencing (now or in the future) e.g. menus shown from the main bookmarks toolbar view (which would show up as a 'parent' view for the menus we open from there), and thought that reusing the options was likely to cause further confusion in future as well, should we add more, uh, options, to them. So in the end I stuck with Keeping It Simple - I just repeat the one-off repeating entry class. I'm not even sure how needed this is - in particular, I wonder why we don't need it for other submenus for 'real' bookmark folders! But I didn't investigate this too much. If you're sure that we can get rid of some more of it, happy to do that in a followup. Note that the addition of _init() was not ultimmately needed to fix this bug (I think), but it brought the initialization sequence and when we set `_placesView` more in line with what we did before and what I already did for `PlacesToolbar`, so that seemed like a good thing to avoid further/other issues. Differential Revision: https://phabricator.services.mozilla.com/D164756 |
||
|---|---|---|
| .. | ||
| actors | ||
| app | ||
| base | ||
| branding | ||
| components | ||
| config | ||
| docs | ||
| extensions | ||
| fonts | ||
| fxr | ||
| installer | ||
| locales | ||
| locales-preview | ||
| modules | ||
| themes | ||
| tools/mozscreenshots | ||
| .eslintrc.js | ||
| app.mozbuild | ||
| build.mk | ||
| confvars.sh | ||
| defs.mk | ||
| l10n-registry.manifest | ||
| LICENSE | ||
| Makefile.in | ||
| moz.build | ||
| moz.configure | ||