mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-11-25 13:51:41 +00:00
886c2c65a8
Currently, the gamepad code uses a uint32_t as a handle and does some trickery with it by trying to create a unique ID and adding an offset to it for VR code. This can (and has) led to errors where the developer forgets to perform the arithmetic and sends the wrong number to the wrong manager. This change created a strongly-typed handle that remembers which service it belongs to. This should eliminate such accidents. Differential Revision: https://phabricator.services.mozilla.com/D96273
56 lines
1.7 KiB
C++
56 lines
1.7 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef mozilla_dom_gamepad_GamepadLightIndicator_h
|
|
#define mozilla_dom_gamepad_GamepadLightIndicator_h
|
|
|
|
#include "mozilla/dom/GamepadLightIndicatorBinding.h"
|
|
#include "mozilla/dom/GamepadHandle.h"
|
|
#include "nsWrapperCache.h"
|
|
|
|
namespace mozilla {
|
|
namespace dom {
|
|
|
|
class GamepadLightIndicator final : public nsISupports, public nsWrapperCache {
|
|
public:
|
|
GamepadLightIndicator(nsISupports* aParent, GamepadHandle aGamepadHandle,
|
|
uint32_t aIndex);
|
|
|
|
NS_DECL_CYCLE_COLLECTING_ISUPPORTS
|
|
NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(GamepadLightIndicator)
|
|
|
|
static GamepadLightIndicatorType DefaultType() {
|
|
return GamepadLightIndicatorType::Rgb;
|
|
}
|
|
|
|
nsISupports* GetParentObject() const;
|
|
|
|
virtual JSObject* WrapObject(JSContext* aCx,
|
|
JS::Handle<JSObject*> aGivenProto) override;
|
|
|
|
already_AddRefed<Promise> SetColor(const GamepadLightColor& color,
|
|
ErrorResult& aRv);
|
|
|
|
void SetType(GamepadLightIndicatorType aType) { mType = aType; }
|
|
|
|
GamepadLightIndicatorType Type() const;
|
|
|
|
void Set(const GamepadLightIndicator* aOther);
|
|
|
|
private:
|
|
virtual ~GamepadLightIndicator();
|
|
|
|
nsCOMPtr<nsISupports> mParent;
|
|
GamepadLightIndicatorType mType;
|
|
GamepadHandle mGamepadHandle;
|
|
uint32_t mIndex;
|
|
};
|
|
|
|
} // namespace dom
|
|
} // namespace mozilla
|
|
|
|
#endif // mozilla_dom_gamepad_GamepadLightIndicator_h
|