mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-08 02:14:43 +00:00
3e9924d513
Previously, the screenOrientation.lock API was for Fennec and not supported for Fenix and multi-process use. The overall idea is to now allow apps to use the API through a delegate and make asynchronous calls to LockDeviceOrientation. This required replacing the existing code that returned a default false bool to calls that perform the requested orientation change and instead return a promise that contained either an allow or deny value. Returning a promise instead of a bool involved changing the API calls from the C++ side to Java. The new general control flow of screenOrientation lock follows: an app calls C++ ScreenOrientation.lock() which eventually dispatches LockOrientationTask to resolve the pending orientation promise. Hal.cpp sends an IPC call to the content process and RecvLockScreenOrientation retrieves the current instance of geckoRuntime and calls the java side LockScreenOrientation. Apps must create a delegate and override onOrientationLock to set the requested orientation. In geckoview's testing, this is done with the android API setRequestedOrientation. Once a device orientation change has been triggered, native OnOrientationChange calls to NotifyScreenConfigurationChange, which notifies all observers and dispatches a change event to resolve the pending orientation promise. Testing: I used a demo on the GeckoView Example (https://usefulangle.com/demos/105/screen.html) to test locking to landscape orientation. This required a change to the GVE to show the app from recreating the whole thing on orientation change. In the example AndroidManifest xml file, `orientation` prevents restart when orientation changes. The Junit/Kotlin tests were to verify that the expected orientation delegate was called with the expected new orientation value, in an orientation change, if the new orientation was the same as the current, and if the pre-lock conditions such as being fullscreen were not met. A static preference `dom.screenorientation.allow-lock` was added to the dom group, since it affects the ui dom) and is currently turned off. C++ can access it through its mirrored variable dom_screenorientation_allow_lock (same name but with underscores). The junit tests turn the preference on and test the lock feature. Reference: Orientation constant values: C++ 1 ScreenOrientation_PortraitPrimary); - vertical with button at bottom 2 ScreenOrientation_PortraitSecondary); - vertical with button at top 4 ScreenOrientation_LandscapePrimary); - horizational w button right 8 ScreenOrientation_LandscapeSecondary); - horization button left 16 ScreenOrientation_Default); Java 1 GeckoScreenOrientation.ScreenOrientation.PORTRAIT_PRIMARY.value 2 GeckoScreenOrientation.ScreenOrientation.PORTRAIT_SECONDARY.value 4 GeckoScreenOrientation.ScreenOrientation.LANDSCAPE_PRIMARY.value 8 GeckoScreenOrientation.ScreenOrientation.LANDSCAPE_SECONDARY.value Java public API 0 ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE 1 Activitynfo.SCREEN_ORIENTATION_PORTRAIT Android 1 ORIENTATION_PORTRAIT 2 ORIENTATION_LANDSCAPE Differential Revision: https://phabricator.services.mozilla.com/D129427 |
||
|---|---|---|
| .. | ||
| brotli | ||
| fdlibm | ||
| freetype2 | ||
| libjar | ||
| libmar | ||
| libpref | ||
| woff2 | ||
| xz-embedded | ||
| zlib | ||
| moz.build | ||