gecko-dev/dom/quota
Chris Pearce 4a6ff21ab5 Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian
While showing a doorhanger permisison prompt, if the user presses the ESC key
we call the secondary action callback, passing in whether any checkbox on
the popup notification was checked.

In the case of an autoplay-media permission prompt, we have a "remember"
checkbox, which is checked by default. So pressing ESC means the user will
remember a "block" result for the current site.

We believe that users don't expect pressing ESC to result in a remembered
decision, they expect pressing ESC to avoid making a decision. So we want to
ignore the checkbox when ESC is pressed for autoplay-media.

So this patch adds a new PopupNotification behaviour which reports the source
of event which caused the action callback to be called. This enables the ESC
key press to ignore storing a permission.

Note: the change here to not store a permission on ESC press applies to all
permissions, not just autoplay-media.


MozReview-Commit-ID: IUWFN8LG9VF

--HG--
extra : rebase_source : b004bc211177a7bfb6dcea563d75db9a6750b214
2018-07-17 14:45:17 +12:00
..
test Bug 1473671 - Don't store persistent block permission if ESC pressed while showing permission doorhanger. r=florian 2018-07-17 14:45:17 +12:00
ActorsChild.cpp
ActorsChild.h
ActorsParent.cpp Bug 1473453 - Part 2: QuotaManager: disambiguate null check of bool pointer. r=janv 2018-07-04 14:46:51 -07:00
ActorsParent.h
Client.h Bug 1470811 - Update FF 62 to know about upcoming new quota client; r=asuth 2018-06-29 09:58:09 +02:00
FileStreams.cpp
FileStreams.h
moz.build
nsIQuotaCallbacks.idl
nsIQuotaManagerService.idl
nsIQuotaRequests.idl
nsIQuotaResults.idl
OriginScope.h
PersistenceType.h
PQuota.ipdl
PQuotaRequest.ipdl
PQuotaUsageRequest.ipdl
QuotaCommon.h
QuotaManager.h Bug 1470811 - Update FF 62 to know about upcoming new quota client; r=asuth 2018-06-29 09:58:09 +02:00
QuotaManagerService.cpp
QuotaManagerService.h
QuotaObject.h
QuotaRequests.cpp
QuotaRequests.h
QuotaResults.cpp
QuotaResults.h
SerializationHelpers.h
StorageManager.cpp Bug 1471189 - Removing 'Terminating' state in workers, r=mrbkap 2018-07-12 19:33:41 +02:00
StorageManager.h
UsageInfo.h