mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-25 03:05:34 +00:00
084c9b6f4c
This changes the lifecycle and API for TextureReadLock to fix file descriptor exhaustion
crashes. These changes are partially superficial and mostly align the API of TextureReadLocks
with their actual usage.
The changes are:
1. Create the TextureReadLock in the TextureClient constructor so it's available before IPC creation
a. This is superficial as EnableReadLock was always called before IPC creation
2. Send the ReadLockDescriptor in the PTextureConstructor message and close the file handle
3. Receive the ReadLockDescriptor in TextureHost and close the file handle
4. Send a boolean flag in layer transactions if the texture is read locked instead of a descriptor
5. Use a boolean flag in TextureHost to determine if the ReadLock must be unlocked instead of a nullptr
I believe that we can remove the InitReadLocks code from LayerTransaction as that was added to
prevent file descriptor limits in IPDL messages and is no longer needed with this change. But
that is a non-essential change and this patch is already big enough.
MozReview-Commit-ID: DzHujrOQejH
--HG--
extra : rebase_source : 3bdd7c9bc8edfdc386faad8a9e59ad7dc18ed91d
94 lines
2.5 KiB
C++
94 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include <windows.h>
|
|
|
|
#include "base/process_util.h"
|
|
#include "CrossProcessSemaphore.h"
|
|
#include "nsDebug.h"
|
|
#include "nsISupportsImpl.h"
|
|
#include "ProtocolUtils.h"
|
|
|
|
using base::GetCurrentProcessHandle;
|
|
using base::ProcessHandle;
|
|
|
|
namespace mozilla {
|
|
|
|
/* static */ CrossProcessSemaphore*
|
|
CrossProcessSemaphore::Create(const char*, uint32_t aInitialValue)
|
|
{
|
|
// We explicitly share this using DuplicateHandle, we do -not- want this to
|
|
// be inherited by child processes by default! So no security attributes are
|
|
// given.
|
|
HANDLE semaphore = ::CreateSemaphoreA(nullptr, aInitialValue, 0x7fffffff, nullptr);
|
|
if (!semaphore) {
|
|
return nullptr;
|
|
}
|
|
return new CrossProcessSemaphore(semaphore);
|
|
}
|
|
|
|
/* static */ CrossProcessSemaphore*
|
|
CrossProcessSemaphore::Create(CrossProcessSemaphoreHandle aHandle)
|
|
{
|
|
DWORD flags;
|
|
if (!::GetHandleInformation(aHandle, &flags)) {
|
|
return nullptr;
|
|
}
|
|
|
|
return new CrossProcessSemaphore(aHandle);
|
|
}
|
|
|
|
CrossProcessSemaphore::CrossProcessSemaphore(HANDLE aSemaphore)
|
|
: mSemaphore(aSemaphore)
|
|
{
|
|
MOZ_COUNT_CTOR(CrossProcessSemaphore);
|
|
}
|
|
|
|
CrossProcessSemaphore::~CrossProcessSemaphore()
|
|
{
|
|
MOZ_ASSERT(mSemaphore, "Improper construction of semaphore or double free.");
|
|
::CloseHandle(mSemaphore);
|
|
MOZ_COUNT_DTOR(CrossProcessSemaphore);
|
|
}
|
|
|
|
bool
|
|
CrossProcessSemaphore::Wait(const Maybe<TimeDuration>& aWaitTime)
|
|
{
|
|
MOZ_ASSERT(mSemaphore, "Improper construction of semaphore.");
|
|
HRESULT hr = ::WaitForSingleObject(mSemaphore, aWaitTime.isSome() ?
|
|
aWaitTime->ToMilliseconds() :
|
|
INFINITE);
|
|
return hr == WAIT_OBJECT_0;
|
|
}
|
|
|
|
void
|
|
CrossProcessSemaphore::Signal()
|
|
{
|
|
MOZ_ASSERT(mSemaphore, "Improper construction of semaphore.");
|
|
::ReleaseSemaphore(mSemaphore, 1, nullptr);
|
|
}
|
|
|
|
CrossProcessSemaphoreHandle
|
|
CrossProcessSemaphore::ShareToProcess(base::ProcessId aTargetPid)
|
|
{
|
|
HANDLE newHandle;
|
|
bool succeeded = ipc::DuplicateHandle(mSemaphore, aTargetPid, &newHandle,
|
|
0, DUPLICATE_SAME_ACCESS);
|
|
|
|
if (!succeeded) {
|
|
return nullptr;
|
|
}
|
|
|
|
return newHandle;
|
|
}
|
|
|
|
void
|
|
CrossProcessSemaphore::CloseHandle()
|
|
{
|
|
}
|
|
|
|
}
|