mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-23 18:26:15 +00:00
408d24da56
This patch replaces four functions of the name AssignWithConversion which are essentially wrappers around CopyASCIItoUTF16 and LossyCopyUTF16toASCII with direct calls to the latter two functions. The replaced functions are: void nsCString::AssignWithConversion( const nsAString& aData ) void nsString::AssignWithConversion( const nsACString& aData ) void nsTString_CharT::AssignWithConversion( const incompatible_char_type* aData, int32_t aLength = -1); The last of the three exists inside the double-included nsTString* world and so describes two functions, giving four in total. This has two advantages: * it removes code * at the call points, it makes clear (from the replacement name) which conversion is being carried out. The generic name "AssignWithConversion" doesn't make that obvious -- one had to infer it from the types. The patch also removes two commented out lines from editor/composer/nsComposerCommands.cpp, that appear to be related. They are at top level, where they would never have compiled. They look like leftovers from some previous change. --HG-- extra : rebase_source : fb47bf450771c3c9ee3341dd14520f5da69ec4f5 |
||
---|---|---|
.. | ||
crashtests | ||
templates | ||
test | ||
moz.build | ||
nsForwardReference.h | ||
nsIController.idl | ||
nsIControllers.idl | ||
nsIXULDocument.h | ||
nsIXULOverlayProvider.idl | ||
nsXULCommandDispatcher.cpp | ||
nsXULCommandDispatcher.h | ||
nsXULContentSink.cpp | ||
nsXULContentSink.h | ||
nsXULControllers.cpp | ||
nsXULControllers.h | ||
nsXULElement.cpp | ||
nsXULElement.h | ||
nsXULPopupListener.cpp | ||
nsXULPopupListener.h | ||
nsXULPrototypeCache.cpp | ||
nsXULPrototypeCache.h | ||
nsXULPrototypeDocument.cpp | ||
nsXULPrototypeDocument.h | ||
XULDocument.cpp | ||
XULDocument.h |