mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-27 04:38:02 +00:00
41458369b2
This patch moves where we perform the final KillClearOnShutdown to occur after we've shut down non-main threads, but before the main thread stops accepting events. This should help ensure that unsuspecting events, including those triggered from nsIThreadShutdownTask tasks, don't run after KillClearOnShutdown has been run on background or main threads. This KillClearOnShutdown was moved to occur before nsThreadManager::Shutdown() in bug 1637890, as there were examples of KillClearOnShutdown callbacks which needed to be able to dispatch main-thread runnables. This change should not regress that use-case, as we are still accepting new events on the main thread after the callback. Non-main threads were already unreliable after this call as we already block normal dispatches by setting gXPCOMThreadsShutdown, and new threads cannot be started for the background thread pool. Differential Revision: https://phabricator.services.mozilla.com/D144591
An explanation of the Firefox Source Code Directory Structure and links to
project pages with documentation can be found at:
https://firefox-source-docs.mozilla.org/contributing/directory_structure.html
For information on how to build Firefox from the source code and create the patch see:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
If you have a question about developing Firefox, and can't find the solution
on https://firefox-source-docs.mozilla.org/, you can try asking your question on Matrix at chat.mozilla.org in `Introduction` (https://chat.mozilla.org/#/room/#introduction:mozilla.org) channel.
Nightly development builds can be downloaded from:
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
- or -
https://www.mozilla.org/firefox/channel/desktop/#nightly
Keep in mind that nightly builds, which are used by Firefox developers for
testing, may be buggy.