gecko-dev/security/manager/pki
Nicholas Nethercote c86dc10505 Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk.
Most of the names passed to nsIStringBundle::{Get,Format}StringFromUTF8Name
have one of the two following forms:

- a 16-bit C string literal, which is then converted to an 8-bit string in
  order for the lookup to occur;

- an 8-bit C string literal converted to a 16-bit string, which is then
  converted back to an 8-bit string in order for the lookup to occur.

This patch introduces and uses alternative methods that can take an 8-bit C
string literal, which requires changing some signatures in other methods and
functions. It replaces all C++ uses of the old methods.

The patch also changes the existing {Get,Format}StringFromName() methods so
they take an AUTF8String argument for the name instead of a wstring, because
that's nicer for JS code.

Even though there is a method for C++ code and a different one for JS code,
|binaryname| is used so that the existing method names can be used for the
common case in both languages.

The change reduces the number of NS_ConvertUTF8toUTF16 and
NS_ConvertUTF16toUTF8 conversions while running Speedometer v2 from ~270,000 to
~160,000. (Most of these conversions involved the string
"deprecatedReferrerDirective" in nsCSPParser.cpp.)

--HG--
extra : rebase_source : 3bee57a501035f76a81230d95186f8c3f460ff8e
2017-07-12 15:13:37 +10:00
..
resources Bug 641120 - Enhance PKCS #11 module load dialog. r=keeler 2017-04-18 22:18:53 +08:00
moz.build Bug 1346315 - Enable gcc/clang -Wextra for security/apps/, security/manager/pki/ and security/manager/ssl/. r=keeler 2017-04-04 16:56:26 +08:00
nsASN1Tree.cpp Bug 1018486 - Part 8: Various other changes, r=smaug 2016-09-07 10:50:45 -04:00
nsASN1Tree.h Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
nsIASN1Tree.idl Bug 1366584 - Add initial [must_use] properties to PSM IDL files. r=keeler 2017-05-25 21:56:04 +08:00
nsNSSDialogHelper.cpp Bug 1378712 - Remove all trailing whitespaces r=Ehsan 2017-07-06 14:00:35 +02:00
nsNSSDialogHelper.h Bug 1308888 - Simplify passing handle to the cert to view in the cert viewer. r=keeler 2016-10-21 00:33:36 +08:00
nsNSSDialogs.cpp Bug 1380227 - Avoid many UTF16toUTF8 and UTF8toUTF16 conversions in nsStringBundle. r=emk. 2017-07-12 15:13:37 +10:00
nsNSSDialogs.h Bug 1142350 - Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central. r=keeler 2016-09-21 19:34:12 +08:00
nsPKIModule.cpp Bug 1142350 - Remove nsIUserCertPicker, nsICertPickDialogs and associated code from mozilla-central. r=keeler 2016-09-21 19:34:12 +08:00