mirror of
https://github.com/mozilla/gecko-dev.git
synced 2025-02-17 14:25:49 +00:00
![Nathan Froyd](/assets/img/avatar_default.png)
There are two instances: - MappableSeekableZStream::Create uses ScopedDeletePtr, which is actually a little odd, since MappableSeekableZStream, as a Mappable, is refcounted, and it's unusual to use two different kinds of smart pointers for a single class. I think the more natural thing would be for MappableSeekableZStream::Create to return an already_AddRefed, but that change spirals out of the realm of "simple refactoring" quickly. - SzipCompress::run uses ScopedDeletePtr along with some dubious use of raw pointers. I changed things out for UniquePtr and also tidied the memory management a bit, which I think makes things a little clearer.