mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-12-01 17:23:59 +00:00
73710e3148
After removing `optional` in Bug 1712804, we need to add a variant back here because there's fallible dependencies. However, I've tweaked the re-introduction of the feature to require a specific repercussion message as well. This seemed like a decent tradeoff - the developer becomes aware that the failure is bad, it has repercussions, but it's not a blocking issue. Additionally, since we're printing pip's output, the developer will be able to see the underlying error causing the warning. I also added comment functionality to requirements definitions to allow adjacent documentation of why some requirements are fallible. (Related: I'm looking forward to `mach_bootstrap` not needing to parse requirements definitions. Almost there!) Note that we'll temporarily lose the "pinned" nature of the three moved dependencies until dependency locking is implemented for Mach requirements definitions. Also note that the pinned `zstandard_requirements.txt` can't be removed like the other files because it still has a dangling usage. Finally, in preparation for review: I didn't make `PypiOptionalSpecifier` extend `PypiSpecifier` because I figured that the benefit of flexibility (easier to allow implementations to diverge without needing to untangle an inheritance relationship) was larger than the cost of needing to add properties to both specifiers. If we wanted re-use, I'd probably have `PypiOptionalSpecifier` _contain_ a `PypiSpecifier`, but then you have to reach deeper into the object to get data, so *shrug*. Differential Revision: https://phabricator.services.mozilla.com/D119835 |
||
|---|---|---|
| .. | ||
| autoconf | ||
| build-clang | ||
| build-infer | ||
| build-rust | ||
| clang-plugin | ||
| compare-mozconfig | ||
| debian-packages | ||
| docs | ||
| gyp_includes | ||
| liblowercase | ||
| macosx | ||
| moz.configure | ||
| package/mac_osx | ||
| pgo | ||
| sanitizers | ||
| sparse-profiles | ||
| tests/cram | ||
| unix | ||
| valgrind | ||
| win32 | ||
| win64 | ||
| win64-aarch64 | ||
| workspace-hack | ||
| __init__.py | ||
| .gdbinit | ||
| .gdbinit.loader | ||
| .gdbinit.py.in | ||
| .lldbinit.in | ||
| appini_header.py | ||
| application.ini.in | ||
| binary-location.mk | ||
| build_virtualenv_packages.txt | ||
| buildconfig.py | ||
| cargo-host-linker | ||
| cargo-host-linker.bat | ||
| cargo-linker | ||
| cargo-linker.bat | ||
| checksums.py | ||
| common_virtualenv_packages.txt | ||
| defines.sh | ||
| dumbmake-dependencies | ||
| gecko_templates.mozbuild | ||
| gen_symverscript.py | ||
| gen_test_packages_manifest.py | ||
| gn.mozbuild | ||
| gyp_base.mozbuild | ||
| gyp.mozbuild | ||
| mach_bootstrap.py | ||
| mach_virtualenv_packages.txt | ||
| midl.py | ||
| moz-automation.mk | ||
| moz.build | ||
| mozconfig.artifact | ||
| mozconfig.artifact.automation | ||
| mozconfig.automation | ||
| mozconfig.cache | ||
| mozconfig.clang-cl | ||
| mozconfig.comm-support | ||
| mozconfig.common | ||
| mozconfig.common.override | ||
| mozconfig.lld-link | ||
| mozconfig.no-compile | ||
| mozconfig.rust | ||
| mozconfig.wasm-sandboxing | ||
| mozconfig.win-common | ||
| non-unified-compat | ||
| psutil_requirements.in | ||
| psutil_requirements.txt | ||
| qemu-wrap | ||
| RunCbindgen.py | ||
| templates.mozbuild | ||
| update-settings.ini | ||
| upload_generated_sources.py | ||
| upload.py | ||
| variables.py | ||
| windows_toolchain.py | ||
| zstandard_requirements.in | ||
| zstandard_requirements.txt | ||