mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-16 23:05:42 +00:00
6f0d1ac596
The completion node was wrongly positioned as soon as the input overflowed. We fix this by setting the completionNode height in resizeInput, like we do for the inputNode. The inputNode takes the whole remaining vertical space when starting the console. But when typing, the height is computed and set according to what's in the input. Which means the input wasn't taking the remaining space anymore, which could be weird (e.g. if the user wants to select some text by starting dragging below the actual input, although the UI would indicate it is possible). The autocompletionPopup was a bit off due to 2 things: - in the function that was returning the chevronWidth, we were subtracting the autocomplete popup padding. But the autocomplete popup already handles that itself. - in the function that was computing the character width, we were using offsetWidth which returned a rounded value. This means that the further the autocompletion was displayed at, the more the popup would be off. We use getBoundingClientRect().width instead which gives us a decimal value. And we also make sure to not alter the scrolling position in the inputNode when accepting an autocompletion result (a test is added). Differential Revision: https://phabricator.services.mozilla.com/D4207 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| client | ||
| docs | ||
| platform | ||
| server | ||
| shared | ||
| startup | ||
| .eslintrc.js | ||
| .eslintrc.mochitests.js | ||
| .eslintrc.xpcshell.js | ||
| CODE_OF_CONDUCT.md | ||
| moz.build | ||
| templates.mozbuild | ||